]> git.proxmox.com Git - mirror_edk2.git/commit
MdeModulePkg/FileExplorerLib: remove redundant null pointer check
authorwenyi xie <xiewenyi2=huawei.com@groups.io>
Thu, 26 Nov 2020 01:50:33 +0000 (09:50 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Fri, 4 Dec 2020 05:56:09 +0000 (05:56 +0000)
commitc02bdb276baf8c37a42c87dff68fb0d3f264b124
tree7014be0515305671d87dc292a6162c3937cd2573
parent31e8a47b62a4f3dc45d8f9bbf3529a188e867a87
MdeModulePkg/FileExplorerLib: remove redundant null pointer check

If "Info" is a valid pointer to an EFI_FILE_SYSTEM_VOLUME_LABEL
structure, then "Info->VolumeLabel" denotes a valid array object.
When the "Info->VolumeLabel" expression is evaluated, as seen in
the LibFindFileSystem(), it is implicitly converted to
(&Info->VolumeLabel[0]). Because the object described by the
expression (Info->VolumeLabel[0]) is a valid CHAR16 object, its
address can never compare equal to NULL. Therefore, the condition
(Info->VolumeLabel == NULL) will always evaluate to FALSE.
Substitute the constant FALSE into the "if" statement, and
simplify the resultant code (eliminate the dead branch).

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
MdeModulePkg/Library/FileExplorerLib/FileExplorer.c