]> git.proxmox.com Git - mirror_edk2.git/commit
OvmfPkg/PlatformBootManagerLib: Don't update progress if Pcd is 0
authorPete Batard <pete@akeo.ie>
Mon, 14 Oct 2019 15:03:10 +0000 (16:03 +0100)
committerLaszlo Ersek <lersek@redhat.com>
Wed, 16 Oct 2019 16:27:37 +0000 (18:27 +0200)
commitc3c90d8aa7e6c43e8564cb44dc8f73d0565ad122
treed272c33c78e6bd35dfafe4eaf369645e60b94964
parentcd70b1a71d30d0fff4c549a309682fdf127aaae6
OvmfPkg/PlatformBootManagerLib: Don't update progress if Pcd is 0

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2266

Independently of how we decide to address other aspects of the regression
introduced with commit 2de1f611be06ded3a59726a4052a9039be7d459b, it doesn't
make much sense to call for a progress update if PcdPlatformBootTimeOut is
zero.

PcdPlatformBootTimeOut 0, which is the cause of the bug (division by zero)
should be considered to indicate that a platform is not interested in
displaying a progress report, so we alter PlatformBootManagerWaitCallback
to behave that way.

We also change one variable name to make the code more explicit.

Signed-off-by: Pete Batard <pete@akeo.ie>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Message-Id: <20191014150311.16740-2-pete@akeo.ie>
OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c