]> git.proxmox.com Git - mirror_edk2.git/commit
OvmfPkg: simply use the Bochs interface for vmsvga
authoryuchenlin <yuchenlin@synology.com>
Wed, 7 Nov 2018 03:47:13 +0000 (11:47 +0800)
committerLaszlo Ersek <lersek@redhat.com>
Tue, 20 Nov 2018 19:49:15 +0000 (20:49 +0100)
commitd021868ccf49e2a39664021909354ef1150b0a6d
tree6fb4594a821f377d7aa80567fc93d78ccdb177d0
parent330e18555cd246465e0229e1daa1a72287d3274d
OvmfPkg: simply use the Bochs interface for vmsvga

BAR  |    std vga     |  vmsvga
---------------------------------
0    |   Framebuffer  | I/O space
1    |   Reserved     | Framebuffer
2    |   MMIO         | FIFO

- We cannot recognize VMW SVGA as BOCHS because that would confuse the
  IsQxl setting in QemuVideoControllerDriverStart(),

- We cannot recognize VMW SVGA as BOCHS_MMIO because BAR2 on VMW SVGA is
  not the BOCHS MMIO BAR (we can only use port IO).

Therefore the list of reasons for which we should introduce
QEMU_VIDEO_VMWARE_SVGA should name three reasons:

 (1) Get framebuffer from correct PCI BAR
 (2) Prevent using BAR2 for MMIO
 (3) Prevent mis-recognizing VMW SVGA as QXL

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: yuchenlin <yuchenlin@synology.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Regression-tested-by: Laszlo Ersek <lersek@redhat.com>
Tested-by: Laszlo Ersek <lersek@redhat.com>
OvmfPkg/QemuVideoDxe/Driver.c
OvmfPkg/QemuVideoDxe/Gop.c
OvmfPkg/QemuVideoDxe/Qemu.h