]> git.proxmox.com Git - mirror_edk2.git/commit
EmulatorPkg/Sec: Change scope of PpiArray[10]
authorAndrew Fish <afish@apple.com>
Thu, 15 Aug 2019 20:00:31 +0000 (13:00 -0700)
committerMichael D Kinney <michael.d.kinney@intel.com>
Mon, 19 Aug 2019 16:57:28 +0000 (09:57 -0700)
commitd47778e52275daa3a6a702e3182dc85e11beadb7
treea49c5ee7c64e3c79034d3978f030f34c24f2c8ce
parent6ed2c8bed3d213401deff18323c929e4e6743cec
EmulatorPkg/Sec: Change scope of PpiArray[10]

The local variable PpiArray[10] is declared in the middle
of the SEC module _ModuleEntryPoint() with its own scope.
However, PpiArray has a dangling reference to its location
on the stack after the scope is closed.  This causes issues
with some compilers (e.g. XCODE5).

The fix is to move the declaration of PpiArray[10] to
the beginning of the function, so it is scoped correctly
for all references to this local variable and references
to its location.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Andrew Fish <afish@apple.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Tested-by: Andrew Fish <afish@apple.com>
EmulatorPkg/Sec/Sec.c