]> git.proxmox.com Git - mirror_edk2.git/commit
OvmfPkg/OvmfXen: Remove DEBUG_ON_SERIAL_PORT
authorAnthony PERARD <anthony.perard@citrix.com>
Thu, 23 Apr 2020 09:53:54 +0000 (10:53 +0100)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Tue, 28 Apr 2020 21:12:01 +0000 (21:12 +0000)
commitd5d60a43314856a2fc8fd72df5df0b329702655b
treeb9ce6a05c1b037fd12fff56990e795b3c2f6573b
parent099dfbb29d8bf0a30e397e3f5baf1da437b8f0ba
OvmfPkg/OvmfXen: Remove DEBUG_ON_SERIAL_PORT

Remove support for DEBUG_ON_SERIAL_PORT because OvmfXen can't be build
with it due to a circular dependency:
  DebugLib        : BaseDebugLibSerialPort ->
  SerialPortLib   : XenConsoleSerialPortLib ->
  XenHypercallLib : XenHypercallLib ->
  DebugLib

Also, if that dependency is fixed, I think it would be harder to find
which console the debug is sent to when running an HVM guest. The xen
console isn't the serial console used by default. Furthermore,
XenHypercallLib isn't initialised early enough, so we would loose
debug output from the SEC phase and early PEI phase.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20200423095358.2518197-2-anthony.perard@citrix.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
OvmfPkg/OvmfXen.dsc