]> git.proxmox.com Git - mirror_edk2.git/commit
OvmfPkg/VirtioBlkDxe: Check the return status of unmap data buffer
authorBrijesh Singh <brijesh.singh@amd.com>
Wed, 30 Aug 2017 16:28:29 +0000 (12:28 -0400)
committerLaszlo Ersek <lersek@redhat.com>
Wed, 30 Aug 2017 16:53:54 +0000 (18:53 +0200)
commitea8314e4402f6c385b6e41e4f7803853e64e421b
treefcab649ac3466a135f2c20c7647f9468bf34e0b9
parent877f4460b3e37064f37fe85375024dce04f5e05e
OvmfPkg/VirtioBlkDxe: Check the return status of unmap data buffer

when "RequestIsWrite" is FALSE -- i.e., the CPU wants data from
the device, we map "Buffer" for VirtioOperationBusMasterWrite. In
this case, checking the return status of

Dev->VirtIo->UnmapSharedBuffer (Dev->VirtIo, BufferMapping);

is must. If the unmapping fails, then "Buffer" will not contain the
actual data from the device, and we must fail the request with
EFI_DEVICE_ERROR.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
[lersek@redhat.com: fix typos in subject]
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Tested-by: Laszlo Ersek <lersek@redhat.com>
OvmfPkg/VirtioBlkDxe/VirtioBlk.c