1 2008-07-22 Paul Jakma <paul.jakma@sun.com>
3 * bgp_{packet,route,advertise}.c: change to compiler testing of
4 DISABLE_BGP_ANNOUNCE, rather than cpp.
6 2008-07-22 MIYAJIMA Mitsuharu <miyajima.mitsuharu@anchor.jp>
8 * bgp_packet.c: (bgp_update_packet_eor) Fix crash triggerable
9 if a bgpd was compiled with --disable-bgp-announce and if GR is
12 2008-07-22 Paul Jakma <paul.jakma@sun.com>
14 * bgp_community.c: (community_str2com) assigns defaults to local
16 * bgp_attr.c: (bgp_attr_parse) match format specifier to arg
17 * bgp_table.{c,h}: (bgp_table_top) can take a * to a const, quelling
18 warning in bgp_route.c
20 2008-07-21 Paul Jakma <paul.jakma@sun.com>
23 * bgp_packet.c: (bgp_open_receive) fix warning in a zlog call
24 * bgp_vty.c: (bgp_vty_return) add return code
25 * bgpd.c: (bgp_master_init) setup the socket list.
26 * bgp_network.c: Remove the dual IPv4/6 socket thing for now, which
27 was implemented by Michael, until such time as its clear its
28 required for Linux (see sockopt comments). IPv6 support, including
29 IPv4 sessions on AF_INET6 sockets, therefore is broken, and the
30 '-l 0.0.0.0' arguments would need to be given to bgpd to make
33 2008-07-21 Michael H. Warfield <mhw@wittsend.com>
34 YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
35 Tomohiko Kusuda <kusuda@inetcore.com>
36 Leigh Brown <leigh@solinno.co.uk>
38 * bgp_network.c: (bgp_md5_set_one) shim between libzebra tcp-md5
40 (bgp_md5_set_socket) Helper for bgp_connect
41 (bgp_md5_set) setup TCP-MD5SIG for the given peer.
42 (bgp_connect) call out to bgp_md5_set_socket for the outgoing
44 (bgp_socket) save references to the listen sockets, needed if
45 TCP-MD5SIG is applied later or changed.
46 * bgp_vty.c: (*neighbor_password_cmd) New 'neighbor ... password'
48 * bgpd.c: (peer_{new,delete) manage TCP-MD5 password
49 (peer_group2peer_config_copy) inherit TCP-MD5 password
50 (peer_password_{un,}set) orchestrate the whole add/remove of TCP-MD5
51 passwords: applying checks, stopping peers, and trying to return
53 (bgp_config_write_peer) save password.
54 Fix missing newline in writeout of neighbor ... port.
56 2008-07-02 MIYAJIMA Mitsuharu <miyajima.mitsuharu@anchor.jp>
58 * *.c: CMD_AS_RANGE was being used inside command strings, and thus
59 not being expanded, fix by dequoting.
61 2008-07-02 Stephen Hemminger <stephen.hemminger@vyatta.com>
63 * bgp_table.{c,h}: (bgp_table_finish) Take a double pointer and
64 scrub pointer in caller, so fixing double-free crashes seen
65 with route-server-client configuration.
66 * *.c: Adjust all callers of bgp_table_finish
68 2008-07-02 Paul Jakma <paul.jakma@sun.com>
70 * bgp_table.{c,h}: (bgp_node_delete, bgp_table_free) shouldn't be
73 2008-06-07 Paul Jakma <paul@jakma.org>
75 * bgp_attr.{c,h}: (bgp_mp_{un,}reach_parse) export, for unit tests.
76 * bgp_attr.c: (bgp_mp_reach_parse) Add logging. Tighten length test
77 to bounds check against the attribute length rather than the
80 2008-06-01 jfletche@gmail.com
82 * bgp_attr.c: (bgp_attr_aspathlimit) fix silly bug in flags check
83 that was causing BGP to drop sessions if it received a
84 aspath-limit with partial set. Fixes bug #419.
86 2008-04-10 Denis Ovsienko
88 * bgp_aspath.[ch]: (aspath_filter_exclude) New function allows
89 filtering out arbitrary ASns from AS_PATH attribute.
90 * bgp_aspath.[ch]: (aspath_print_vty) Accept suffix to let calling
91 functions signal, if they want the separator or not.
92 * bgp_route.c: (route_vty_out, route_vty_out_tmp, damp_route_vty_out,
93 flap_route_vty_out, route_vty_out_detail) Fix aspath_print_vty()
94 calls to have AS_PATH output nicely.
95 * bgp_routemap.c: Introduce "set as-path exclude" route-map command
96 to employ new filtering functionality.
98 2008-03-13 Paul Jakma <paul.jakma@sun.com>
100 * (various) Remove 0 entries from struct message's, unneeded due to
101 recent improvements in mes_lookup/LOOKUP.
103 2008-01-29 Jorge Boncompte <jorge@dti2.net>
105 * bgp_network.c: (bgp_socket) IPv4-only version crashes if -l is not
106 used as address will be null.
108 2007-12-22 Paul Jakma <paul.jakma@sun.com>
110 * Fix series of vulnerabilities reported by "Mu Security
111 Research Team", where bgpd can be made to crash by sending
112 malformed packets - requires that bgpd be configured with a
114 * bgp_attr.c: (bgp_attr_as4_path) aspath_parse may fail, only
115 set the attribute flag indicating AS4_PATH if we actually managed
117 (bgp_attr_munge_as4_attrs) Assert was too general, it is possible
118 to receive AS4_AGGREGATOR before AGGREGATOR.
119 (bgp_attr_parse) Check that we have actually received the extra
120 byte of header for Extended-Length attributes.
121 * bgp_attr.h: Fix BGP_ATTR_MIN_LEN to account for the length byte.
122 * bgp_open.c: (cap_minsizes) Fix size of CAPABILITY_CODE_RESTART,
123 incorrect -2 left in place from a development version of as4-path
125 * bgp_packet.c: (bgp_route_refresh_receive) ORF length parameter
126 needs to be properly sanity checked.
128 2007-12-18 Denis Ovsienko
130 * bgp_routemap.c: (no_set_aspath_prepend) This command cancelled
131 existing "set" command regardless if "no set" matched it or not.
134 2007-11-13 Paul Jakma <paul.jakma@sun.com>
136 * bgp_main.c: Small fix, format string parameters should never
137 be NULL - it's not strictly valid and some libc's don't let
140 2007-10-30 Nick Hilliard <nick@inex.ie>
142 * bgp_main.c: Add 'listenon' argument, to pass address to bind
144 * bgp_network.c: (bgp_socket) Extend to take bind address.
145 * bgpd.c: (bgp_init) Pass stored address.
146 * bgpd.h: (struct bgp_master) storage for bind address
148 2007-09-27 Paul Jakma <paul.jakma@sun.com>
150 * bgp_aspath.c: (assegment_normalise) remove duplicates from
152 (aspath_reconcile_as4) disregard a broken part of the RFC around
153 error handling in path reconciliation.
155 2007-09-25 Paul Jakma <paul.jakma@sun.com>
157 * bgp_open.c: (peek_for_as4_capability) Fix to work.
158 * bgp_packet.c: (bgp_open_receive) Fix sanity check of as4.
160 2007-09-18 Paul Jakma <paul.jakma@sun.com>
162 * bgp_open.c: (bgp_capability_as4) debug printf inline with others.
163 (peek_for_as4_capability) There's no need to signal failure, as
164 failure is better dealt with through full capability parser -
165 just return the AS4, simpler.
166 * bgp_packet.c: (bgp_open_receive) Update to match
167 peek_for_as4_capability change.
168 Allow use of BGP_AS_TRANS by 2b speakers.
169 Use NOTIFY_OPEN_ERR rather than CEASE for OPEN parsing errors.
170 (bgp_capability_msg_parse) missing argument to debug print
171 (bgp_capability_receive) missing return values.
174 2007-07-25 Paul Jakma <paul.jakma@sun.com>
176 * Remove 2-byte size macros, just make existing macros take
177 argument to indicate which size to use.
178 Adjust all users - typically they want '1'.
179 * bgp_aspath.c: (aspath_has_as4) New, return 1 if there are any
181 (aspath_put) Return the number of bytes actually written, to
182 fix the bug Juergen noted: Splitting of segments will change
183 the number of bytes written from that already written to the
185 (aspath_snmp_pathseg) Pass 2-byte flag to aspath_put. SNMP
186 is still defined as 2b.
187 (aspath_aggregate) fix latent bug.
188 (aspath_reconcile_as4) AS_PATH+NEW_AS_PATH reconciliation
190 (aspath_key_make) Hash the AS_PATH string, rather than
191 just taking the addition of assegment ASes as the hash value,
192 hopefully sligthly more collision resistant.
193 (bgp_attr_munge_as4_attrs) Collide the NEW_ attributes
194 together with the OLD 2-byte forms, code Juergen
195 had in bgp_attr_parse but re-organised a bit.
196 (bgp_attr_parse) Bunch of code from Juergen moves
197 to previous function.
198 (bgp_packet_attribute) Compact significantly by
199 just /always/ using extended-length attr header.
200 Fix bug Juergen noted, by using aspath_put's
201 (new) returned size value for the attr header rather
202 than the (guesstimate) of aspath_size() - the two could
203 differ when aspath_put had to split large segments, unlikely
204 this bug was ever hit in the 'wild'.
205 (bgp_dump_routes_attr) Always use extended-len and
206 use aspath_put return for header length. Output 4b ASN
207 for AS_PATH and AGGREGATOR.
208 * bgp_ecommunity.c: (ecommunity_{hash_make,cmp}) fix
209 hash callback declarations to match prototypes.
210 (ecommunity_gettoken) Updated for ECOMMUNITY_ENCODE_AS4,
211 complete rewrite of Juergen's changes (no asdot support)
212 * bgp_open.c: (bgp_capability_as4) New, does what it says
214 (peek_for_as4_capability) Rewritten to use streams and
216 * bgp_packet.c: (bgp_open_send) minor edit
217 checked (in the abstract at least) with Juergen.
218 Changes are to be more accepting, e.g, allow AS_TRANS on
220 * (general) Update all commands to use CMD_AS_RANGE.
221 * bgp_vty.c: (bgp_clear) Fix return vals to use CMD_..
222 Remove stuff replicated by VTY_GET_LONG
223 (bgp_clear_vty) Return bgp_clear directly to vty.
226 2007-07-25 Juergen Kammer <j.kammer@eurodata.de>
228 * (general) AS4 support.
229 * bgpd.h: as_t changes to 4-bytes.
230 * bgp_aspath.h: Add BGP_AS4_MAX and BGP_AS_TRANS defines.
231 * bgp_aspath.c: AS_VALUE_SIZE becomes 4-byte, AS16_VALUE_SIZE
233 Add AS16 versions of length calc macros.
234 (aspath_count_numas) New, count number of ASes.
235 (aspath_has_as4) New, return 1 if there are any as4's in a
237 (assegments_parse) Interpret assegment as 4 or 2 byte,
238 according to how the caller instructs us, with a new
240 (aspath_parse) Add use32bit argument to pass to
241 assegments_parse. Adjust all its callers to pass 1, unless
243 (assegment_data_put) Adjust to be able to write 2 or 4 byte
244 AS, according to new use32bit argument.
245 (aspath_put) Adjust to write 2 or 4.
246 (aspath_gettoken) Use a long for passed in asno.
247 * bgp_attr.c: (attr_str) Add BGP_ATTR_AS4_PATH and
248 BGP_ATTR_AS4_AGGREGATOR.
249 (bgp_attr_aspath) Call aspath_parse with right 2/4 arg, as
250 determined by received-capability flag.
251 (bgp_attr_aspath_check) New, code previously in attr_aspath
252 but moved to new func so it can be run after NEW_AS_PATH
254 (bgp_attr_as4_path) New, handle NEW_AS_PATH.
255 (bgp_attr_aggregator) Adjust to cope with 2/4 byte ASes.
256 (bgp_attr_as4_aggregator) New, read NEW_AGGREGATOR.
257 (bgp_attr_parse) Add handoffs to previous parsers for the two
258 new AS4 NEW_ attributes.
259 Various checks added for NEW/OLD reconciliation.
260 (bgp_packet_attribute) Support 2/4 for AS_PATH and
261 AGGREGATOR, detect when NEW_ attrs need to be sent.
262 * bgp_debug.{c,h}: Add 'debug bgp as4'.
263 * bgp_dump.c: MRTv2 support, unconditionally enabled, which
264 supports AS4. Based on patches from Erik (RIPE?).
265 * bgp_ecommunity.c: (ecommunity_ecom2str) ECOMMUNITY_ENCODE_AS4
267 * bgp_open.c: (peek_for_as4_capability) New, peek for AS4
268 capability prior to full capability parsing, so we know which
269 ASN to use for struct peer lookup.
270 (bgp_open_capability) Always send AS4 capability.
271 * bgp_packet.c: (bgp_open_send) AS4 handling for AS field
272 (bgp_open_receive) Peek for AS4 capability first, and figure
273 out which AS to believe.
274 * bgp_vty.c: (bgp_show_peer) Print AS4 cap
276 2007-09-17 Paul Jakma <paul.jakma@sun.com>
278 * bgp_open.c: (bgp_capability_mp) We were setting
279 afc_nego[safi][safi] rather than afc_nego[afi][safi], thus
280 failling to announce any non-IPv4 prefixes. Remove the extra,
283 2007-09-07 Paul Jakma <paul.jakma@sun.com>
285 * (general) bgpd can be made crash by remote peers if debug
286 bgp updates is set, due to NULL pointer dereference.
287 Reported by "Mu Security Research Team",
288 <security@musecurity.com>.
289 * bgp_attr.c: (bgp_attr_community) If community length is 0,
290 don't set the community-present attribute bit, just return
292 * bgp_debug.c: (community_str,community_com2str) Check com
293 pointer before dereferencing.
295 2007-08-31 Paul Jakma <paul.jakma@sun.com>
297 * (general) Add 'bgp open-accept' option, to allow bgpd to send OPEN
298 on accepted connections, i.e. to not wait till after
299 collision-detect to send OPEN, which appears to be allowed in
300 RFC4271. This may help speed up establishing sessions, or help
301 avoid FSM problems with sessions to certain peers. Not enabled by
304 2007-08-27 Paul Jakma <paul.jakma@sun.com>
306 * bgp_route.c: (bgp_announce_check) Fix bug #398, slight
307 modification of Vladimir Ivanov's suggested fix - to keep
308 memory alloc conditional.
309 (bgp_process_announce_selected) Don't take struct attr as
310 argument, none of the callers need it and it needlessly
311 distances allocation from use.
312 Free the extended attr, the attr itself is on the stack.
314 * bgp_attr.c: (bgp_packet_attribute) Remove incorrect assert,
315 and adjust conditional to test attr->extra, diagnosis by
316 Vladimir Ivanov in bug #398.
318 2007-08-27 Vladimir Ivanov <wawa@yandex-team.ru>
320 * bgp_route.c: (bgp_announce_check_rsclient) copy of
321 ri->attr is no longer deep enough, due to addition of
322 attr->extra. It should use bgp_attr_dup, as
323 bgp_announce_check() does.
325 2007-08-23 Paul Jakma <paul.jakma@sun.com>
327 * bgp_regex.c: (bgp_regcomp) Pass NOSUB flag to regcomp to
328 prevent parsing of substitutions, which can have profound
329 performance effects on bgpd and are of no use to the CLI
330 anyway. How much it helps depends on the regex
333 2007-07-31 Paul Jakma <paul.jakma@sun.com>
335 * (general) Support for draft-ietf-idr-as-pathlimit-03.
336 * bgp_attr.h: (struct attr) Add pathlimit struct
337 bgp_attr.c: (attr_str) Add BGP_ATTR_AS_PATHLIMIT string.
338 (attrhash_key_make) tally pathlimit too
339 (attrhash_cmp) cmp pathlimit attr
340 (bgp_attr_aspathlimit) New, parse AS_PATHLIMIT attr.
341 (bgp_attr_parse) ditto
342 (bgp_packet_attribute) Write out AS_PATHLIMIT when set
343 (bgp_dump_routes_attr) ditto
344 * bgp_route.h: (struct bgp_static) Add TTL field
345 * bgp_route.c: (bgp_announce_check) Drop paths that are over
346 their hop-count TTL before sending via EBGP.
347 Mangle ASN in pathlimit for confeds/private as best we can.
348 (bgp_static_update_{rsclient,main}) Add any configure pathlimit
350 (bgp_pathlimit_update_parents) New, update atomic-aggr setting for
351 parents of an aspathlimit'ed static.
352 (bgp_static_set) Add TTL argument, for all the 'bgp network'
354 Call previous for TTL changed statics.
355 (bgp_static_unset) Call pathlimit_update_parents.
356 (various bgp network commands) Add 'pathlimit <0-255>' qualifier
357 to all the various forms, bar route-map - which can set ttl
359 * bgp_routemap.c: (general) Add support for 'set pathlimit ttl' and
360 'match pathlimit as'.
362 2007-07-26 Paul Jakma <paul.jakma@sun.com>
364 * (general) Clean up and compact capability parsing slightly.
365 Consolidate validation of length and logging of generic TLV, and
366 memcpy of capability data, thus removing such from cap specifc
367 code (not always present or correct).
368 * bgp_open.h: Add structures for the generic capability TLV header
369 and for the data formats of the various specific capabilities we
370 support. Hence remove the badly named, or else misdefined, struct
372 * bgp_open.c: (bgp_capability_vty_out) Use struct capability_mp_data.
373 Do the length checks *before* memcpy()'ing based on that length
374 (stored capability - should have been validated anyway on input,
376 (bgp_afi_safi_valid_indices) new function to validate (afi,safi)
377 which is about to be used as index into arrays, consolidates
378 several instances of same, at least one of which appeared to be
380 (bgp_capability_mp) Much condensed.
381 (bgp_capability_orf_entry) New, process one ORF entry
382 (bgp_capability_orf) Condensed. Fixed to process all ORF entries.
383 (bgp_capability_restart) Condensed, and fixed to use a
384 cap-specific type, rather than abusing capability_mp.
385 (struct message capcode_str) added to aid generic logging.
386 (size_t cap_minsizes[]) added to aid generic validation of
387 capability length field.
388 (bgp_capability_parse) Generic logging and validation of TLV
389 consolidated here. Code compacted as much as possible.
390 * bgp_packet.c: (bgp_open_receive) Capability parsers now use
391 streams, so no more need here to manually fudge the input stream
393 (bgp_capability_msg_parse) use struct capability_mp_data. Validate
394 lengths /before/ memcpy. Use bgp_afi_safi_valid_indices.
395 (bgp_capability_receive) Exported for use by test harness.
396 * bgp_vty.c: (bgp_show_summary) fix conversion warning
397 (bgp_show_peer) ditto
398 * bgp_debug.h: Fix storage 'extern' after type 'const'.
400 2007-07-31 Lorenzo Colitti <lorenzo@colitti.com>
402 * bgp_dump.c: (general) Add comments to code.
403 (bgp_dump_interval_add) remove some redundant lines.
404 (bgp_dump_set) Use enum for type argument.
405 Avoid scheduling dump twice if exact same command
408 2007-06-22 Paul Jakma <paul.jakma@sun.com>
410 * bgp_fsm.c: (struct FSM) Bug #368. TCP Errors during OpenSent
411 should cycle to Active, not to Idle or else peer bringup can
412 race and cycle Idle<->Active. Reported and fix tested by
415 2007-05-25 Paul Jakma <paul.jakma@sun.com>
417 * bgp_route.c: (bgp_default_originate) Sanity check added
418 previously was broken and always failed, thus this function
419 never could run, bug #370.
421 2007-05-03 Paul Jakma <paul.jakma@sun.com>
423 * bgp_route.h: (struct info) Move less frequently used
424 fields to a lazily allocated struct info_extra.
425 Export bgp_info_extra_get
426 * bgp_route.c: (bgp_info_extra_new) allocate extra
427 (bgp_info_extra_free) Free damp info and the info_extra.
428 (bgp_info_extra_get) Retrieve the info_extra of a struct
429 info, allocating as required.
430 (generally) adjust to use info->extra
431 * bgp_damp.c: (generally) use bgp_info_extra_get to access
433 * bgp_attr.h: Move rarely allocated attributes from struct attr
434 to a struct attr_extra, for a substantial saving in size of
436 * bgp_attr.c: (bgp_attr_extra_{new,free}), new, self-explanatory.
437 (bgp_attr_extra_get) Get the attr_extra for a given struct
438 attr, allocating it if needs be.
439 (bgp_attr_dup) Shallow copy the struct attr and its attr_extra.
440 (generally) adjust to know about attr->extra.
441 * bgp_debug.c: (bgp_dump_attr) ditto
442 * bgp_vty.c: (show_bgp_memory) print attr and info extra sizes.
443 * bgp_nexthop.c: (generally) adjust to know about attr->extra
445 * bgp_{packet,routemap,snmp,zebra}.c: ditto
447 2007-04-22 Sebastien Tandel <sebastien@tandel.be>
448 * bgp_advertise.c : (baa_hash_alloc, baa_hash_key, baa_hash_cmp)
449 conforms to quagga hash API. Defines _hash_[alloc|key|cmp] with
450 void * arguments as defined by the API.
451 * bgp_aspath.c,h : (aspath_key_make) conforms to quagga hash API.
452 Defines _hash_[alloc|key|cmp] with void * arguments as defined by
454 * bgp_attr.c,h : (cluster_hash_alloc, cluster_hash_key_make,
455 cluster_hash_cmp, transit_hash_alloc, transit_hash_key_make,
456 transit_hash_cmp, attrhash_key_make, attrhash_cmp,
457 bgp_attr_hash_alloc) conforms to quagga hash API. Defines
458 _hash_[alloc|key|cmp] with void * arguments as defined by the API.
459 * bgp_attr.h : Definition of BGP_ATTR_DEFAULT_WEIGHT.
460 * bgp_attr.c : (bgp_attr_default_intern) now uses
461 bgp_attr_default_set instead of duplicating the same code.
462 (general) Use of BGP_ATTR_DEFAULT_WEIGHT. Replace two 16 by
465 2007-04-15 Sebastien Tandel <sebastien@tandel.be>
467 * bgp_aspath.c: (aspath_as_add, aspath_segment_add) Minor performance
468 optimization: while loop should test one pointer instead of two.
470 2007-04-08 Paul Jakma <paul.jakma@sun.com>
472 * bgp_route.c: (general) Same bug as fixed on 2006-11-28 by ajs for
473 bgp static routes, but for main BGP RIB: Quick 'flap' of routes
474 can cause bgpd to mistake a new route for a duplicate route,
475 due to presence of removed, but not yet processed BGP RIB entry.
476 (bgp_update_rsclient) Ignore REMOVED bgp_info for duplicate,
477 restore route instead.
478 (bgp_update_main) Ditto.
479 * bgp_attr.c: (general) Bug #354: parsing of MP_REACH_NLRI and
480 MP_UNREACH_NLRI does not take sufficient care to ensure reads
481 from stream buffer stay in-bounds. Hence bgpd may attempt to read
482 beyond end of stream, if given a crafted packet. As it uses the
483 stream access methods to do so, this will typically result in
484 assert() being hit in stream.c. Where code is compiled without
485 assert() enabled, result is unknown.
486 (struct message attr_str) should be static.
487 (bgp_mp_reach_parse) Carefully check length remaining in stream
488 against amount desired to read from stream, prior to each read,
489 particularly where lengths are conditional on data obtained from
490 stream - using STREAM_READABLE.
491 Remove code to parse SNPA-number, it's a defunct field and changed
492 to a fixed size in latest BGP MP update RFC - log warning if
493 SNPA-number is not 0.
494 (bgp_mp_unreach_parse) Check withdraw_length carefully against
496 (bgp_attr_parse) If attribute-parser function returns error, log
498 Log attribute type on mismatch.
500 2007-04-07 Paul Jakma <paul.jakma@sun.com>
502 * bgpd.c: (general) Fix bug #352
503 (bgp_config_write_family_header) write ipv6/multicast
504 address family header.
505 (bgp_config_write) write out ipv6 multicast AF config.
507 2007-02-22 Paul Jakma <paul.jakma@sun.com>
509 * bgp_fsm.c: (bgp_fsm_change_status) Handle state change into
510 clearing or greater here. Simpler.
511 (bgp_event) Clearing state change work moved to previous
512 * bgp_route.c: (bgp_clear_route_node) Clearing adj-in here
513 is too late, as it leaves a race between a peer being deleted
514 and an identical peer being configured before clearing
515 completes, leading to a crash.
516 Simplest fix is to clean peers Adj-in up-front, rather than
518 (bgp_clear_route_table) Clear peer's Adj-In and Adj-Out
519 up-front here, rather than queueing such work.
520 Extensive comment added on the various bits of indexed data
521 that exist and how they need to be dealt with.
522 (bgp_clear_route) Update comment.
524 2006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
526 * bgp_nexthop.c: (bgp_connected_add, bgp_connected_delete)
527 Simplify logic by using new CONNECTED_PREFIX macro.
529 2006-12-07 Paul Jakma <paul.jakma@sun.com>
531 * bgp_fsm.c: Bug #302 fix, diagnosis, suggestions and testing
532 by Juergen Kammer <j.kammer@eurodata.de>. Fix follows from
533 his suggested fix, just made in a slightly different way.
534 (bgp_event) Transitions into Clearing always must call
535 bgp_clear_route_all().
536 (bgp_stop) No need to clear routes here, BGP FSM should do
539 2006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
541 * bgp_debug.h: Declare new bgp_debug_zebra conf and term flags,
542 and define BGP_DEBUG_ZEBRA.
543 * bgp_debug.c: Declare conf_bgp_debug_zebra and term_bgp_debug_zebra.
544 (debug_bgp_zebra, no_debug_bgp_zebra, undebug_bgp_zebra) New
545 functions to enable/disable bgp zebra debugging.
546 (no_debug_bgp_all) Turn off zebra debugging.
547 (show_debugging_bgp) Show whether zebra debugging is on.
548 (bgp_config_write_debug) Add 'debug bgp zebra' if configured.
549 (bgp_debug_init) Add new zebra debugging commands.
550 * bgp_zebra.c: (bgp_router_id_update, bgp_interface_add,
551 bgp_interface_delete, bgp_interface_up, bgp_interface_down,
552 bgp_interface_address_add, bgp_interface_address_delete,
553 zebra_read_ipv4, zebra_read_ipv6, bgp_zebra_announce,
554 bgp_zebra_withdraw, bgp_redistribute_set, bgp_redistribute_unset)
555 If zebra debugging is enabled, log an appropriate debug message.
557 2006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
559 * bgp_route.c: (bgp_info_restore) New function that undoes
560 the effects of a previous call to bgp_info_delete. This is
561 used when a route is deleted and quickly re-added before the
562 deletion has been processed.
563 (bgp_static_update_rsclient, bgp_static_update_main,
564 bgp_redistribute_add) Check whether a pre-existing route
565 has the BGP_INFO_REMOVED set, and, if so, we need to call
566 bgp_info_restore to resurrect it.
568 2006-10-27 Paul Jakma <paul.jakma@sun.com>
570 * bgp_route.c: (bgp_table_stats) oops, u_intXX_t should be
573 2006-10-19 Paul Jakma <paul.jakma@sun.com>
575 * bgpd.c: (peer_new) bgp element of peer absolutely must be
576 filled in, make peer_new() require it as argument and update
577 all callers. Fixes a crash reported by Jan 'yanek' Bortl and
578 Andrew Schorr where bgpd would crash in bgp_pcount_adjust
579 trying to dereference the bgp member of bgp->peer_self,
580 triggered through redistribution.
581 * bgp_route.c: (bgp_pcount_adjust) assert sanity of arguments.
583 2006-10-15 Paul Jakma <paul.jakma@sun.com>
585 * bgp_route.c: (bgp_table_stats_walker) NULL deref if table is
586 empty, bgp_table_top may return NULL, Coverity CID#73.
587 * bgp_packet.c: (bgp_update_packet) adv->rn can not be NULL,
588 check is bogus - changed to assert(), CID#64.
589 binfo is checked for NULL, but then dereferenced
590 unconditionally, fix, CID #63.
591 (bgp_withdraw_packet) Assert adv->rn is valid, as with
594 2006-10-14 Paul Jakma <paul.jakma@sun.com>
596 * bgp_fsm.h: Remove BGP_EVENT_FLUSH_ADD, dangerous and not
598 * bgp_fsm.c: (bgp_stop) Move BGP_EVENT_FLUSH to the top of the
599 of the function, otherwise it could flush a ClearingCompleted
601 * bgp_packet.c: Replace all BGP_EVENT_FLUSH_ADD with
602 BGP_EVENT_ADD, fixing bug #302.
604 2006-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
606 * bgpd.c: (peer_uptime) Fix printf format/arg mismatch in
607 zlog_warn message (%ld/size_t -> %lu/u_long).
609 2006-09-14 Paul Jakma <paul.jakma@sun.com>
611 * bgp_route.c: (bgp_table_stats_walker) Address space announced
612 should only count top-level unaggregateable prefixes, to
613 avoid falling afoul of anti-dodgy-accounting regulations
614 in various jurisdictions.. ;)
615 (bgp_process_queue_init) process queue hold time too high,
616 adds extra memory load. Change to be much lower, until such
617 time as it's made configurable.
619 2006-09-14 Paul Jakma <paul.jakma@sun.com>
621 * (general) fix the peer refcount issue exposed by previous, by
622 just removing refcounting of peer threads, which is mostly
623 senseless as they're references leading from struct peer,
624 which peer_free cancels anyway. No need to muck around..
625 * bgp_fsm.h: Just remove the refcounting from the various
626 TIMER/READ/WRITE/EVENT ON/OFF/ADD macros.
627 * bgp_fsm.c: (bgp_stop) use BGP_EVENT_FLUSH, no refcounts attached
629 (bgp_event) remove peer_unlock, events not refcounted.
630 * bgpd.c: (peer_free) flush events before free.
632 2006-09-14 Paul Jakma <paul.jakma@sun.com>
634 * (general) Fix some niggly issues around 'shutdown' and clearing
635 by adding a Clearing FSM wait-state and a hidden 'Deleted'
636 FSM state, to allow deleted peers to 'cool off' and hit 0
637 references. This introduces a slow memory leak of struct peer,
638 however that's more a testament to the fragility of the
639 reference counting than a bug in this patch, cleanup of
640 reference counting to fix this is to follow.
641 * bgpd.h: Add Clearing, Deleted states and Clearing_Completed
643 * bgp_debug.c: (bgp_status_msg[]) Add strings for Clearing and
645 * bgp_fsm.h: Don't allow timer/event threads to set anything
647 * bgp_fsm.c: (bgp_timer_set) Add Clearing and Deleted. Deleted
648 needs to stop everything.
649 (bgp_stop) Remove explicit fsm_change_status call, the
650 general framework handles the transition.
651 (bgp_start) Log a warning if a start is attempted on a peer
652 that should stay down, trying to start a peer.
653 (struct .. FSM) Add Clearing_Completed
654 events, has little influence except when in state
655 Clearing to signal wait-state can end.
656 Add Clearing and Deleted states, former is a wait-state,
657 latter is a placeholder state to allow peers to disappear
658 quietly once refcounts settle.
659 (bgp_event) Try reduce verbosity of FSM state-change debug,
660 changes to same state are not interesting (Established->Established)
661 Allow NULL action functions in FSM.
662 * bgp_packet.c: (bgp_write) Use FSM events, rather than trying
663 to twiddle directly with FSM state behind the back of FSM.
664 (bgp_write_notify) ditto.
665 (bgp_read) Remove the vague ACCEPT_PEER peer_unlock, or else
666 this patch crashes, now it leaks instead.
667 * bgp_route.c: (bgp_clear_node_complete) Clearing_Completed
668 event, to end clearing.
669 (bgp_clear_route) See extensive comments.
670 * bgpd.c: (peer_free) should only be called while in Deleted,
671 peer refcounting controls when peer_free is called.
672 bgp_sync_delete should be here, not in peer_delete.
673 (peer_delete) Initiate delete.
674 Transition to Deleted state manually.
675 When removing peer from indices that provide visibility of it,
676 take great care to be idempotent wrt the reference counting
677 of struct peer through those indices.
678 Use bgp_timer_set, rather than replicating.
679 Call to bgp_sync_delete isn't appropriate here, sync can be
680 referenced while shutting down and finishing deletion.
681 (peer_group_bind) Take care to be idempotent wrt list references
684 2006-09-13 Paul Jakma <paul.jakma@sun.com>
686 * bgp_aspath.c: (aspath_highest) new, return highest ASN in an
688 * bgp_route.c: (bgp_peer_count_walker) new, do the walk done
689 in bgp_peer_counts as a thread.
690 (bgp_peer_counts) move walk to previous and call it via
691 thread_execute so this RIB walk shows up in thread stats.
692 (bgp_table_stats) New, gather some statistics for a given
694 (bgp_table_stats_walker) New, RIB walker thread for former.
695 (bgp_table_stats_vty) Parsing front-end for 'show bgp ...',
696 useful model for future rationalisation of 'show ... bgp'.
697 (bgp_route_init) Add new RIB stats commands.
699 2006-09-06 Paul Jakma <paul.jakma@sun.com>
701 * (general) Squash any and all prefix-count issues by
702 abstracting route flag changes, and maintaining count as and
703 when flags are modified (rather than relying on explicit
704 modifications of count being sprinkled in just the right
705 places throughout the code).
706 * bgp_route.c: (bgp_pcount_{dec,inc}rement) removed.
707 (bgp_pcount_adjust) new, update prefix count as
708 needed for a given route.
709 (bgp_info_{uns,s}et_flag) set/unset a BGP_INFO route status
710 flag, calling previous function when appropriate.
711 (general) Update all set/unsets of flags to use previous.
712 Remove pcount_{dec,inc}rement calls.
713 No need to unset BGP_INFO_VALID in places where
714 bgp_info_delete is called, it does that anyway.
715 * bgp_{damp,nexthop}.c: Update to use bgp_info_{un,}set_flag.
716 * bgp_route.h: Export bgp_info_{un,}set_flag.
717 Add a 'meta' BGP_INFO flag, BGP_INFO_UNUSEABLE.
718 Move BGP_INFO_HOLDDOWN macro to here from bgpd.h
720 2006-09-03 Paul Jakma <paul.jakma@sun.com>
722 * bgp_route.c: Add 'show ... bgp ... <neighbour> prefix-count'
723 commands, to provide detailed counts of prefixes for a peer.
724 Informative, and should help pin down to pfxcnt drift
727 2006-08-27 Paul Jakma <paul.jakma@sun.com>
729 * bgp_advertise.c: (bgp_sync_delete) fix mtype in XFREE.
730 NULL out peer->hash after free, to be sure.
732 2006-08-06 Paul Jakma <paul.jakma@sun.com>
734 * bgp_aspath.c: (aspath_loop_check) Fix the typo-bug which
735 essentially had disabled this check. Problem reported by
736 Bartek Kania <mrbk@gnarf.org> in [quagga-users 7388].
738 2006-07-27 Paul Jakma <paul.jakma@sun.com>
740 * bgpd.c: (peer_delete) Ensure freed buffers can not be
741 accidently reused. A potential fix for bug #287.
743 2006-07-02 Paul Jakma <paul.jakma@sun.com>
745 * bgp_fsm.c: (bgp_{stop,start}) Move clear/free of certain
746 bits of state from stop to start, as they may be used via
747 peer references on clearing queues..
749 2006-05-23 Paul Jakma <paul.jakma@sun.com>
751 * bgp_vty.c: (neighbor_update_source_cmd) Expand tab completion
752 to make it clear it takes both address and ifname.
754 2006-05-12 Paul Jakma <paul.jakma@sun.com>
756 * bgp_attr.c: (bgp_packet_attribute) Remove dead code, Coverity
758 * bgp_aspath.{c,h}: (aspath_print_vty) take a format string,
759 so as to reduce burden on callers, all in bgp_route.c
760 * bgp_route.c: (bgp_static_update_main) Remove useless NULL
761 check, code already assumes bgp_static can not be NULL,
763 (bgp_static_update_rsclient) ditto, CID #6
764 (route_vty_out{,tmp}) Update to match aspath_print_vty,
765 simplifying checks needed to get spacing right. CID #4,#5.
766 ({damp,flap}_route_vty_out) Ditto, CID #9, #10
768 2006-05-08 Paul Jakma <paul.jakma@sun.com>
770 * bgp_community.c: (community_str2com) Coverity CID#62, fix
771 double-free, use-after-free.
772 * bgp_route.c: (bgp_afi_node_get) given table should never be
773 NULL, check/assert this.
774 (bgp_static_update) Bug #240. Rsclients should only be passed
775 the static update if they are configured for the afi,safi.
777 2006-05-04 Paul Jakma <paul.jakma@sun.com>
779 * (general) VPNv4 fixes. Certain VPNv4 code was not enabled.
781 * bgp_attr.{c,h}: (bgp_packet_{withdraw,attribute}) Tag should be
783 * bgp_packet.c: (bgp_{update,withdraw}_packet) Enable some
784 VPNv4 code which inexplicably was ifdef'd out. comments from
785 a tester on IRC suggest this fixes bug #210.
786 * bgp_route.c: (general) Fix logical bug in clearing, noted
787 by Chris Caputo in [quagga-users 6728] - clearing depended on
788 at least one route being added to workqueue, in order for
789 workqueue completion function to restart FSM. However, if no
790 routes are cleared, then the completion function never is
791 called, it needs to be called manually if the workqueue
792 didn't get scheduled.
793 Finally, clearing is per-peer-session, not per AFI/SAFI, so
794 the FSM synchronisation should be in bgp_clear_route_table.
795 (bgp_clear_route_table) Wrong place for FSM/clearing
796 synchronisation, move to..
797 (bgp_clear_route) FSM/clearing synchronisation should be
799 If no routes were cleared, no workqueue scheduled, call
800 the completion func to ensure FSM kicks off again.
802 2006-03-30 Paul Jakma <paul.jakma@sun.com>
804 * bgp_community.c: (community_gettoken) Unknown token should
805 return NULL, to give a strong indication to callers that
806 the token no longer can be parsed, otherwise callers looping
807 on this function may have a hard time ending their loop.
808 (community_str2com) While loop around community_gettoken appears
809 to have been coded thinking that break statement would break
810 from the while{}, hence it could never exit for unknown token
811 case. Fix it to do..while, so it can use the NULL result from
812 community_gettoken easily.
814 2006-03-22 Paul Jakma <paul.jakma@sun.com>
816 * bgpd.c: (peer_free) release the per-peer workqueue when
819 2006-03-19 Paul Jakma <paul.jakma@sun.com>
821 * bgpd/bgp_vty.c: Add includes to get several structs we want
822 to provide usage statistics on.
823 (show_bgp_memory_cmd) Show memory usage stats for various
824 notable fixed size objects. Using mtype_stats_alloc and
825 mtype_memstr recently added to memory.c.
826 (bgp_show_summary) Report some additional stats specific to
827 the given BGP instance and/or AFI/SAFI such as table counts,
828 peers, rsclients and peer-groups.
829 (bgp_vty_init) Install show_bgp_memory_cmd.
830 * bgp_nexthop.h: Include if.h as a dependent header, for struct
832 * bgp_advertise.c: Use a distinct memory type for struct
835 2006-03-12 Paul Jakma <paul.jakma@sun.com>
837 * bgp_attr.h: (struct attr) rearrange fields to avoid
838 wasted padding between them as much as possible.
839 (attr_count,attr_unknown_count) export new functions to
840 return number of counts of cached attributes.
841 * bgp_attr.c: (attr_count,attr_unknown_count) new functions to
842 return number of counts of cached attributes.
843 * bgp_route.h: (struct bgp_info) rearrange fields to avoid
845 * bgp_table.h: (struct bgp_table) Add a count field, of number
846 of nodes in the table.
847 (struct bgp_node) rearrange fields to avoid
848 wasted padding between them, though I don't think there
849 was any in this case.
850 * bgp_table.c: (bgp_node_{delete,get}) Maintain the table node count.
851 (bgp_table_count) new function to access the table count.
853 2006-03-03 Paul Jakma <paul.jakma@sun.com>
855 * bgp_route.c: (bgp_clear_node_complete) Doh. When clearing
856 is complete we need to kick off FSM again.
858 2006-02-21 Paul Jakma <paul.jakma@sun.com>
860 * bgpd.h: move the clear_node_queue to be peer specific.
861 Add a new peer status flag, PEER_STATUS_CLEARING.
862 * bgp_table.h: (struct bgp_table) Add fields to record afi,
864 (bgp_table_init) Take afi and safi to create table for.
865 * bgp_table.c: (bgp_table_init) record the afi and safi.
866 * bgp_nexthop.c: Update all calls to bgp_table_init.
869 * bgp_fsm.c: (bgp_timer_set) dont bring up a session which is
871 * bgp_route.c: (general) Update all bgp_table_init calls.
872 (bgp_process_{rsclient,main}) clear_node is serialised
873 via PEER_STATUS_CLEARING and fsm now.
874 (struct bgp_clear_node_queue) can be removed. struct bgp_node
875 can be the queue item data directly, as struct peer can be
876 kept in the new wq global user data and afi/safi can be
877 retrieved via bgp_node -> bgp_table.
878 (bgp_clear_route_node) fix to get peer via wq->spec.data,
879 afi/safi via bgp_node->bgp_table.
880 (bgp_clear_node_queue_del) no more item data to delete, only
882 (bgp_clear_node_complete) only need to unset CLEARING flag
883 and unlock struct peer.
884 (bgp_clear_node_queue_init) queue attaches to struct peer
885 now. record peer name as queue name.
886 (bgp_clear_route_table) If queue transitions to active,
887 serialise clearing by setting PEER_STATUS_CLEARING rather
888 than plugging process queue, and lock peer while queue
890 Update to pass only bgp_node as per-queue-item specific data.
891 * bgp_vty.c: (bgp_show_summary) Add a 'Clrng' sub-description
892 to state of peer while it's suppressed due to clearing.
894 2006-02-18 Paul Jakma <paul.jakma@sun.com>
896 * bgp_routemap.c: (route_set_community) Quick, very hacky, fix
897 for the set-community leak, bug #89. True fix will be to
898 detangle the web of *_intern caching and provide saner object
899 caching for Quagga, future work.
900 * bgp_route.c: (bgp_announce_check) trivial, move declaration
901 of two local variables into the only block where they are
902 used, to aid the reader.
904 2006-02-05 Paul Jakma <paul.jakma@sun.com>
906 * bgp_route.h: Add BGP_INFO_COUNTED to track whether
907 prefix has been counted or not.
908 * bgp_route.c: (bgp_pcount_{inc,dec}rement) new helpers, to
909 centralise inc/dec of prefix-count,
910 (bgp_rib_remove) Remove pcount decrement, use helper.
911 (bgp_rib_withdraw) ditto, additionally use previous function
913 (bgp_update_main) Use pcount helpers.
914 (bgp_clear_route_node) ditto, aslo REMOVED routes don't need
916 * bgp_aspath.c: (aspath_gettoken) fix gcc warning about
917 possible uninitialised usage.
919 2006-02-02 Paul Jakma <paul.jakma@sun.com>
921 * bgp_route.c: (bgp_{clear_node,process}_queue_init) delay
922 field is removed from workqueue spec.
924 2006-01-19 Paul Jakma <paul.jakma@sun.com>
926 * (general) various miscellaneous compiler warning fixes.
927 Remove redundant break statements from switch clauses
929 return from main, not exit, cause it annoys SOS.
930 Remove stray semi-colons which cause empty-statement
933 2006-01-17 Paul Jakma <paul.jakma@sun.com>
935 * bgp_nexthop.c: (zlookup_read*) convert to new Zserv format.
936 (zlookup_query_ipv6) ditto.
937 (bgp_import_check) ditto.
939 2006-01-16 Paul Jakma <paul.jakma@sun.com>
941 * bgp_aspath.c: (assegment_append_asns) XREALLOC can return
942 NULL theoretically, take care not to lose the allocated data.
943 (aspath_hash_alloc) aspath_dup already set the aspath
945 (aspath_parse) aspath_hash_alloc dupes the entire aspath,
946 including segments, but we forgot to free the temporary
948 (aspath_snmp_pathseg) move the static stream pointer out to
949 file scope, so it can be freed.
950 (aspath_finish) new function, free aspath resources.
951 * bgp_aspath.h: (aspath_finish) export.
953 2006-01-10 Juris Kalnins <juris@mt.lv>
955 * bgpd.h: (bgp_router_id_unset) ex-function, remove.
957 2005-11-23 Paul Jakma <paul.jakma@sun.com>
959 * bgp_aspath.c: (assegments_parse) should be static
961 2005-11-23 Juergen Kammer <j.kammer@eurodata.de>
963 * bgp_aspath.c: (aspath_cmp_left_confed) fix SEGV for case
964 where one or both paths are empty.
966 2005-11-14 Paul Jakma <paul.jakma@sun.com>
968 * bgp_route.c: (bgp_process_rsclient)Â convert to new workqueue
969 specs and shut up gcc, which complains about cast from void
970 via function parameters, for some dumb reason. Do the cast
971 inside the function instead.
972 (bgp_process_main,bgp_processq_del) ditto.
973 (bgp_clear_route_node) ditto.
974 (bgp_clear_node_queue_del) ditto.
976 2005-11-03 Paul Jakma <paul.jakma@sun.com>
978 * bgp_damp.c: (bgp_reuse_timer) struct bgp can be retrieved via
979 the struct bgp_damp_info, no need to guess by using
982 2005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
984 * bgp_vty.c: (bgp_config_write_redistribute) Use new library function
985 zebra_route_string instead of a local hard-coded table.
987 2005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
989 * bgp_packet.c: fix compilation when DEBUG is used.
991 2005-09-10 Paul Jakma <paul.jakma@sun.com>
993 * Makefile.am: bgpd shouldn't list libgp's sources as its own.
996 (struct assegment) New struct, abstract representation of a
997 list of AS_PATH segments and the contained ASNs.
998 (struct aspath) Remove the raw-data related
999 fields, reference the abstract struct assegment instead.
1000 Remove several other computed fields, it's just a
1001 headache to maintain them and they're cheap to compute from
1003 (aspath_parse) parse a stream, not a pointer to raw data.
1004 (aspath_count_{hops,confeds,size}) helpers to access
1005 information formerly directly contained in struct aspath.
1006 (aspath_snmp_pathseg) Helper for SNMP, BGP MIB wants
1007 to be able to output hex representation of raw data.
1008 * bgp_aspath.c: (general) partial-rewrite. Store aspath data
1009 as an abstract singly-linked list of abstract segments,
1010 rather than storing the raw data, and parsing it each and
1011 every time. Remove several count/size fields which are cheap
1012 to compute from the abstract segment structure.
1013 (global) Include stream.h, needed for aspath_parse, and
1014 others. Couple of helper macros added.
1015 (struct assegment_header) Just the header, and only the
1017 (assegment_data_{new,free}) convenience functions for
1018 AS_SEG_DATA allocation, the dynamic, per-segment array of
1020 (assegment_{new,free,free_all,dup,dup_all}) convenience
1021 functions for creating struct assegments. The _all forms will
1022 follow the entire chain of segments from the given segment.
1023 (assegment_prepend_asns) new function, prepend an ASN N times
1025 (assegment_append_asns) Append a list (array) of ASNs to
1027 (int_cmp) convenience function for the aspath hash.
1028 (assegment_normalise) new function. Normalise the given
1029 segment chain to meet expectations of Quagga, and to
1030 eliminate differing raw representations of the same paths.
1031 Merge 'runs' of SEQUENCEs into one segment as our internal
1032 segment is not limited by the protocol AS_PATH segment
1033 length. Sort ASNs in SETs.
1034 (aspath_new) Take void argument to quell warnings. Use the
1035 assegment convenience functions.
1036 (assegment_count_{asns,confeds,hops}) new functions to
1037 compute at runtime values previously held in struct aspath.
1038 (aspath_size) ditto.
1039 (aspath_make_str_count) rewritten to stringify new
1040 representation, and to be slightly easier to understand
1042 (aspath_str_update) convenience function, update the aspath
1043 str. Should investigate removing maintained string from
1044 struct aspath, just run-time compute it, as per other fields.
1045 It's just a maintenance headache, would save noticeable
1046 amount of RAM with possibly not much extra run-time cost.
1047 (aspath_dup) use the assegment dup functions.
1048 (aspath_hash_alloc) Take void * argument to satisfy gcc. Use
1049 the proper helper functions to dup data.
1050 (assegments_parse) new function. parse raw AS_PATH data into
1051 struct assegments. Normalise and return the head of the list.
1052 (aspath_parse) Parse a stream, not pointer to raw data and
1053 use assegments_parse to do it.
1054 (assegment_data_put) Write out a single segment data in protocol
1056 (assegment_header_put) ditto but for segment header.
1057 (aspath_put) new function. As per previous but for an entire
1059 (aspath_snmp_pathseg) wrapper around aspath_put for
1060 bgp_snmp.c. Uses a static buffer sadly.
1061 (aspath_aggregate_as_set_add) rewritten to use assegments.
1062 (aspath_aggregate) ditto
1063 (aspath_{firstas,loop,private_as}_check) ditto
1064 (aspath_{merge,prepend,add_one_as}) ditto
1065 (aspath_cmp_left{_confed}) ditto
1066 (aspath_delete_confed_seq) ditto, plus fixed to properly
1067 delete all leading confed segments.
1068 (aspath_as_add) Just use assegment_append_asns.
1069 (aspath_segment_add) updated to use assegments.
1070 (enum as_token) Add values for confeds
1071 (aspath_gettoken) Add support for confeds
1072 (aspath_str2aspath) ditto
1073 (aspath_key_make) updated to use as_segments. Also, add
1074 segment type into the hash value as appropriate.
1075 (aspath_cmp) updated to use as_segments.
1076 (aspath_print) don't segfault on NULL argument.
1077 * bgp_attr.c: (bgp_attr_aspath) aspath_parse wants the stream
1078 now. No need for manual forwarding of stream.
1079 (bgp_packet_attribute) empty aspath is now denoted by NULL
1080 segment field, length is gone.
1081 Use aspath_size() to determine size.
1082 (bgp_attr_init) Fix declaration, explicitely specify void
1084 (bgp_dump_routes_attr) Use aspath_size() to determine size.
1085 * bgp_route.c: (bgp_info_cmp) use the aspath_count_* functions.
1086 (bgp_rib_withdraw) remove unused variable. Use
1088 * bgp_snmp.c: (bgp4PathAttrTable) raw data is gone, use
1089 aspath_snmp_pathseg to get the representation.
1091 2005-09-10 Paul Jakma <paul.jakma@sun.com>
1093 * bgp_vty.c: (bgp_vty_init) gcc 4 compile fix. static
1094 function declarations shouldn't be inside functions.
1095 * bgp_dump.c: (bgp_dump_interval_add) ditto.
1097 2005-08-26 Hasso Tepper <hasso at quagga.net>
1099 * bgp_route.c: Third (?) attempt to fix best selection breakage
1100 introduced long time ago with route server patch. Hopefully
1101 it's last case to fix - route-server client not in peer group.
1103 2005-08-22 Hugo Santos <hsantos@av.it.pt>
1105 * bgp_vty.c: (general) Add support for BGP IPv6 Multicast SAFI
1106 commands and BGP_IPV6M_NODE.
1108 2005-08-22 Paul Jakma <paul.jakma@sun.com>
1110 * bgp_route.h: (struct bgp_info) add a new flag, BGP_INFO_REMOVED.
1111 BGP_INFO_VALID is already overloaded, don't care to do same thing
1112 to STALE or HISTORY.
1113 * bgpd.h: (BGP_INFO_HOLDDOWN) Add INFO_REMOVED to the macro, as a
1114 route which should generally be ignored.
1115 * bgp_route.c: (bgp_info_delete) Just set the REMOVE flag, rather
1116 than doing actual work, so that bgp_process (called directly,
1117 or indirectly via the scanner) can catch withdrawn routes.
1118 (bgp_info_reap) Actually remove the route, what bgp_info_delete
1119 used to do, only for use by bgp_process.
1120 (bgp_best_selection) reap any REMOVED routes, other than the old
1122 (bgp_process_rsclient) reap the old-selected route, if appropriate
1123 (bgp_process_main) ditto
1124 (bgp_rib_withdraw, bgp_rib_remove) make them more consistent with
1125 each other. Don't play games with the VALID flag, bgp_process
1126 is async now, so it didn't make a difference anyway.
1127 Remove the 'force' argument from bgp_rib_withdraw, withdraw+force
1128 is equivalent to bgp_rib_remove. Update all its callers.
1129 (bgp_update_rsclient) bgp_rib_withdraw and force set is same as
1131 (route_vty_short_status_out) new helper to print the leading
1132 route-status string used in many command outputs. Consolidate.
1133 (route_vty_out, route_vty_out_tag, damp_route_vty_out,
1134 flap_route_vty_out) use route_vty_short_status_out rather than
1136 (route_vty_out_detail) print state of REMOVED flag.
1137 (BGP_SHOW_SCODE_HEADER) update for Removed flag.
1139 2005-08-03 Hasso Tepper <hasso at quagga.net>
1141 * bgp_routemap.c: Revert part of leaking communities fix commited in
1142 2005-05-27. While ecommunity fix seems to be correct, community case
1145 2005-06-28 Paul Jakma <paul.jakma@sun.com>
1147 * (global) The great bgpd extern and static'ification.
1148 * bgp_routemap.c: remove unused ROUTE_MATCH_ASPATH_OLD code
1149 (route_set_metric_compile) fix u_int32_t to ULONG_MAX comparison
1151 * bgp_route.h: (bgp_process, bgp_withdraw, bgp_update) export these
1152 used by various files which had their own private declarations,
1153 in the case of mplsvpn - incorrect.
1155 2005-06-15 Paul Jakma <paul.jakma@sun.com>
1157 * bgpd.c: (bgp_terminate) workqueue's are lazy allocated and its
1158 possible to terminate bgpd before workqueues were setup, causing
1159 an abort/crash. Reported by Ashish Mehta of Sun.
1161 2005-06-01 Paul Jakma <paul.jakma@sun.com>
1163 * (general) refcount struct peer and bgp_info, hence allowing us
1164 add work_queues for bgp_process.
1165 * bgp_route.h: (struct bgp_info) Add 'lock' field for refcount.
1166 Add bgp_info_{lock,unlock} helper functions.
1167 Add bgp_info_{add,delete} helpers, to remove need for
1168 users managing locking/freeing of bgp_info and bgp_node's.
1169 * bgp_table.h: (struct bgp_node) Add a flags field, and
1170 BGP_NODE_PROCESS_SCHEDULED to merge redundant processing of
1172 * bgp_fsm.h: Make the ON/OFF/ADD/REMOVE macros lock and unlock
1173 peer reference as appropriate.
1174 * bgp_damp.c: Remove its internal prototypes for
1175 bgp_info_delete/free. Just use bgp_info_delete.
1176 * bgpd.h: (struct bgp_master) Add work_queue pointers.
1177 (struct peer) Add reference count 'lock'
1178 (peer_lock,peer_unlock) New helpers to take/release reference
1180 * bgp_advertise.c: (general) Add peer and bgp_info refcounting
1181 and balance how references are taken and released.
1182 (bgp_advertise_free) release bgp_info reference, if appropriate
1183 (bgp_adj_out_free) unlock peer
1184 (bgp_advertise_clean) leave the adv references alone, or else
1185 call bgp_advertise_free cant unlock them.
1186 (bgp_adj_out_set) lock the peer on new adj's, leave the reference
1187 alone otherwise. lock the new bgp_info reference.
1188 (bgp_adj_in_set) lock the peer reference
1189 (bgp_adj_in_remove) and unlock it here
1190 (bgp_sync_delete) make hash_free on peer conditional, just in
1192 * bgp_fsm.c: (general) document that the timers depend on
1193 bgp_event to release a peer reference.
1194 (bgp_fsm_change_status) moved up the file, unchanged.
1195 (bgp_stop) Decrement peer lock as many times as cancel_event
1196 canceled - shouldnt be needed but just in case.
1197 stream_fifo_clean of obuf made conditional, just in case.
1198 (bgp_event) always unlock the peer, regardless of return value
1199 of bgp_fsm_change_status.
1200 * bgp_packet.c: (general) change several bgp_stop's to BGP_EVENT's.
1201 (bgp_read) Add a mysterious extra peer_unlock for ACCEPT_PEERs
1202 along with a comment on it.
1203 * bgp_route.c: (general) Add refcounting of bgp_info, cleanup
1204 some of the resource management around bgp_info. Refcount peer.
1205 Add workqueues for bgp_process and clear_table.
1206 (bgp_info_new) make static
1207 (bgp_info_free) Ditto, and unlock the peer reference.
1208 (bgp_info_lock,bgp_info_unlock) new exported functions
1209 (bgp_info_add) Add a bgp_info to a bgp_node in correct fashion,
1210 taking care of reference counts.
1211 (bgp_info_delete) do the opposite of bgp_info_add.
1212 (bgp_process_rsclient) Converted into a work_queue work function.
1213 (bgp_process_main) ditto.
1214 (bgp_processq_del) process work queue item deconstructor
1215 (bgp_process_queue_init) process work queue init
1216 (bgp_process) call init function if required, set up queue item
1217 and add to queue, rather than calling process functions directly.
1218 (bgp_rib_remove) let bgp_info_delete manage bgp_info refcounts
1219 (bgp_rib_withdraw) ditto
1220 (bgp_update_rsclient) let bgp_info_add manage refcounts
1221 (bgp_update_main) ditto
1222 (bgp_clear_route_node) clear_node_queue work function, does
1223 per-node aspects of what bgp_clear_route_table did previously
1224 (bgp_clear_node_queue_del) clear_node_queue item delete function
1225 (bgp_clear_node_complete) clear_node_queue completion function,
1226 it unplugs the process queues, which have to be blocked while
1227 clear_node_queue is being processed to prevent a race.
1228 (bgp_clear_node_queue_init) init function for clear_node_queue
1230 (bgp_clear_route_table) Sets up items onto a workqueue now, rather
1231 than clearing each node directly. Plugs both process queues to
1232 avoid potential race.
1233 (bgp_static_withdraw_rsclient) let bgp_info_{add,delete} manage
1235 (bgp_static_update_rsclient) ditto
1236 (bgp_static_update_main) ditto
1237 (bgp_static_update_vpnv4) ditto, remove unneeded cast.
1238 (bgp_static_withdraw) see bgp_static_withdraw_rsclient
1239 (bgp_static_withdraw_vpnv4) ditto
1240 (bgp_aggregate_{route,add,delete}) ditto
1241 (bgp_redistribute_{add,delete,withdraw}) ditto
1242 * bgp_vty.c: (peer_rsclient_set_vty) lock rsclient list peer
1244 (peer_rsclient_unset_vty) ditto, but unlock same reference
1245 * bgpd.c: (peer_free) handle frees of info to be kept for lifetime
1247 (peer_lock,peer_unlock) peer refcount helpers
1248 (peer_new) add initial refcounts
1249 (peer_create,peer_create_accept) lock peer as appropriate
1250 (peer_delete) unlock as appropriate, move out some free's to
1252 (peer_group_bind,peer_group_unbind) peer refcounting as
1254 (bgp_create) check CALLOC return value.
1255 (bgp_terminate) free workqueues too.
1257 2005-05-28 Hasso Tepper <hasso at quagga.net>
1259 * bgp_routemap.c: Sync set_metric_addsub_cmd with ripd.
1261 2005-05-27 Hasso Tepper <hasso at quagga.net>
1263 * bgp_routemap.c: Stop leaking communities.
1265 2005-05-27 Hasso Tepper <hasso at quagga.net>
1267 * bgpd.c: Deleting bgp->rsclient list needs fix similar to pree-groups
1268 deleting fix. Avoid leaking bgp->group, bgp->peer and bgp->rsclient
1271 2005-05-26 Hasso Tepper <hasso at quagga.net>
1273 * bgpd.c: Don't crash while deleting list of peer-groups.
1275 2005-05-25 Hasso Tepper <hasso at quagga.net>
1277 * bgpd.c: Fix obvious (routeserver patch) merge error. This makes "no
1278 neighbor x.x.x.x routemap [export|import] commands work again.
1280 2005-05-23 Paul Jakma <paul@dishone.st>
1282 * bgp_routemap.c: add semi-colons to VTY_GET_* to match vty.h change
1283 * bgp_fsm.h: Add extern qualifier to exported functions
1284 * bgp_nexthop.c: add static to nexthop specific globals
1285 * *.h: Add guard defines
1287 2005-05-19 Paul Jakma <paul@dishone.st>
1289 * bgp_fsm.c: (bgp_stop) use sockunion_free, not XFREE..
1290 * bgp_network.c: (bgp_getsockname) ditto
1291 (bgp_accept) use XSTRDUP
1292 * bgp_routemap.c: (route_match_peer) ditto, als use a ret value and
1293 remove one sockunion_free.
1294 * bgpd.c: (peer_delete) ditto.
1295 XFREE the correct memtype, not free.
1296 (peer_create) use XSTRDUP
1297 * bgp_packet.c: (bgp_stream_dup) deleted, stream_dup should be used
1298 (various) update -> s/bgp_stream_dup/stream_dup
1301 2005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1303 * bgp_zebra.c (bgp_redistribute_set, bgp_redistribute_unset):
1304 The 2nd arg to zebra_redistribute_send is now zclient instead of
1307 2005-04-09 Akihiro Mizutani <mizutani@net-chef.net>
1309 * bgp_vty.c: Make "exit-address-family" work in IPv4 unicast address
1312 2005-04-08 Martin Ling <martin-quagga@earth.li>
1314 * bgp_aspath.[ch], bgp_route.c, bgp_vty.c, bgpd.[ch]: Allow to enable
1315 the length of confederation path segments to be included during the
1316 as-path length check in the best path decision.
1318 2005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1320 * bgp_zebra.c: (bgp_interface_delete) After deleting, set ifp->ifindex
1321 to IFINDEX_INTERNAL.
1323 2005-03-21 Hasso Tepper <hasso at quagga.net>
1325 * bgp_route.c: Don't crash while clearing route tables if there is
1326 no particular afi/safi configured.
1328 2005-02-23 Hasso Tepper <hasso at quagga.net>
1330 * bgp_route.c: Make reannouncing prefixes with changed attributes
1333 2005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1335 * bgp_vty.c: Deprecate "neighbor transparent-as" and "neighbor
1336 transparent-nexthop" commands.
1338 2005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1340 * bgp_routemap.c: New route-map command - "match ip route-source".
1342 2005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1344 * bgp_clist.[ch], bgp_route.c, bgp_routemap.c, bgp_vty.c:
1345 community-list cleanup.
1347 2005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1349 * bgp_route.c, bgp_vty.c, bgp_zebra.c, bgpd.[ch]: "enforce-multihop"
1350 -> "disable-connected-check".
1352 2005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1354 * bgp_fsm.c, bgp_open.c, bgp_packet.c, bgp_route.[ch], bgp_vty.c,
1355 bgpd.[ch]: Add BGP_INFO_STALE flag and end-of-rib support. "bgp
1356 graceful-restart" commands added. Show numbers of individual
1357 messages in "show ip bgp neighbor" command. Final pieces of graceful
1360 2005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1362 * bgp_open.c, bgp_packet.c, bgp_vty.c, bgpd.[ch]: Remove "no neighbor
1363 capability route-refresh" commands. Route refresh capability is sent
1364 anyway now. Preserve dummy deprecated commands.
1366 2005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1368 * bgp_attr.c, bgp_snmp.c, bgp_vty.c, bgpd.[ch]: Remove support for old
1369 draft - ie. "neighbor version 4-" commands. Preserve dummy "neighbor
1370 version" command as deprecated.
1372 2005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1374 * bgpd.[ch], bgp_vty.c, bgp_route.c: "Restart session after
1375 maximum-prefix limit" feature support.
1377 2005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1379 * bgp_nexthop.c: Improve debug.
1380 * bgpd.[ch], bgp_nexthop.c, bgp_snmp.c: Remove useless bgp_get_master()
1382 * bgp_packet.c: MP AFI_IP update and withdraw parsing.
1383 * bgp_fsm.c: Reset peer synctime in bgp_stop(). bgp_fsm_change_status()
1384 is better place to log about peer status change than bgp_event().
1385 Log in bgp_connect_success().
1386 * bgp_vty.c: Fix typo in comment.
1387 * bgp_attr.c: Better log about unknown attribute.
1389 2005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1391 * bgp_filter.c: (ip_as_path,no_ip_as_path) Use argv_concat instead
1393 * bgp_route.c: (bgp_show_regexp) Fix memory leak: need to free string
1394 returned by buffer_getstr.
1395 (bgp_show_community) Must use XFREE instead of free on string
1396 returned by buffer_getstr.
1397 * bgp_routemap.c: (set_community) Must use XFREE instead of free
1398 on string returned by buffer_getstr.
1399 * bgp_vty.c: (neighbor_description) Use argv_concat instead of
1402 2005-01-24 Hasso Tepper <hasso at quagga.net>
1404 * bgp_route.c: Fix showstopper bug. New route must be selected also
1405 if old one is flaged as BGP_INFO_ATTR_CHANGED.
1407 2005-01-17 Hasso Tepper <hasso at quagga.net>
1409 * bgp_route.c: Clear peer's routing table regardless whether it's
1410 configured or not. Being not configured is even better reason to
1413 2005-01-05 Paul Jakma <paul@dishone.st>
1415 * bgp_packet.c: (bgp_write) set socket to nonblock while writing
1416 this should be generalised. See bugzilla #102. Fix supplied by
1417 wawa@yandex-team.ru (Vladimir Ivanov).
1419 2004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1421 * *.c: Change level of debug messages to LOG_DEBUG.
1423 2004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1425 * bgp_main.c: (main) The 2nd argument to openzlog has been removed.
1427 2004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1429 * bgp_main.c: (sigint) Use zlog_notice for termination message.
1430 (main) Use zlog_notice for startup announcement.
1432 2004-11-25 Hasso Tepper <hasso at quagga.net>
1434 * bgp_main.c: Make group to run as configurable.
1436 2004-11-09 Paul Jakma <paul@dishone.st>
1438 * bgp_nexthop.c: collapse bgp_connected_ipvX, bgp_nexthop_cache_ipvX
1439 and cache{1,2}.. into arrays of tables and hence collapse
1440 bgp_scan_ipv{4,6} into a single bgp_scan function. Tested, though
1441 a long time ago (and this change was hand-merged).
1443 2004-11-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1445 * bgp_route.c: Remove all code related to VTY_CONTINUE; this feature
1446 is deprecated because the output did not represent a single point
1447 in time. All output needs to be generated inline and buffered
1448 by the library code.
1449 (route_vty_out,route_vty_out_tag,damp_route_vty_out,
1450 flap_route_vty_out) Remove code to count number of lines of output,
1451 since this was only useful for VTY_CONTINUE behavior.
1452 (bgp_show_callback,vty_calc_line) Removed.
1453 (bgp_show_table) Remove hooks for VTY_CONTINUE callback support.
1454 As a result, there's a new output_arg argument to this function.
1455 Make function static.
1456 (bgp_show) Make function static and add a new output_arg argument.
1457 Change all functions that call bgp_show or bgp_show_table to
1458 pass the new output_arg argument (that used to be passed inside
1460 * bgp_mplsvpn.c: Remove declarations of functions defined in
1461 bgp_route.c; these declarations belong in bgp_route.h.
1462 * bgp_route.h: Declare 3 global functions used in both bgp_route.c
1463 and in bgp_mplsvpn.c.
1465 2004-10-31 Paul Jakma <paul@dishone.st>
1467 * {bgpd,bgp_attr}.c: size_t printf format should be ld.
1469 2004-10-25 Paul Jakma <paul@dishone.st>
1471 * Update with fix in debian bug id 222930.
1472 * bgp_main.c: Add ZCAP_RAW, needed to bind to interfaces.
1473 bgp_network.c: (....) raise/lower privs around call to
1474 SO_BINDTODEVICE sockopt.
1476 2004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1478 * bgp_nexthop.c: (bgp_connected_add) Connected destination pointer
1480 (bgp_connected_delete) ditto.
1482 2004-10-14 Hasso Tepper <hasso at quagga.net>
1484 * bgp_dump.c: Make dump configuration appear in vtysh.
1486 2004-10-13 Hasso Tepper <hasso at quagga.net>
1488 * bgp_snmp.c: Remove defaults used to initialize smux connection to
1489 snmpd. Connection is initialized only if smux peer is configured.
1490 * bgp_view.c: It's dead file. Reomved.
1492 2004-10-13 Paul Jakma <paul@dishone.st>
1494 * (global) more const'ification and fixups of types to clean up code.
1495 * bgp_mplsvpn.{c,h}: (str2tag) fix abuse. Still not perfect,
1496 should use something like the VTY_GET_INTEGER macro, but without
1498 * bgp_routemap.c: (set_aggregator_as) use VTY_GET_INTEGER_RANGE
1499 (no_set_aggregator_as) ditto.
1500 * bgpd.c: (peer_uptime) fix unlikely bug, where no buffer is
1501 returned, add comments about troublesome return value.
1503 2004-10-03 James R. Leu <jleu at mindspring.com>
1505 * bgp_vty.c: Router id from zebra can be manually overriden.
1506 * bgp_zebra.c: Read router id related messages from zebra daemon.
1507 Remove own code related with router id selection.
1508 * bgpd.c, bgpd.h: Remove own router id selection code. Use the one
1509 from zebra daemon if it isn't manually overriden.
1511 2004-09-26 Hasso Tepper <hasso at quagga.net>
1513 * bgp_aspath.c, bgp_packet.c, bgp_vty.c: Fix compiler warnings.
1515 2004-09-23 Hasso Tepper <hasso at quagga.net>
1517 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1519 2004-07-09 Paul Jakma <paul@dishone.st>
1521 * Merge of GNU Zebra cvs2svn changesets r799, r800 and r807.
1522 * bgp_dump.c: (bgp_dump_attr) cleanup. return status code. check
1523 attributes present before printing.
1524 * bgp_dump.c: update bgp_dump_attr prototype.
1525 * bgp_packet.c: (bgp_update_receive) init attrstr. check status
1526 of bgp_dump_attr. Log end-of-rib UPDATEs.
1528 2004-07-09 Sowmini Varadhan <sowmini.varadhan@sun.com>
1530 * bgp_packet.c: (bgp_collision_detect) Send NOTIFY on new socket
1531 if that is connection we're closing.
1532 (bgp_read) invalid marker check applies to KEEPALIVE too.
1533 * bgp_route.c: Ignore multicast NRLI, dont send NOTIFY.
1535 2004-06-04 Paul Jakma <paul@dishone.st>
1537 * type mismatch fixes
1539 2004-05-21 Akihiro Mizutani <mizutani@net-chef.net>
1541 * bgpd.h, bgp_open.[ch], bgp_debug.c, bgp_vty.[ch], bgp_fsm.c:
1542 Graceful restart capability display.
1544 2005-05-20 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1546 * bgp_debug.c: Cosmetical fixes and log neighbor changes.
1548 2004-05-20 Akihiro Mizutani <mizutani@net-chef.net>
1550 * bgp_ecommunity.c: Transit ecommunity support.
1551 * bgp_ecommunity.c: Fix for unknown community crush.
1553 2005-05-20 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1555 * *: Maximum prefix threshold support.
1556 * *: Reset notification fixups.
1558 2004-05-08 Paul Jakma <paul@dishone.st>
1560 * bgp_zebra.c: (bgp_interface_address_add) sync to zclient changes
1561 (bgp_interface_address_delete) ditto.
1562 (bgp_zebra_announce) ditto.
1563 (bgp_zebra_withdraw) ditto.
1565 2004-05-03 Daniel Roesen <dr@cluenet.de>
1567 * bgp_fsm.c: (bgp_stop) Reset uptime only on transition from
1568 Established so that it reflects true downtime (rather time
1569 since last transition, eg Active->Idle)
1571 2004-05-01 rivo nurges <rix@estpak.ee>
1573 * bgp_route.c: fix UNH IOL BGP-4.1.12f
1575 2004-05-01 Paul Jakma <paul@dishone.st>
1577 * Revert the attempted clean-up of the dummy peer hack, reverts
1578 patchsets 435 (see 2004-02-17 below) and 456.
1580 2004-04-16 rivo nurges <rix@estpak.ee>
1582 * bgpd.h, bgp_debug.c: update cease subcodes to
1583 draft-ietf-idr-cease-subcode-05
1584 * bgpd.h, bgpd.c, bgp_route.c, bgp_route.h: fix UNH IOL BGP-4.1.6a
1586 2004-02-17 Paul Jakma <paul@dishone.st>
1588 * bgpd.h: (bgp_peer) add fd_local and fd_accept
1589 file descriptor's, fd becomes a pointer to one of these.
1590 * bgpd.c: (global) adjust for fact that fd is now a pointer.
1591 (peer_create_accept) removed.
1592 * bgp_route.c: (global) adjust for change of peer fd to pointer
1593 * bgp_packet.c: (bgp_collision_detect) adjust and remove the
1594 "replace with other peer" hack.
1595 * bgp_network.c: (bgp_accept) Remove the dummy peer hack.
1596 Update peer->fd_accept instead.
1597 (global) Adjust fd references - now a pointer.
1598 * bgp_fsm.c: (global) adjust peer fd to pointer.
1599 (bgp_connection_stop) new function, to stop connection.
1600 (global) adjust everything which closed peer fd to use
1601 bgp_connection_stop().
1603 2003-12-23 Krzysztof Oledzki <oleq@ans.pl>
1605 * bgp_network.c: drop privs on error cases
1607 2003-08-11 kunihiro <kunihiro@zebra.org>
1609 * bgp_route{,map}.c: Extend 'set ip next-hop' in route-maps with
1610 ability to specify 'peer-address' rather than IP.
1612 2003-06-09 Paul Jakma <paul@dishone.st>
1614 * bgp_clist.c (community_list_delete): honour deny statements
1616 2003-04-19 Hasso Tepper <hasso@estpak.ee>
1618 * rip_routemap.c: sync daemon's route-map commands to have same
1621 2003-01-09 Akihiro Mizutani <mizutani@net-chef.net>
1623 * bgp_routemap.c: Add match extcommunity command.
1625 2002-10-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1627 * bgp_aspath.c (aspath_init): Extend hash size from default to
1629 (aspath_key_make): Use unsigned shoft for making hash. Suggested
1630 by: Marc Evans <Marc@SoftwareHackery.Com>
1632 2002-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1634 * bgp_clist.c (community_entry_free): Fix memory leak of standard
1635 extcommunity-list config string.
1637 2002-08-19 Akihiro Mizutani <mizutani@net-chef.net>
1639 * bgp_route.c (route_vty_out_detail): Fix bug of router-id display
1640 when multiple instance is used.
1642 2002-08-18 Akihiro Mizutani <mizutani@net-chef.net>
1644 * bgpd.c: Make "default-originate" and "maximum-prefix" commands
1645 available in peer-group configuration.
1647 2002-08-13 Akihiro Mizutani <mizutani@net-chef.net>
1649 * bgp_packet.c (bgp_open_send): Put Opt Parm Len 0 when last
1650 capability packet cause error or dont-capability-negotiate option
1653 2002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1655 * zebra-0.93 released.
1657 2001-10-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1659 * bgpd.c (bgp_vty_init): Translate update commands are removed.
1661 2001-10-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1663 * bgp_route.c (bgp_static_set): Add workaround for BGP static
1664 route announcement when there is no zebra running.
1666 2001-10-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1668 * bgpd.c (neighbor_remote_as_unicast): Remove "remote-as nlri
1669 unicast multicast" commands.
1671 2001-09-14 Akihiro Mizutani <mizutani@dml.com>
1673 * bgp_open.c: When we receive capability route-refresh, we should
1674 check we send the capability not we receive the capability.
1676 * bgp_route.c (bgp_network_mask_natural_route_map): network
1677 statement route-map is added.
1679 2001-08-31 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1681 * bgp_advertise.c (bgp_advertise_intern): attr must be interned
1682 before looking up hash table.
1684 2001-08-30 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1686 * bgpd.h (struct peer): BGP filter is moved from peer_conf to
1689 2001-08-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1691 * bgp_nexthop.c (bnc_nexthop_free): Fix next pointer bug.
1692 Suggested by: "Hong-Sung Kim" <hoskim@lanbird.co.kr>.
1694 2001-08-26 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1696 * bgp_table.c (bgp_node_create): Clearn memory before use it.
1698 2001-08-24 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1700 * Change to use bgp_table.[ch].
1702 2001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1704 * bgpd.c (bgp_init): Add "transparent-as" and
1705 "transparent-nexthop" for old version compatibility.
1707 2001-08-23 Akihiro Mizutani <mizutani@dml.com>
1709 * bgpd.h (struct peer): default-originate route-map is added.
1711 * bgp_route.c: When self originated route is advertised with
1712 attrubute-unchanged, nexthop was not properly set. This bug is
1715 2001-08-22 Akihiro Mizutani <mizutani@dml.com>
1717 * bgpd.c (neighbor_attr_unchanged): transparent-as and
1718 transparent-next-hop commands are restructured. Instead of
1719 current transparent-* commands, attribute-unchanged command is
1722 neighbor A.B.C.D attribute-unchanged [as-path|next-hop|med]
1724 (neighbor_default_originate): "default-originate" configuration
1725 announce default route even 0.0.0.0/0 does not exists in BGP RIB.
1727 2001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1729 * zebra-0.92a released.
1731 2001-08-19 Akihiro Mizutani <mizutani@dml.com>
1733 * bgpd.c: AF specific soft-reconfiguration inbound commands are
1736 2001-08-17 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1738 * bgp_route.c (bgp_show_callback): Do not do community NULL check.
1740 * bgp_community.c (community_cmp): Add check for commnunity NULL
1743 * bgp_routemap.c (route_match_community): Do not check comunity is
1744 NULL. It may match to community-list "^$".
1746 * bgp_community.c (community_match): Add check for community is
1749 2001-08-17 Akihiro Mizutani <mizutani@dml.com>
1751 * bgpd.c: AF specific route-reflector-client and
1752 route-server-client configuration are added.
1754 2001-08-17 Rick Payne <rickp@ayrnetworks.com>
1756 * bgp_clist.c (community_match_regexp): Check special ^$ case.
1758 2001-08-17 Akihiro Mizutani <mizutani@dml.com>
1760 * bgp_clist.c (community_list_match): Fix bug of community list
1761 permit and deny check.
1763 2001-08-16 Akihiro Mizutani <mizutani@dml.com>
1765 * bgp_mplsvpn.c (bgp_mplsvpn_init): Add AF specific "nexthop-self"
1768 2001-08-15 Akihiro Mizutani <mizutani@dml.com>
1770 * bgpd.h (PEER_FLAG_SEND_COMMUNITY): Per AF based configuration
1773 * bgp_mplsvpn.c (bgp_mplsvpn_init): VPNv4 filtering is added.
1775 2001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1777 * zebra-0.92 released.
1779 2001-08-13 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1781 * bgpd.c (bgp_delete): "no router bgp" free static, aggregate, rib
1784 2001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1786 * bgp_route.c (bgp_node_safi): Return SAFI of current node.
1787 (bgp_config_write_network_vpnv4): VPNv4 static configuration
1790 2001-08-11 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1792 * bgpd.c (no_bgp_ipv4_multicast_route_map): Add IPv4 multicast
1793 node filter commands.
1795 2001-08-11 Kunihiro Ishiguro <kunihiro@zebra.org>
1797 * bgpd.h (PEER_FLAG_IGNORE_LINK_LOCAL_NEXTHOP): Add
1798 "ignore-link-local-nexthop" flag for ignore link-local nexthop for
1801 2001-08-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1803 * bgpd.c (address_family_ipv4_multicast): "address-family ipv4
1804 multicast" is added.
1805 (address_family_ipv6_unicast): "address-family ipv6 unicast" is
1808 2001-08-07 Akihiro Mizutani <mizutani@dml.com>
1810 * bgp_route.c (bgp_process): Use flag instead of as_selected
1811 memeber in struct bgp_info.
1813 * bgp_route.h (struct bgp_info): Remove as_selected memeber from
1816 2001-07-31 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1818 * bgp_route.c (bgp_announce_check): Enclose sending time AS loop
1819 check code with #ifdef BGP_SEND_ASPATH_CHECK.
1821 2001-07-29 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1823 * bgp_packet.c (bgp_withdraw_send): Simplify address family check.
1825 * bgpd.h (BGP_INFO_HOLDDOWN): Introduce new macro to check BGP
1826 information is alive or not.
1828 * bgp_community.c: Use community_val_get() on all OS.
1830 2001-07-24 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1832 * bgp_route.c (bgp_announce_check): Simplify set next-hop self
1835 2001-07-24 Akihiro Mizutani <mizutani@dml.com>
1837 * bgp_route.c (bgp_announce_check): To route server clients, we
1838 announce AS path, MED and nexthop transparently.
1840 2001-06-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1842 * bgp_routemap.c (route_set_atomic_aggregate_free): Do not call
1843 XFREE. No memory is allocated in
1844 route_set_atomic_aggregate_compile().
1846 2001-06-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1848 * bgp_routemap.c (bgp_route_map_init): `match nlri` and `set nlri`
1849 are replaced by `address-family ipv4` and `address-family vpnvr'.
1851 2001-06-19 Kunihiro Ishiguro <kunihiro@zebra.org>
1853 * bgp_route.c (bgp_withdraw): Add check for BGP_PEER_CONFED.
1854 Reported by Rick Payne <rickp@rossfell.co.uk>.
1856 2001-06-17 Kunihiro Ishiguro <kunihiro@zebra.org>
1858 * bgp_zebra.c (bgp_zebra_announce): When global IPv6 nexthop is
1859 empty, use socket's remote address for the nexthop.
1861 2001-06-04 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1863 * bgpd.c (peer_delete): Fix memory leak. Reported by Yosi Yarchi
1864 <Yosi_Yarchi@KereniX.com>
1866 2001-06-01 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1868 * bgpd.c (bgp_delete): Fix memory leak. Reported by Yosi Yarchi
1869 <Yosi_Yarchi@KereniX.com>
1871 2001-05-27 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1873 * bgp_route.c (bgp_route_clear_with_afi_vpnv4): Use next instead
1876 * bgp_packet.c (bgp_withdraw_send): MPLS/VPN withdraw takes effect
1877 when HAVE_IPV6 is not defined.
1879 2001-03-07 "Akihiro Mizutani" <mizutani@dml.com>
1881 * bgpd.c (peer_timers_set): Adjust keepalive timer to fit less
1883 (bgp_confederation_peers_unset): Only set peer->local_as when
1884 confederation is enabled.
1885 (bgp_timers): Add "timers bgp <0-65535> <0-65535>" command.
1887 * bgp_route.c (bgp_announce_check): Set med of redistributed route
1888 when it is announced to EBGP peer.
1890 2001-03-06 "Akihiro Mizutani" <mizutani@dml.com>
1892 * bgp_nexthop.c (bgp_scan_ipv4): bgp_scan() call bgp_process() for
1895 2001-03-06 Kunihiro Ishiguro <kunihiro@zebra.org>
1897 * bgp_attr.c (bgp_attr_origin): When bgpd send NOTIFICATION with
1898 erroneous attribute (type, length and value), it does include
1899 attribute flags field.
1901 2001-02-21 "Akihiro Mizutani" <mizutani@dml.com>
1903 * bgp_route.c (bgp_announce_check): The route reflector is not
1904 allowed to modify the attributes of the reflected IBGP routes.
1906 2001-02-20 "Akihiro Mizutani" <mizutani@dml.com>
1908 * bgp_route.c (bgp_info_cmp): During path seleciton, BGP
1909 confederation peer is treated as same as IBGP peer.
1911 2001-02-19 Kunihiro Ishiguro <kunihiro@zebra.org>
1913 * bgp_route.c (bgp_redistribute_add): Initialize attr_new with
1914 attr. Call aspath_unintern when return from this function.
1916 2001-02-19 "Akihiro Mizutani" <mizutani@dml.com>
1918 * bgpd.c (bgp_router_id_set): Reset BGP peer when router-id is
1921 2001-02-18 "Akihiro Mizutani" <mizutani@dml.com>
1923 * bgp_packet.c (bgp_open_receive): When user configure holdtimer,
1924 do not refrect the value to current session.
1926 2001-02-16 Kunihiro Ishiguro <kunihiro@zebra.org>
1928 * bgp_route.c (bgp_aggregate_delete): Set BGP_INFO_ATTR_CHANGE to
1929 suppress route withdraw.
1931 * bgp_damp.c (bgp_damp_init): Fix bug of flap dampening.
1933 2001-02-16 "Akihiro Mizutani" <mizutani@dml.com>
1935 * bgp_aspath.c (aspath_make_str_count): Use ',' for separator for
1936 AS_SET and AS_CONFED_SET.
1938 2001-02-15 Kunihiro Ishiguro <kunihiro@zebra.org>
1940 * bgp_route.c (bgp_process): Do not consider suppress route.
1942 * bgp_aspath.c (aspath_aggregate_as_set_add): Reset asset when
1943 aspath->data is realloced.
1945 2001-02-15 "Akihiro Mizutani" <mizutani@dml.com>
1947 * bgp_attr.c (bgp_attr_aggregate_intern): Do not set atomic
1948 aggregate when using as-set.
1950 2001-02-14 "Akihiro Mizutani" <mizutani@dml.com>
1952 * bgpd.c (bgp_confederation_peers_unset): Set peer's local-as
1955 * bgp_route.c (bgp_update): Just ignore AS path loop for
1958 2001-02-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1960 * bgp_route.c (bgp_aggregate_set): Add as_set argument.
1961 (bgp_aggregate_unset): Remove summary_only argument.
1962 (aggregate_address_as_set): New commands.
1963 "aggregate-address A.B.C.D/M as-set"
1964 "no aggregate-address A.B.C.D/M as-set"
1966 2001-02-08 "Akihiro Mizutani" <mizutani@dml.com>
1968 * bgp_route.c (bgp_announce_check): Do not modify nexthop when the
1969 route is passed by route reflector.
1971 2001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1973 * bgp_route.c: "no bgp dampening" with argument.
1974 (bgp_announce_check): Do not modify nexthop when the route is
1975 passed by route reflector.
1977 2001-02-07 "Akihiro Mizutani" <mizutani@dml.com>
1979 * bgpd.c (neighbor_passive): Change "neighbor NEIGHBOR remote-as
1980 ASN passive" to "neighbor NEIGHBOR passive".
1981 (bgp_announce_check): Check well-known community attribute even
1982 when "no neighbor send-community" is set.
1984 2001-02-03 Kunihiro Ishiguro <kunihiro@zebra.org>
1986 * bgp_fsm.c (bgp_establish): Do not send keepalive at established
1987 time when keepalive timer is configured as zero.
1989 2001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
1991 * bgp_attr.c (bgp_attr_check): When peer is IBGP peer, local
1992 preference is well-known attribute.
1994 2001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1996 * zebra-0.91 is released.
1998 * bgp_attr.h (struct attr): Comment out DPA value.
1999 (struct attr): Change refcnt type from int to unsinged long.
2001 * bgp_attr.c (attrhash_key_make): Likewise.
2002 (attrhash_cmp): Likewise.
2003 (bgp_attr_dpa): Likewise.
2005 2001-01-30 "Akihiro Mizutani" <mizutani@dml.com>
2007 * bgp_route.c (bgp_info_cmp): Make route selection completely same
2010 2001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
2012 * bgp_attr.h (BGP_ATTR_FLAG_OPTIONAL): Rename old ATTR_FLAG_* to
2013 BGP_ATTR_FLAG_* to clarify meenings.
2015 2001-01-30 "Akihiro Mizutani" <mizutani@dml.com>
2017 * bgp_route.c (route_vty_out): Display argument to suppress same
2018 prefix information display.
2019 (route_vty_out_route): Don't display mask information for
2022 2001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
2024 * bgp_attr.h (SET_BITMAP): Simple bitmapping macros.
2026 * bgp_attr.c (bgp_attr_parse): Use bitmap for attribute type
2029 2001-01-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2031 * bgp_attr.c (bgp_mp_reach_parse): Enclose loggin with BGP_DEBUG.
2032 (bgp_attr_parse): Comment out well-known attribute check.
2034 2001-01-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2036 * bgp_route.c (bgp_static_unset): Link-local IPv6 address can't be
2037 used for network advertisement.
2038 (nlri_parse): When link-local IPv6 address NLRI comes from
2039 remote-peer, log the information then simply ignore it.
2041 * bgp_zebra.c (zebra_read_ipv6): Link-local IPv6 address is not
2044 * bgp_route.c (bgp_update): Check IPv6 global nexthop
2047 2001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2049 * bgp_route.c (bgp_update): Check nexthop points local address or
2051 (bgp_static_update_vpnv4): Set valid flag.
2053 * bgp_attr.c (bgp_attr_parse): Duplicate attribute check.
2054 (bgp_attr_parse): Well-known attribute check.
2056 * bgp_open.c (bgp_auth_parse): Authentication is not yet supported.
2058 * bgp_packet.c (bgp_valid_marker): Check marker is synchronized.
2060 * bgpd.c (clear_bgp): Send NOTIFICATION Cease when SEND_CEASE is
2063 * bgp_snmp.c (bgp4PathAttrTable): Fix compile error.
2065 2001-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
2067 * bgpd.c (bgp_network_import_check): New command for IGP network
2070 2001-01-23 Kunihiro Ishiguro <kunihiro@zebra.org>
2072 * bgp_nexthop.c (bgp_scan): Run bgp_process when IGP metric is
2073 changed. Call bgp_process once for each node.
2075 2001-01-23 "Akihiro Mizutani" <mizutani@dml.com>
2077 * bgp_route.c (bgp_info_cmp): Add IGP metric comparison.
2079 2001-01-23 Kunihiro Ishiguro <kunihiro@zebra.org>
2081 * bgp_route.c (bgp_info_cmp): Add IGP metric comparison.
2083 * bgp_nexthop.c (bgp_nexthop_lookup): Set IGP metric for valid
2086 2001-01-23 "Akihiro Mizutani" <mizutani@dml.com>
2088 * bgp_route.c (show_ip_bgp_prefix_longer): Add new commands.
2089 "show ip bgp A.B.C.D/M longer-prefixes"
2090 "show ip bgp ipv4 (unicast|multicast) A.B.C.D/M longer-prefixes"
2091 "show ipv6 bgp X:X::X:X/M longer-prefixes"
2092 "show ipv6 mbgp X:X::X:X/M longer-prefixes"
2094 2001-01-20 "Akihiro Mizutani" <mizutani@dml.com>
2096 * bgp_route.c (show_ip_bgp_cidr_only): Add new commands.
2097 "show ip bgp cidr-only"
2098 "show ip bgp ipv4 (unicast|multicast) cidr-only"
2100 2001-01-18 "Akihiro Mizutani" <mizutani@dml.com>
2102 * bgp_route.c (bgp_update): AS path lookup check is done in
2103 bgp_update() not in attr_parse().
2105 2001-01-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2107 * bgp_route.c (bgp_update): Call bgp_aggregate_decrement() just
2108 before bgp_attr_unintern().
2110 2001-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2112 * bgp_route.c (bgp_update): Now intern is performed very last part
2113 of the BGP packet update procedure.
2115 2001-01-17 "Akihiro Mizutani" <mizutani@dml.com>
2117 * bgp_route.c (bgp_update): When implicit withdraw occur, reuse
2118 existing bgp_info structure.
2120 2001-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2122 * bgp_route.c (bgp_aggregate_decrement): Fix bug of aggregate
2123 address matching method.
2126 * bgp_nexthop.c (bgp_nexthop_onlink): Separate EBGP nexthop onlink
2127 check and IBGP nexthop route check.
2129 2001-01-16 "Akihiro Mizutani" <mizutani@dml.com>
2131 * bgp_route.h (BGP_INFO_ATRR_CHANGED): Added for track attribute
2134 2001-01-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2136 * bgp_route.h (struct bgp_info): Remove selected flag. Use
2137 BGP_INFO_SELECTED for flags instead.
2138 (struct bgp_info): Remove valid flag. Use BGP_INFO_VALID for
2140 (struct bgp_info): Add igpmetric for IBGP route nexthop IGP
2142 (struct bgp_info_tab): Struct bgp_info_tag is integrated into
2144 (BGP_INFO_ATRR_CHANGED): Added for track attribute change.
2146 * bgp_community.c (community_val_get): gcc-2.95 on
2147 sparc-sun-solaris cause crush. This function is for avoid the
2150 2001-01-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2152 * bgp_packet.c (bgp_open_receive): Translated peer's packet_size
2155 2001-01-14 "Akihiro Mizutani" <mizutani@dml.com>
2157 * bgp_packet.c (bgp_open_receive): Return notification with
2158 supported version number.
2160 2001-01-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2162 * bgpd.c (bgp_show_summary): Display AS path and community
2163 entries. Suggested by: "Matt Ranney" <mjr@ranney.com>.
2165 * bgp_packet.c (bgp_read_packet): Fix bug of unblocking BGP socket
2166 read. When BGP packet read is partial, we must get size and type
2169 2001-01-12 "Akihiro Mizutani" <mizutani@dml.com>
2171 * bgp_route.c (bgp_update): Do not unset BGP_INFO_HISTORY flag.
2172 (bgp_update): When there is a history entry increment route count.
2173 (bgp_damp_set): Check BGP_CONFIG_DAMPENING flag.
2175 * bgp_damp.c (bgp_damp_withdraw): Set status to
2176 BGP_DAMP_DISCONTINUE.
2178 2001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2180 * bgp_attr.c (bgp_mp_reach_parse): Fix warning code when second
2181 IPv6 nexthop is not link-local addresss.
2183 2001-01-11 "Akihiro Mizutani" <mizutani@dml.com>
2185 * bgp_damp.c (bgp_config_write_damp): Smart flap dampening
2186 configuration display.
2187 (bgp_damp_info_print): Display elapsed time from flap started.
2189 * bgp_damp.h (struct bgp_damp_info): Add flap start time.
2191 * bgpd.c (peer_create): Set last read time.
2192 (bgp_show_peer): Display last read time.
2193 (bgp_show_summary): Use BGP_CONFIG_DAMPENING flag to check
2196 * bgpd.h (BGP_CONFIG_DAMPENING): Add new configuration option.
2197 (struct peer): Add last read time member.
2198 (BGP_VERSION_MP_4): Remove obsolete definition.
2200 2001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2202 * bgp_nexthop.c: Remove OLD_RIB codes.
2204 * bgp_route.c (bgp_process): Likewise.
2206 * zebra-0.90 is released.
2208 * bgp_route.h (BGP_INFO_HISTORY): Remove damped member from struct
2209 bgp_info. Instead of that use BGP_INFO_DAMPED flag.
2210 (struct bgp_info): Remove invalid member from struct bgp_info.
2211 Instead of that use BGP_INFO_HISTORY flag.
2213 2001-01-10 "Akihiro Mizutani" <mizutani@dml.com>
2215 * bgp_damp.c (bgp_damp_info_print): New function to display
2217 (DEFAULT_HARF_LIFE): Define default value.
2218 (DEFAULT_REUSE): Likewise.
2219 (DEFAULT_SUPPRESS): Likewise.
2220 (bgp_config_write_damp): When config value is same as default
2221 value, simply display "bgp dampening" to configuration.
2223 * bgp_damp.h (struct bgp_damp_info): Add flap member.
2225 * bgp_route.h (struct bgp_info): Added for BGP flap dampening
2228 2001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2230 * bgp_nexthop.c (bgp_connected_add): Point-to-point connected
2231 address is properly handled.
2232 (bgp_connected_delete): Likewise.
2234 * bgp_route.c (bgp_route_init): Turn off BGP Flap dampening code
2235 until it works fine.
2237 2001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2239 * bgpd.c (bgp_show_summary): Add BGP_VERSION_MP_4 case.
2241 * bgp_route.c (bgp_update): When this is not damped route, clear
2244 2001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2246 * bgp_main.c: Add "-n" no_kernel option to not install route to
2247 kernel. Suggested by: "Matt Ranney" <mjr@ranney.com>
2249 2001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2251 * bgp_nexthop.c (bgp_connected_add): Revert point-to-point
2252 connected route patch. Reported by ruud@ruud.org (Ruud de Rooij)
2254 * bgp_damp.c (bgp_config_write_damp): Add configuration display
2257 * bgp_route.c (bgp_info_free): Set NULL to BGP dampening
2258 information when BGP info structure is freed.
2259 (bgp_info_cmp): Check damped flag.
2260 (bgp_announce_check): Damped route is not announced.
2262 2001-01-09 "Akihiro Mizutani" <mizutani@dml.com>
2264 * bgpd.c (neighbor_capability_route_refresh): Change "neighbor
2265 route-refresh" command to "neighbor capability route-refresh".
2266 (clear_bgp_soft_in): Change soft-reconfig method.
2268 clear ip bgp <neighbor> soft in
2269 --------------------------------------
2270 Try stored cache first then route-refresh
2272 clear ip bgp <neighbor> in
2273 ---------------------------------
2274 Try route-refresh first then try to use stored cache
2276 2001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2278 * bgp_nexthop.c (bgp_connected_add): Check point-to-point
2279 connected route. Reported by ruud@ruud.org (Ruud de Rooij)
2281 2001-01-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2283 * bgp_nexthop.c (bgp_nexthop_lookup): When IBGP nexthop is
2284 changed, refresh it.
2286 2001-01-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2288 * bgp_route.h (struct bgp_info_tag): Add as_selected to
2291 2001-01-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2293 * bgp_route.h (struct bgp_info_tag): Add damped and bgp_damp_info
2294 member for BGP flap dampening.
2296 * bgp_damp.c: New file is added.
2298 * bgp_damp.h: Likewise.
2300 2001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2302 * bgpd.h (BGP_VTYSH_PATH): Change "/tmp/bgpd" to "/tmp/.bgpd".
2304 2000-12-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2306 * bgp_nexthop.c (zlookup_connect): Change to use UNIX domain
2307 socket for zebra communication.
2309 2000-12-29 Akihiro Mizutani <mizutani@dml.com>
2311 * bgp_route.c (bgp_process): Fix "bgp deterministic-med" process.
2313 2000-12-27 Akihiro Mizutani <mizutani@dml.com>
2315 * bgp_route.c (bgp_process): Add "bgp deterministic-med" process.
2317 2000-12-25 Akihiro Mizutani <mizutani@dml.com>
2319 * bgp_route.c (bgp_info_cmp): Use ntohl comparing router ID.
2321 2000-12-18 Akihiro Mizutani <mizutani@dml.com>
2323 * bgp_route.c (bgp_info_cmp): When over three same prefix exit,
2324 withdrawing best prefix perform router ID comparison.
2326 2000-12-15 Akihiro Mizutani <mizutani@dml.com>
2328 * bgp_route.c (bgp_info_cmp): Do not compare router ID when the
2329 routes comes from EBGP peer. When originator ID is same, take
2330 shorter cluster-list route. If cluster-list is same take smaller
2331 IP address neighbor's route.
2333 * bgpd.c (bgp_bestpath_aspath_ignore): Add "bgp bestpath as-path
2334 ignore" command. When this option is set, do not concider AS path
2335 length when route selection.
2336 (bgp_bestpath_compare_router_id): Add "bgp bestpath
2337 compare-routerid". When this option is set, compare router ID
2338 when the routes comes from EBGP peer.
2340 2000-12-15 Akihiro Mizutani <mizutani@dml.com>
2342 * bgp_route.c (bgp_info_cmp): Compare originator ID when it is
2345 2000-12-14 Akihiro Mizutani <mizutani@dml.com>
2347 * bgp_packet.c (bgp_notify_receive): Disply received Notify data
2350 2000-12-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2352 * bgp_filter.c (as_filter_free): Use MTYPE_AS_FILTER_STR to make
2353 it sure the memory is freed.
2355 * bgp_route.c (route_vty_out_detail): Do not use AF_INET6 outside
2358 2000-12-08 Akihiro Mizutani <mizutani@dml.com>
2360 * bgp_packet.c (bgp_notify_send_with_data): Store BGP notification
2363 * bgp_network.c (bgp_accept): When BGP connection comes from
2364 unconfigured IP address, close socket immediately.
2366 * bgpd.c: Fix some display format.
2368 2000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2370 * bgp_packet.c (bgp_keepalive_send): Delete duplicate
2371 bgp_packet_set_size () call.
2373 2000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2375 * bgp_packet.c (bgp_read_packet): Remove debug codes.
2377 2000-11-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2379 * bgp_snmp.c (write_bgpPeerTable): Add SNMP set method routine.
2381 * bgp_fsm.c (bgp_stop): Use fsm_change_status to change peer's
2383 (bgp_establish): Likewise.
2385 2000-11-26 Akihiro Mizutani <mizutani@dml.com>
2387 * bgp_open.c: Fix error messages.
2389 2000-11-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2391 * bgp_fsm.c (bgp_establish): Call BGP trap when the peer is
2393 (bgp_stop): Call BGP trap when the peer is dropped.
2395 2000-11-24 Kunihiro Ishiguro <kunihiro@zebra.org>
2397 * bgp_snmp.c (bgp4PathAttrTable): Return BGP path attribute table.
2399 * bgpd.h (struct peer): Add update_time for track last update
2402 * bgp_packet.c (bgp_notify_receive): Preserv notify code and sub
2405 * bgp_snmp.c (bgpPeerTable): Return remote router ID instead of
2407 (bgpPeerTable): Return actual BGP version number.
2409 2000-11-22 Akihiro Mizutani <mizutani@dml.com>
2411 * bgp_debug.c (bgp_notify_print): Notify data length display bug
2414 2000-11-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2416 * bgp_nexthop.c (zlookup_connect): When UNIX domain connection to
2417 zebra is enabled, use the method.
2419 2000-11-16 Akihiro Mizutani <mizutani@dml.com>
2421 * bgpd.c: Revise debug message output.
2423 2000-11-15 Akihiro Mizutani <mizutani@dml.com>
2425 * bgp_clist.c (ip_community_list): Fix bug of string comparison.
2427 2000-11-14 Akihiro Mizutani <mizutani@dml.com>
2429 * bgp_community.c (community_match): Fix bug of memcmp return
2432 2000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2434 * bgp_clist.c (community_list_match_exact): Add check for
2435 entry->style is COMMUNITY_LIST.
2436 (community_match_regexp): Apply new com_nthval macro.
2438 2000-11-07 Rick Payne <rickp@rossfell.co.uk>
2440 * bgp_routemap.c (route_set_community_delete): "set
2441 community-delete COMMUNITY-LIST" is added.
2443 * bgp_community.c (community_del_val): Delete one community.
2444 (community_delete): Delete all community included in list.
2445 (community_match): Fix bug of matching community value.
2447 * bgp_clist.c (community_entry_free): Free community regular
2449 (community_entry_make): Default style is COMMUNITY_LIST.
2450 (community_entry_lookup): Make it sure style is COMMUNITY_LIST.
2451 (community_entry_regexp_lookup): New function for community
2452 regular expression lookup.
2453 (community_match_regexp): New function.
2454 (community_delete_regexp): New function.
2455 (community_list_delete_entries): New function.
2456 (community_list_match): Add COMMUNITY_REGEXP treatment.
2457 (community_list_match_exact): Likewise.
2458 (config_write_community): Write community list according to
2461 2000-11-07 Rick Payne <rickp@rossfell.co.uk>
2463 * bgp_attr.c (bgp_attr_aspath): AS path first AS check.
2465 * bgp_clist.c (struct community_entry): Add style, regexp, reg to
2468 2000-11-06 Rick Payne <rickp@rossfell.co.uk>
2470 * bgp_aspath.c (aspath_firstas_check): AS path first AS check.
2472 * bgpd.c (bgp_enforce_first_as): New command "bgp
2475 * bgpd.h (BGP_CONFIG_ENFORCE_FIRST_AS): Add new flag.
2477 2000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2479 * bgp_community.c (community_compare): Copy byte stream data to
2480 actual value instead of using type casting hack.
2481 (community_add_val): Likewise.
2482 (community_uniq_sort): Likewise.
2483 (community_print): Likewise.
2484 (community_print_vty): Likewise.
2485 (community_include): Use memcmp to compare community value.
2487 * bgp_community.h (com_lastval): com_lastval and com_nthval macro
2490 2000-11-06 Akihiro Mizutani <mizutani@dml.com>
2492 * bgpd.h (struct peer): Add established and dropped member for
2493 count peering up/down statistics.
2495 * bgpd.c (bgp_show_peer): Display peering up/down statistics.
2497 * bgp_fsm.c (bgp_establish): Increment established count.
2498 (bgp_stop): Increment dropped count.
2500 * bgp_packet.c (bgp_notify_receive): Increament notify count.
2502 2000-11-1 Akihiro Mizutani <mizutani@dml.com>
2504 * bgp_fsm.c: Fix bug of holdtimer is not reset when bgp cleared.
2506 2000-10-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2508 * bgpd.h: Static bit flag is set by (1 << DIGIT).
2510 2000-10-24 Akihiro Mizutani <mizutani@dml.com>
2512 * bgp_ecommunity.c (ecommunity_dup): Extended community display
2515 2000-10-24 Arkadiusz Miskiewicz <misiek@pld.org.pl>
2517 * bgp_network.c (bgp_serv_sock_addrinfo): Use gai_strerror.
2518 (bgp_serv_sock_addrinfo): Check address family.
2520 2000-10-23 Jochen Friedrich <jochen@scram.de>
2522 * bgp_snmp.c: bgp_oid and bgpd_oid are used in smux_open after it
2523 is registered. So those variables must be static.
2525 2000-10-23 Akihiro Mizutani <mizutani@dml.com>
2527 * bgp_routemap.c (route_match_ip_next_hop): Change "match ip
2528 next-hop" argument from IP address to access-list name.
2529 Remove zebra-0.88 compatibility commands.
2530 "match ip prefix-list WORD"
2531 "match ipv6 prefix-list WORD"
2533 2000-10-23 Kunihiro Ishiguro <kunihiro@zebra.org>
2535 * bgp_routemap.c (route_match_ipv6_next_hop_compile): Fix bug of
2536 passing the pointer to the pointer of struct in6_addr instead of
2537 the pointer of struct in6_addr in "match ipv6 next-hop" command.
2539 * bgp_route.c (bgp_announce_check): Enclose IPv6 part with
2542 2000-10-20 Jasper Wallace <jasper@ivision.co.uk>
2544 * bgp_snmp.c (bgpPeerTable): ntohs missing bug is fixed. Change
2545 to use linklist.c. Define COUNTER32 as ASN_COUNTER.
2547 2000-10-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2549 * bgp_route.c (bgp_announce_check): attr->nexthop empty check
2550 should be done by attr->nexthop.s_addr instead of strcmp.
2552 2000-10-18 Akihiro Mizutani <mizutani@dml.com>
2554 * bgp_zebra.c (zebra_read_ipv4): Pass nexthop value to
2555 bgp_redistribute_add().
2557 * bgp_nexthop.c (bgp_multiaccess_check_v4): New function for
2558 checking IPv4 multiaccess nexthop.
2560 * bgp_route.c (bgp_announce_check): In case of the nexthop is
2561 reachable on multiaccess media, do not change nexthop.
2562 (bgp_redistribute_add): Set nexthop when the value is passed.
2564 2000-10-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2566 * bgp_fsm.c (bgp_timer_set): If peer is passive mode, do not set
2568 (bgp_start): If the peer is passive mode, force to move to Active
2571 2000-10-17 Horms <horms@vergenet.net>
2573 * bgp_debug.c (debug_bgp_fsm): Fix typo.
2575 2000-10-17 Akihiro Mizutani <mizutani@dml.com>
2577 * bgp_route.c: "show ipv6 bgp" route display improvement.
2579 2000-10-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2581 * bgp_route.c (neighbor_routes): Allocate sockunion for callback
2583 (bgp_show_neighbor_route): Remove static declaration for union
2586 * bgpd.c (peer_update_source_set): Clean previously allocated
2587 memory before allocate new one.
2589 2000-10-03 Akihiro Mizutani <mizutani@dml.com>
2591 * bgp_route.c (neighbor_routes): Add show neighbor's routes
2593 "show ip bgp neighbors (A.B.C.D|X:X::X:X) routes"
2594 "show ip bgp ipv4 (unicast|multicast) neighbors (A.B.C.D|X:X::X:X) routes"
2595 "show ipv6 bgp neighbors (A.B.C.D|X:X::X:X) routes"
2596 "show ipv6 mbgp neighbors (A.B.C.D|X:X::X:X) routes"
2598 2000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2600 * zebra-0.89 is released.
2602 2000-10-02 Akihiro Mizutani <mizutani@dml.com>
2604 * bgpd.c: "bgp deterministic-med" command is added.
2606 2000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2608 * bgp_nexthop.c (bgp_connected_add): Apply mask for connected
2609 route addition and deletion.
2611 2000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2613 * bgp_aspath.c (aspath_cmp_left): Skip confederation AS segment
2614 when comparing leftmost AS number.
2616 2000-09-29 Akihiro Mizutani <mizutani@dml.com>
2618 * bgpd.c (peer_route_reflector): Route reflector can be set for
2620 (bgp_distribute_set): Fix bug of string check for (in|out).
2621 (bgp_show_summary): Display total neighbor count.
2623 2000-09-28 Akihiro Mizutani <mizutani@dml.com>
2625 * bgp_attr.c (bgp_packet_attribute): Only add cluster_list and
2626 originator for clinet to client routes.
2627 (bgp_packet_attribute): Add new cluster_list to the beginning of
2628 existing cluster_list.
2629 (bgp_packet_attribute): Fix bug of originator is rewritten even
2630 when originator is already set.
2632 2000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2634 * bgpd.c (bgp_client_to_client_reflection): Add new command.
2635 "no bgp client-to-client reflection"
2636 "bgp client-to-client reflection"
2638 * bgpd.h (BGP_CONFIG_NO_CLIENT_TO_CLIENT): Add new definition.
2640 2000-09-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2642 * bgp_packet.c (bgp_read): Make BGP packet read to non-blocking
2644 (bgp_read_packet): Likewise.
2645 (bgp_read_packet): When errono is EAGAIN, try to read it again.
2647 * bgp_fsm.c (bgp_stop): Clear packet size and read buffer.
2649 2000-09-26 Akihiro Mizutani <mizutani@dml.com>
2651 * bgp_routemap.c: Configuration of prefix-list match is shown as
2652 "match ip address prefix-list <WORD>". Old configuration "match
2653 ip prefix-list <WORD>" is left for compatibilitty.
2655 2000-09-25 Akihiro Mizutani <mizutani@dml.com>
2657 * bgpd.h (BGP_CONFIG_MED_MISSING_AS_WORST): Changed from
2658 BGP_CONFIG_MISSING_AS_WORST.
2660 * bgpd.c (bgp_bestpath_med): Change missing-as-worst syntax.
2661 Old "bgp bestpath missing-as-worst"
2662 New "bgp bestpath med missing-as-worst"
2664 2000-09-24 Akihiro Mizutani <mizutani@dml.com>
2666 * bgp_route.c: Compare MED properly in case of CONFED-IBGP.
2668 2000-09-21 steve@Watt.COM (Steve Watt)
2670 * bgp_debug.h: Do not declare debug variables conf_bgp_debug_* and
2673 * bgp_debug.c: Declare variables here.
2675 2000-09-21 Akihiro Mizutani <mizutani@dml.com>
2677 * bgpd.c: MBGP soft-reconfiguration command is added.
2678 clear ip bgp x.x.x.x ipv4 (unicast|multicast) in
2679 clear ip bgp x.x.x.x ipv4 (unicast|multicast) out
2680 clear ip bgp x.x.x.x ipv4 (unicast|multicast) soft
2681 clear ip bgp <1-65535> ipv4 (unicast|multicast) in
2682 clear ip bgp <1-65535> ipv4 (unicast|multicast) out
2683 clear ip bgp <1-65535> ipv4 (unicast|multicast) soft
2684 clear ip bgp * ipv4 (unicast|multicast) in
2685 clear ip bgp * ipv4 (unicast|multicast) out
2686 clear ip bgp * ipv4 (unicast|multicast) soft
2688 Change "clear ip bgp vpnv4 x.x.x.x soft" command to
2689 "clear ip bgp x.x.x.x vpnv4 unicast soft".
2691 "bgp bestpath med confed" command is added.
2693 * bgpd.h (BGP_CONFIG_MED_CONFED): Add New definition.
2695 2000-09-18 Rick Payne <rickp@rossfell.co.uk>
2697 * bgpd.c (bgp_show_peer): Fix misplaced #endif.
2699 2000-09-12 Akihiro Mizutani <mizutani@dml.com>
2701 * bgpd.c (bgp_default_local_preference): Add "bgp default
2702 local-preference" command.
2704 * bgp_nexthop.c (no_bgp_scan_time): Add "no bgp scan-time"
2707 2000-09-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2709 * bgp_zebra.c (bgp_zebra_announce): BGP confederation peer's routes
2710 are passed to zebra like IBGP route.
2712 2000-09-10 Akihiro Mizutani <mizutani@dml.com>
2714 * bgpd.c (bgp_config_write_peer): Make it consistent passive
2717 * bgp_route.c: Community match command is added.
2718 "show ip bgp community <val>"
2719 "show ip bgp community <val> exact-match"
2721 2000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2723 * bgp_nexthop.c (bgp_nexthop_lookup): ebgp-multihop routes are
2724 treated as IBGP routes.
2726 2000-09-08 Akihiro Mizutani <mizutani@dml.com>
2728 * bgp_route.c (bgp_show_route): When local-AS community route is
2729 selected, display "not advertised outside local AS" to "show ip
2730 route A.B.C.D" output.
2731 (show_ip_bgp_ipv4_filter_list): Add below four commands.
2732 "show ip bgp ipv4 (unicast|multicast) filter-list WORD"
2733 "show ip bgp ipv4 (unicast|multicast) community"
2734 "show ip bgp ipv4 (unicast|multicast) community-list WORD"
2735 "show ip bgp ipv4 (unicast|multicast) community-list WORD exact-match"
2737 * bgp_clist.c (community_list_match_exact): Community exact match
2740 2000-09-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2742 * bgp_route.c (bgp_update): Add peer's ttl check.
2744 * bgpd.h (struct peer): Structure member refresh is renamed to
2747 * bgpd.c (clear_bgp_soft_in): Check PEER_FLAG_ROUTE_REFRESH flag
2748 when soft reconfiguration is performed.
2750 * bgp_zebra.c (bgp_zebra_announce): When the peer is EBGP and
2751 ebgp-multiphop is set, set ZEBRA_FLAG_INTERNAL for nexthop lookup.
2753 * bgp_route.h (struct bgp_info_tag): Add valid flag.
2755 2000-08-25 Akihiro Mizutani <mizutani@dml.com>
2757 * bgpd.c: Add AS base BGP soft reconfiguration.
2759 * bgp_route.c: When no-advertise or no-export route is selected,
2760 "show ip bgp" display "not advertised to EBGP peer" or "not
2761 advertised to any peer" message.
2763 2000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2765 * zebra-0.88 is released.
2767 * bgp_dump.c (dump_bgp_routes): Change "dump bgp routes" to "dump
2768 bgp route-mrt" to support MRT specific dump format.
2770 * bgpd.c (bgp_init): "clear ip bgp vpnv4 soft {in,out}" command is
2773 * bgp_route.c (bgp_update): Currently nexthop check is only works
2776 2000-08-17 Akihiro Mizutani <mizutani@dml.com>
2778 * bgpd. (clear_ip_bgp_all_soft): Add "clear ip bgp * soft" for
2779 both inbound and outbound soft reconfiguration.
2781 2000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2783 * bgpd.c (clear_ip_bgp_peer_soft_out): Add soft-reconfiguration
2785 (peer_new): Set route-refresh flag.
2787 2000-08-16 Akihiro Mizutani <mizutani@dml.com>
2789 * bgpd.c: "no bgp router-id A.B.C.D" alias is added. "no bgp
2790 cluster-id A.B.C.D" alias is added. " bgp cluster-id
2791 <1-4294967295>" alias is added. "clear ip bgp * soft in" command
2792 is added. "clear ip bgp A.B.C.D in" alias is added. "clear ip
2793 bgp * in" alias is added.
2795 2000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2797 * bgp_route.c (bgp_update): Add soft_reconfig flag. When the flag
2798 is set do not install the route into Adj-RIBs-In.
2799 (bgp_update): Perform implicit withdraw before filtering of the
2802 * bgp_packet.c (bgp_read): draft-ietf-idr-bgp-route-refresh-01.txt
2803 capability code and BGP message can be accepted.
2805 * bgp_open.c (bgp_capability_parse): Likewise.
2807 * bgp_route.c (bgp_refresh_table): New function for route refresh.
2808 (bgp_refresh_rib): Likewise.
2810 * bgpd.c (bgp_show_peer): Display route refresh status.
2812 * bgp_route.c (bgp_aggregate_add): Add check for the route
2814 (bgp_aggregate_delete): Likewise.
2816 2000-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2818 * bgp_nexthop.c (bgp_scan): Care for aggregate route when the
2819 route become inaccessible.
2821 2000-08-15 Akihiro Mizutani <mizutani@dml.com>
2823 * bgp_route.c (show_ip_bgp_prefix): "show ip bgp A.B.C.D/M"
2826 2000-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2828 * bgp_zebra.c (bgp_interface_up): Register connected route.
2829 (bgp_interface_down): Unregister connected route.
2831 2000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2833 * bgp_route.h (struct bgp_info): Add distance to the structure.
2835 * bgp_route.c (bgp_aggregate_increment): Aggregate route only
2836 match to smaller prefixlen route not match same prefixlen route.
2837 (bgp_aggregate_decrement): Likewise.
2838 (bgp_aggregate_add): Likewise.
2839 (bgp_aggregate_delete): Likewise.
2840 (bgp_network_backdoor): Add backdoor network configuration.
2842 * bgpd.h (struct bgp ): Add distance_{ebgp,ibgp,local} for store
2843 configuration distance value.
2845 * bgp_route.c (bgp_update): Filter EBGP route which has non
2848 * bgp_attr.c (bgp_attr_aggregate_intern): New function for
2849 aggregate route. Set origin to IGP. Set atomic aggregate flag.
2850 Set aggregator AS and address.
2851 (bgp_attr_aggregate_intern): Check BGP_CONFIG_CONFEDERATION when
2852 filling aggregator_as.
2854 * bgp_route.c (bgp_process): Delete suppress check for install
2855 suppressed route into local routing table.
2856 (bgp_aggregate_increment): Use bgp_attr_aggregate_intern() instead
2857 of bgp_attr_default_intern ().
2858 (bgp_aggregate_add): Likewise.
2860 * bgpd.c (bgp_get): Call bgp_if_update_all() after BGP instance is
2861 created. This is for avoid 0.0.0.0 router-id.
2863 2000-08-13 Akihiro Mizutani <mizutani@dml.com>
2865 * bgp_route.c (route_vty_out_detail): Display "valid" when the
2866 route is valied. Display "aggregated" when the route is
2867 aggregated. "Advertisements suppressed by an aggregate" is
2868 displayed when the route is suppressed.
2869 (bgp_info_cmp): Prefer EBGP than Confed-EBGP.
2871 2000-08-10 Akihiro Mizutani <mizutani@dml.com>
2873 * bgp_route.c (route_vty_out_detail): Display format change.
2875 2000-08-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2877 * bgp_route.c (bgp_update): Only AFI_IP nexthop check is enabled.
2879 * bgpd.c (bgp_delete): Delete static route before delete peer
2882 2000-08-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2884 * bgpd.c: Include bgpd/bgp_nexthop.h.
2886 2000-07-31 Akihiro Mizutani <mizutani@dml.com>
2888 * bgpd.c (bgp_show_summary): "show ip bgp summary" shows own BGP
2889 identifier. And status is changed like below.
2891 State/Pref -> State/PfxRcd
2892 Shutdown -> Idle (Admin)
2893 PrefixOvflw -> Idle (PfxCt)
2895 * bgp_route.c (route_vty_out): Show internal route as "i".
2897 2000-07-13 Jim Bowen <jimb@zereau.net>
2899 * bgp_snmp.c: Add BGP peer MIB implementation.
2901 2000-07-12 Akihiro Mizutani <mizutani@dml.com>
2903 * bgpd.c (bgp_show_peer): Fix typo.
2905 2000-07-11 Akihiro Mizutani <mizutani@dml.com>
2907 * bgp_routemap.c: Add commands for deleting set without argument.
2909 2000-07-03 Akihiro Mizutani <mizutani@dml.com>
2911 * bgp_zebra.c: Fix redistribute help strings.
2913 2000-07-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2915 * bgp_route.c (bgp_show): When bgpd works as vtysh server send all
2916 output to vty at once.
2918 2000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2920 * bgp_mplsvpn.c (no_vpnv4_network): "no network A.B.C.D/M rd WORD
2921 tag WORD" command is added.
2923 * bgp_ecommunity.c (ecommunity_vty_out): New function added.
2925 2000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2927 * bgp_route.c (bgp_show): Fix total number of prefix count bug.
2929 * bgpd.c (bgp_show_peer): Display VPNv4 unicast configuration and
2930 negotiation result in "show ip bgp neighbors".
2932 2000-06-12 Akihiro Mizutani <mizutani@dml.com>
2934 * bgpd.c: Fix help strings.
2938 2000-06-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2940 * bgp_route.c (bgp_aggregate_unset): Fix bug of checking rn->info
2941 instead of rn. Reported by Akihiro Mizutani <mizutani@dml.com>.
2943 * bgp_mplsvpn.c (vpnv4_network): For testing purpose, "network
2944 A.B.C.D rd RD" is added to address-family vpnv4 unicast node.
2946 * bgp_route.c (bgp_static_set): Set safi to p.safi.
2948 2000-06-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2950 * bgp_route.c (bgp_show_prefix_list): Change to use bgp_show().
2951 (bgp_show_regexp): Change to use bgp_show().
2952 (show_adj_route): Change to display header.
2954 * bgpd.c (clear_bgp): Set peer->v_start to default value when peer
2955 is cleared manually.
2957 * bgp_route.c (bgp_show_route): New function which display
2958 specific BGP route. Divided from bgp_show().
2959 (bgp_static_delete): Delete all static route.
2961 2000-06-09 NOGUCHI Kay <kay@v6.access.co.jp>
2963 * bgp_route.c (show_ipv6_bgp): "show ipv6 bgp" is broken with
2964 invalid privious fix. Now show_ipv6_bgp and show_ipv6_bgp_route
2965 take care of "show ipv6 bgp [X:X::X:X]". Same change for "show ip
2966 mbgp" and "show ipv6 mbgp".
2968 2000-06-07 Akihiro Mizutani <mizutani@dml.com>
2970 * bgp_route.c: Fix help strings and command arguments.
2972 2000-06-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2974 * bgp_ecommunity.c: Include prefix.h
2976 2000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2978 * bgp_route.h (struct bgp_info_tag): New structure to hold tag
2981 * bgp_route.c (bgp_adj_set): table NULL check is added.
2982 (bgp_adj_unset): Likewise.
2983 (bgp_adj_lookup): Likewise.
2984 (bgp_adj_clear): Likewise.
2985 (route_vty_out): Add SAFI check for nexthop display.
2986 (bgp_withdraw): Add SAFI check for withdraw route.
2988 * Remove all #ifdef MPLS_VPN then include it as default.
2990 * bgpd.c: Temporary disable peer-group command until the
2991 implementation is completed.
2993 * bgp_routemap.c (bgp_route_map_init): Install
2994 route_metric_match_cmd.
2995 (route_match_metric_compile): MED value compile using strtoul.
2997 2000-06-05 Akihiro Mizutani <mizutani@dml.com>
2999 * bgp_filter.c: Fix help strings. Change REGEXP to LINE. Change
3002 * Change command argument to more comprehensive.
3004 METRIC -> <0-4294967295>
3005 WEIGHT -> <0-4294967295>
3006 LOCAL_PREF -> <0-4294967295>
3009 AS-PATH-NAME -> WORD
3013 EXT_COMMUNITY -> ASN:nn_or_IP-address:nn
3014 IPv6_ADDR -> X:X::X:X
3016 * bgp_clist.c: Fix help strings.
3018 2000-06-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3020 * bgpd.c (peer_active): Add new function for check the peer is
3022 (neighbor_activate): New command "neighbor PEER activate" and "no
3023 neighbor PEER activate" are added.
3025 * bgp_packet.c: Include bgpd/bgp_mplsvpn.h.
3027 2000-06-02 Akihiro Mizutani <mizutani@dml.com>
3029 * bgp_clist.c: Fix commuity-list help strings.
3031 * bgp_routemap.c: Fix "set community" help strings. Add #define
3032 SET_STR. Use (unicast|multicast) argument for "set nlri" command.
3034 2000-06-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3036 * bgp_routemap.c (route_set_community_none_cmd): "set community
3037 none" command is added to route-map.
3039 2000-06-01 Akihiro Mizutani <mizutani@dml.com>
3041 * bgp_debug.c: Change "show debug" to "show debugging". Now "show
3042 debugging" is not used in VIEW_NODE.
3044 2000-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3046 * bgp_fsm.c (bgp_timer_set): Add check for shutdown flag. This
3047 fix unconditional BGP connection.
3049 * bgpd.c (peer_shutdown): Replace peer_shutdown() with
3050 peer_change_flag_with_reset().
3052 2000-05-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3054 * bgpd.c (no_bgp_default_ipv4_unicast): Add "no bgp default
3055 ipv4-unicast" command.
3057 * bgpd.h (BGP_CONFIG_NO_DEFAULT_IPV4): Add new definition.
3059 * bgp_filter.c (as_list_delete): Free all AS filter.
3061 * bgp_clist.c (community_list_delete): Free all community entry.
3063 * bgp_filter.c (no_ip_as_path_all): New DEFUN for "no ip as-path
3066 * bgp_clist.c (no_ip_community_list_all): New DEFUN for "no ip
3067 community-list NAME".
3069 2000-05-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3071 * bgp_route.c (ipv6_mbgp_neighbor_routes): Change "show ip bgp PEER
3072 routes" to "show ip bgp PEER received-routes"
3074 2000-05-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3076 * bgp_ecommunity.c (ecommunity_parse): New file for Extended
3077 Communities attribute.
3078 * bgp_ecommunity.h: Likewise.
3080 2000-05-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3082 * bgp_mplsvpn.h: New file for MPLS-VPN.
3083 * bgp_mplsvpn.c: Likewise.
3085 * bgpd.c (bgp_delete): Fix bug of "no router bgp" crush.
3087 2000-05-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3089 * bgpd.c (bgp_bestpath_missing_as_worst): Add "bgp bestpath
3092 2000-05-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3094 * bgp_routemap.c (match_community): Clarify help of "match
3097 2000-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3099 * bgp_aspath.c (aspath_cmp_left): Remove debug code.
3101 2000-04-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3103 * bgp_route.c (bgp_info_cmp): Compare MED only both routes comes
3104 from same neighboring AS.
3106 * bgp_aspath.c (aspath_cmp_left): Compare leftmost AS value.
3108 * bgp_route.c (bgp_info_cmp): Fix misused htonl() to ntohl().
3110 2000-04-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3112 * bgp_route.c (bgp_output_filter): When distribute-list's
3113 corresponding access-list does not exist, filter all routes.
3114 (bgp_input_filter): Likewise.
3116 2000-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3118 * bgp_attr.c (bgp_packet_attribute): Propagate MED to IBGP peer.
3120 * bgp_route.c (bgp_info_cmp): Add evaluation of local preference.
3122 2000-04-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3124 * bgpd.c (bgp_distribute_update): Add struct access_list *
3127 2000-04-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3129 * bgp_clist.c (community_list_dup_check): Add duplicate insertion
3132 * bgp_filter.c (as_list_dup_check): Add duplicate insertion check.
3134 * bgp_route.c (bgp_show): Fix undeclared write variable.
3136 2000-04-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3138 * bgp_routemap.c: Add "match ip address prefix-list".
3140 2000-03-29 Rick Payne <rickp@rossfell.co.uk>
3142 * bgp_aspath.c (aspath_strip_confed): Fix realloc problem.
3144 2000-03-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3146 * bgp_fsm.c (bgp_reconnect): Connect retry timer is expired when
3147 the peer status is Connect.
3149 2000-03-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3151 * Fix bug of rewritten originator-id.
3153 2000-01-27 Rick Payne <rickp@rossfell.co.uk>
3155 * bgp_aspath.c (aspath_delimiter_char): New function. Instead of
3156 directly referencing array, search proper AS path delimiter.
3157 (aspath_strip_confed): Strip the confederation stuff from the
3158 front of an AS path.
3159 (aspath_add_left_confed): New function for adding specified AS to
3160 the leftmost AS_CONFED_SEQUENCE.
3162 * bgp_aspath.h: Change AS_CONFED_SEQUENCE and AS_CONFED_SET value
3163 to Cisco compatible.
3165 * bgpd.c (bgp_confederation_id_set): Confederation configuration.
3166 (bgp_confederation_id_unset): Likewise.
3167 (bgp_confederation_peers_check): Likewise.
3168 (bgp_confederation_peers_add): Likewise.
3169 (bgp_confederation_peers_remove): Likewise.
3170 (bgp_confederation_peers_set): Likewise.
3171 (bgp_confederation_peers_unset): Likewise.
3172 (bgp_confederation_peers_print): Likewise.
3174 2000-01-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3176 * bgpd.c: Introduce peer_change_flag_with_reset() fucntion.
3178 2000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3180 * bgp_open.c (bgp_open_option_parse): When there is no common
3181 capability send Unsupported Capability error to the peer.
3183 2000-01-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3185 * bgp_open.c (bgp_capability_mp): Fix bug of mis-negotiation about
3188 * bgpd.c (bgp_init): Add "soft-reconfiguration inbound" command.
3190 2000-01-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3192 * bgpd.c (neighbor_strict_capability): Add
3193 "strict-capability-match" command.
3195 * bgp_zebra.c (bgp_if_update): Ignore NET127 determining
3198 * bgpd.c (peer_override_capability): Add "override-capability"
3201 1999-12-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3203 * bgp_packet.c (bgp_write): Change status to Idle and set timer
3206 1999-12-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3208 * bgp_zebra.c (bgp_zebra_announce): Add info->selected check.
3210 1999-12-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3212 * bgp_route.c (nlri_unfeasible): nlri_unfeasible() is merged with
3215 1999-12-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3217 * bgp_fsm.h (BGP_EVENT_DELETE): Macro added.
3219 * bgp_fsm.c (bgp_stop): Clear all event threads of the peer when
3220 the peer is cleared.
3222 * bgp_zebra.c (bgp_nexthop_set): Clear interface index of
3223 link-local address. This is KAME specific problem.
3225 1999-12-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3227 * bgp_attr.c (bgp_mp_reach_parse): Comment out previous code for a
3228 while. We don't completely detect the link is shared or not at
3231 * bgp_packet.c (bgp_notify_send): Make shortcut call of
3232 bgp_write() and bgp_stop().
3234 * bgp_attr.c (bgp_mp_reach_parse): Fix serious bug when getting
3235 global and link-local address.
3237 1999-12-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3239 * bgpd.c (no_neighbor_port): New command added.
3240 (peer_new): Set send_community.
3242 1999-12-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3244 * bgpd.c (show_ip_bgp_summary): Changed to use bgp_show_summary().
3245 (show_ip_mbgp_summary): Likewise.
3246 (show_ipv6_bgp_summary): Likewise.
3247 (show_ipv6_mbgp_summary): Add new command.
3248 (peer_free): Free peer->host.
3249 (peer_lookup_by_su): Delete function.
3250 (ipv6_bgp_neighbor): Changed to use peer_remote_as().
3251 (sockunion_vty_out): Function deleted.
3252 (vty_clear_bgp): Use afi instead of family.
3253 Delete old list bgp_list. Use struct newlist *bgplist.
3254 (peer_lookup_by_host): Function deleted.
3256 1999-12-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3258 * bgpd.h (struct peer_group): New structure added.
3259 (struct peer_conf): New structure added.
3260 (struct peer): Change all prefix_count to unsigned long.
3262 * bgpd.c: Reconstruct all of VTY commands reflect internal
3264 Use bgplist instead of bgp_list.
3265 Use peerlist intstead of peer_list.
3267 * bgp_attr.c (bgp_mp_reach_parse): If nlri_parse return -1, stop
3268 parsing then return immediately.
3270 * bgp_route.c (nlri_parse): When NLRI parse error occured, return
3272 (nlri_process): Use pcount_v4_{unicast,multicast}.
3273 (nlri_delete): Likewise.
3275 1999-11-25 Robert Olsson <Robert.Olsson@data.slu.se>
3277 * bgp_routemap.c (route_match_nlri): `match nlri
3278 unicast|multicast' and `set nlri unicast|multicast' command are
3281 1999-11-22 Robert Olsson <Robert.Olsson@data.slu.se>
3283 * bgpd.c: Add translate-update support.
3285 * bgpd.h (TRANSLATE_UPDATE_OFF): Add translate-update definition.
3287 1999-11-19 Robert.Olsson@data.slu.se
3289 * bgp_route.c (bgp_peer_delete): Add MBGP peer clear codes.
3291 1999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3293 * bgp_open.c (bgp_capability_mp): Temporary comment out
3294 SAFI_UNICAST_MULTICAST handling until we know the meanings.
3296 1999-11-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3298 * bgp_btoa.c: New file added.
3300 1999-11-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3302 * bgpd.h (struct peer): Add dont_capability flag.
3303 (struct peer): Add override_capability flag.
3305 * bgpd.c (neighbor_dont_capability_negotiation): `neighbor PEER
3306 dont-capability-negotiation' added.
3308 1999-11-12 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3310 * bgp_attr.c (bgp_mp_reach_parse): Ignore link-local addresses
3311 attribute from non-shared-network peers.
3313 1999-11-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3315 * bgp_snmp.c: New file added.
3317 * BGP4-MIB.txt: Updated to the latest Internet-Draft
3318 draft-ietf-idr-bgp4-mib-04.txt.
3320 1999-11-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3322 * bgp_route.c (bgp_route_init): Add `show ipv6 bgp prefix-list'.
3324 * bgp_attr.c (bgp_mp_unreach_parse): Enclose safi setup with
3327 1999-11-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3329 * bgp_dump.c (no_dump_bgp_all): Add [PATH] and [INTERVAL] to no
3331 (config_write_bgp_dump): Write interval value to the
3334 1999-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3336 * bgp_zebra.c: Redistribute route-map support is added.
3338 * bgp_zebra.h: New file added.
3340 1999-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3342 * bgp_dump.c: BGP packet dump routine compatible with MRT.
3343 * bgp_dump.h: BGP packet dump routine compatible with MRT.
3345 * bgp_debug.c: Renamed from bgp_dump.c
3346 * bgp_debug.h: Renamed from bgp_dump.h
3348 1999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3350 * BGP4-MIB.txt: New file added. Edited version of RFC1657.
3352 1999-10-25 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3354 * bgp_route.c (bgp_announce): If we're not on a shared network
3355 with the peer and we don't have a link-local next hop, but the
3356 inbound next-hop has a link-local address, don't readvertise it to
3359 1999-10-25 Marc Boucher <marc@mbsi.ca>
3361 * bgp_zebra.c: Add redistribute kernel command.
3363 1999-10-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3365 * bgp_route.c (bgp_reset): New function added.
3367 * bgpd.conf.sample2: Add IPv6 configuration sample.
3369 1999-10-24 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3371 * bgp_route.c (ipv6_aggregate_address): Function added.
3373 1999-10-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3375 * bgp_packet.c (bgp_update): Unintern aspath, community, cluster
3376 list after parsing BGP update packet.
3378 * bgp_attr.c (bgp_attr_aspath): Intern parsed aspath.
3379 (bgp_attr_community): Intern parsed community.
3380 (bgp_attr_cluster_list): Intern parsed cluster list.
3382 * bgp_routemap.c: Add `set community-additive' command.
3384 1999-10-21 Alexandr D. Kanevskiy <kad@blackcatlinux.com>
3386 * bgp_routemap.c (route_set_local_pref): Fix bug of setting
3389 1999-10-21 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3391 * bgp_route.c (bgp_announce): Add check of IPv6 default route
3394 * bgp_packet.c (bgp_update_send): Add BGP announcement logging.
3396 1999-10-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3398 * `show ip[v6] bgp PREFIX' show uptime of the route.
3400 1999-10-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3402 * bgpd.c (bgp_filter_set): Delete PEER_FAMILY_{IPV4,IPV6}. instead
3403 of that use AF_INET and AF_INET6 directly.
3404 (vty_clear_bgp): Add new function to support various clear ip bgp
3407 1999-10-04 Lars Fenneberg <lf@elemental.net>
3409 * bgpd.c (clear_ip_bgp): Add `clear ip bgp ASN'.
3411 1999-10-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3413 * bgp_routemap.c: Add `match ip prefix-list' and `match ipv6
3416 1999-09-28 Kunihiro Ishiguro <kunihiro@zebra.org>
3418 * bgpd.c (bgp_collision_detect): Add BGP collision detection
3421 1999-09-26 Blake Meike <bmeike@adero.com>
3423 * bgpd.c (neighbor_port): New command `neighbor PEER port PORT' is
3426 1999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3428 * bgpd.c (no_neighbor_timers_keepalive): Change MIN to min. Add
3431 1999-08-19 Rick Payne <rickp@rossfell.co.uk>
3433 * bgp_packet.c (bgp_open): BGP holdtimer bug is fixed. Make BGP
3434 keepalive timer configurable.
3436 1999-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3438 * bgp_zebra.c (bgp_redistribute_set): Fix redistribute bug.
3440 1999-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3442 * bgpd.c (bgp_peer_display): show ip bgp neighbors PEER only list
3443 the peer not all of them.
3445 1999-08-11 Rick Payne <rickp@rossfell.co.uk>
3447 * bgp_route.c (bgp_announce): Remove MED if its an EBGP peer -
3448 will get overwritten by route-maps.
3450 1999-08-08 Rick Payne <rickp@rossfell.co.uk>
3452 * bgp_routemap.c: Multi protocol route-map modification.
3454 1999-08-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3456 * bgp_route.c: Set network statement route's origin attribute as
3459 * bgp_zebra.c: Set redistribute route's origin attribute as
3462 * bgp_route.c (bgp_info_cmp): Add attribute existance check,
3463 origin attribute check, BGP peer type check.
3465 1999-07-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3467 * bgp_route.c (bgp_peer_delete): Reselect of IPv6 route.
3469 1999-07-29 Rick Payne <rickp@rossfell.co.uk>
3471 * Changed route-maps to behave in a more cisco-like fashion
3473 1999-07-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3475 * bgp_fsm.c (bgp_stop): Very serious bug of bgp_stop () is fixed.
3476 When multiple route to the same destination exist, bgpd try to
3477 announce the information to stopped peer. Then add orphan write
3478 thread is added. This cause many strange behavior of bgpd.
3479 Reported by Georg Hitsch <georg@atnet.at>.
3481 1999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3483 * bgpd.c: Change peer's A.B.C.D to PEER.
3485 1999-07-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3487 * bgp_route.c (bgp_announce): Add hack for link-local nexthop.
3489 * bgp_zebra.c (bgp_zebra_announce): Fill in nexthop address from
3492 1999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3494 * bgp_packet.c (bgp_open): Holdtime fetch bug is fixed. Reported
3495 by Yuji SEKIYA <sekiya@sfc.wide.ad.jp>.
3497 1999-07-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3499 * bgp_fsm.c (fsm_holdtime): Don't close file descriptor in
3502 1999-07-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3504 * bgp_routemap.c: Add `set atomic-aggregate' command.
3506 1999-07-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3508 * bgp_routemap.c (route_set_ip_nexthop_cmd): Change "ip nexthop"
3511 1999-07-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3513 * bgp_route.c (show_ipv6_bgp_regexp): `show ipv6 bgp regexp'
3516 1999-07-01 Rick Payne <rickp@rossfell.co.uk>
3518 * bgp_zebra.c (zebra_init): Install standard commands to
3521 1999-06-28 Rick Payne <rickp@rossfell.co.uk>
3523 * bgpd.c (bgp_delete): bgp peer deletion bug is fixed.
3525 1999-06-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3527 * bgpd.c: Add neighbor update-source command as ALIAS to
3530 1999-06-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3532 * bgp_attr.c (bgp_packet_attribute): Send community attribute when
3533 send_community flag is set.
3535 * bgpd.h (struct peer): Add send_community flag.
3537 1999-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3539 * bgpd.c (router_bgp): router bgp's argument changed from AS_NO to
3542 1999-06-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3544 * bgp_route.h (struct bgp_info): Add subtype for BGP route type.
3546 1999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3548 * bgp_community.c (community_merge): Function added.
3550 1999-06-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3552 * bgp_clist.c: New file.
3553 * bgp_clist.h: New file.
3555 * bgp_community.h (COMMUNITY_LOCAL_AS): Added for Cisco
3557 (COMMUNITY_NO_ADVERTISE): Fix typo.
3559 1999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3561 * bgp_routemap.c: Add `set weight WEIGHT' command.
3563 * bgpd.c: Remove all_digit_check function. Instead of that use
3564 all_digit function in lib/prefix.c.
3566 * bgp_routemap.c (bgp_route_map_init): Install
3567 no_set_ipv6_nexthop_global_cmd and no_set_ipv6_nexthop_local_cmd
3568 element to the RMAP_NODE.
3570 1999-05-28 Kunihiro Ishiguro <kunihiro@zebra.org>
3572 * bgp_aspath.c (aspath_make_str): Declare aspath_delimiter_char
3573 inside aspath_make_str function.
3574 (aspath_prepend): New function is added for AS path prepend.
3575 (aspath_make_str_count): Renamed from aspath_make_str. AS path
3576 count is set to the structure.
3577 (aspath_merge): New function.
3579 1999-05-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3581 * bgp_zebra.c (redistribute_bgp): Add new DEFUN.
3582 (no_redistribute_bgp): Likewise.
3583 (router_zebra): Semantics changed. Now 'router zebra' is default
3586 1999-05-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3588 * bgp_routemap.c: Add some commands to bgp route-map.
3589 match ip next-hop: New command.
3590 match metric: New command.
3591 set metric: Doc fix.
3592 set local-preference: Add DEFUN.
3594 1999-05-14 Stephen R. van den Berg <srb@cuci.nl>
3596 * bgp_main.c (signal_init): SIGTERM call sigint.
3597 (sigint): Loggging more better message.
3599 1999-05-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3601 * bgp_attr.c (bgp_packet_attribute): AS path attribute extended
3602 length bit check is added.
3604 1999-05-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3606 * bgp_routemap.c (bgp_route_map_init): Call route_map_install_set
3607 function with route_set_local_pref_cmd argument.
3608 (no_match_aspath): Function added.
3609 (route_set_metric): Set attribute flag bit.
3611 * bgp_attr.c (bgp_packet_attribute): MULTI_EXIT_DISC is now in BGP
3614 1999-05-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3616 * bgpd.c (no_neighbor_timers_holdtime): `no neighbor PEER timers
3617 holdtime' command is added.
3619 * bgpd.h (BGP_DEFAULT_HOLDTIME_BIG): Delete define.
3621 * bgpd.c (bgp_prefix_list_set): New function added.
3622 (bgp_prefix_list_unset): Likewise.
3623 (bgp_prefix_list_update): Likewise.
3624 (show_ip_bgp_neighbors): prefix-list information display.
3626 1999-05-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3628 * bgpd.c (bgp_delete): Function added for `no router bgp'.
3630 1999-05-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3632 * bgp_dump.c (bgp_dump_attr): Add originator_id display.
3634 * bgpd.c (bgp_router_id): Even when address is malformed set the
3635 value to configuration bug fixed.
3636 (no_bgp_router_id): New function.
3637 (no_bgp_cluster_id): New function.
3639 1999-05-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3641 * bgpd.h (BGP_ATTR_ORIGINATOR_ID): Changed from BGP_ATTR_ORIGINATOR.
3643 1999-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3645 * bgp_route.c (bgp_announce): Add route reflector check.
3647 1999-05-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3649 * bgpd.c (bgp_cluster_id): Add function for route reflector.
3650 (neighbor_route_reflector_client): Likewise.
3651 (no_neighbor_route_reflector_client): Likewise.
3653 * bgpd.h (struct bgp ): Add cluster for route reflector.
3655 * bgp_route.c (show_ip_bgp_prefix_list): New command is added.
3657 1999-04-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3659 * Makefile.am (noinst_HEADERS): Add bgp_filter.h
3661 * bgp_aspath.c (aspath_undup): Function deleted. aspath_free ()
3662 has same functionality.
3664 * bgp_filter.h: New file.
3666 * bgp_aspath.c (aspath_unintern): Rename aspath_free () to
3668 (aspath_free): New function.
3670 1999-04-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3672 * bgp_aspath.c (aspath_aggregate): Function added.
3674 * bgp_aspath.h (aspath_aggregate): Prototype added.
3676 * bgp_aspath.c (aspath_empty_aspath): New argument
3677 gated_dont_eat_flag is added.
3679 1999-04-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3681 * bgp_route.c: Add bgp_aggregate_ipv4 and bgp_aggregate_ipv6.
3683 1999-04-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3685 * bgp_route.c (aggregate_address): Function added.
3687 * bgp_zebra.c (zebra_read): Change log to zlog.
3689 1999-04-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3691 * Makefile.am (noninst_HEADERS): Added for make dist.
3693 1999-04-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3695 * aspath_regex.c: Removed from distribution.
3697 1999-04-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3699 * bgp_attr.c (bgp_packet_attribute): Old draft-00 packet treatment
3702 1999-04-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3704 * bgp_aspath.c (aspath_add_left): Fix empty aspath bug. Reported
3705 by kad@gibson.skif.net.
3707 * bgp_regex.[ch]: New file added.
3710 1999-04-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3712 * bgp_filter.c: New file added.
3714 1999-04-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3716 * bgp_aspath.c (aspath_empty_aspath): Change for peering with
3719 1999-03-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3721 * bgp_main.c (main): Default loggin method changed from syslog to
3724 1999-03-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3726 * bgp_route.c: Delete obsolete default attribute DEFUN.
3728 1999-03-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3730 * bgp_attr.c: Make attribute structure put into attribute hash.
3732 1999-03-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3734 * bgp_view.c : Delete file.
3736 1999-02-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3738 * bgp_routemap.c (bgp_apply_route_map): Add prefix argument.
3740 * bgp_route.h (struct bgp_info): Add bgp_info structre. I'll
3741 replace bgp_route with this.
3743 * bgp_routemap.c (route_match_ip_address): Fix bug of passing non
3744 prefix value to access_list_apply().
3746 * bgpd.conf.sample: Add route-map sample.
3747 Delete obsolete default-attr statements.
3749 * bgp_packet.c: Use stream_fifo for packet queueing.
3751 1999-02-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3753 * bgp_aspath.c (aspath_add_left): add non empty aspath treatment.
3755 * bgp_main.c: include unistd.h for daemon().
3757 * bgp_route.c (nlri_process): add IPv6 table lookup.
3759 * bgp_attr.c (route_parse_ipv6): call nlri_process().
3760 (attr_make): Obsolete function attr_make deleted.
3762 1999-02-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3764 * bgp_aspath.c (aspath_add_left): change function name from
3765 aspath_add_leftmost_as().
3767 1999-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3769 * bgp_aspath.c: add aspath_add_leftmost_as ().
3771 1999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
3773 * syslog support added
3775 1999-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3777 * bgpd.c: DEFUN (neighbor_nexthop): deleted.
3778 DEFUN (neighbor_distribute_list): added.
3780 1999-01-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3782 * bgpd.h (struct peer ): header_buf and read_buf is removed.
3784 * bgp_peer.[ch]: Deleted. Peer related functions are merged to
3787 * bgp_network.c: New file.
3788 * bgp_network.h: New file.
3790 * bgp_packet.h: New file.
3792 1999-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3794 * bgp_packet.c (bgp_keepalive_send): Now BGP keepalive packet is
3797 1999-01-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3799 * bgp_packet.c: New file.
3801 1998-12-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3803 * bgp_zebra.c (zebra_client): Use zebra_connect() in lib/client.c.
3805 * `show ip bgp' bug fixed.
3806 * aspath_log (): Remove argument logfp.
3808 1998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3810 * bgp_fsm.h: New file.
3812 1998-12-15 Magnus Ahltorp <map@stacken.kth.se>
3814 * bgp_attr.c, bgp_community.h, bgp_dump.c, bgp_fsm.c, bgp_open.c
3815 bgp_peer.c, bgp_peer.h, bgp_route.c, bgp_route.h, bgp_view.c
3816 bgpd.c, bgpd.h, bgp_attr.c, bgp_community.h, bgp_dump.c,
3817 bgp_fsm.c, bgp_open.c, bgp_peer.c, bgp_peer.h: Prototype fixes.
3819 1998-12-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3821 * bgpd.c (bgp_config_write): Delete vector v argument.
3823 1998-12-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3825 * bgpd.h: Delete annoying ld_[124]byte and st_[124]byte macros.
3827 1998-11-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3829 * bgp_radix.[ch]: removed.
3831 1998-09-15 HEO SeonMeyong <seirios@matrix.iri.co.jp>
3833 * bgp_main.c: ifdef HYDRANGEA -> ifdef KAME
3835 1998-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3837 * bgp_dump.c: delete nroute().
3839 1998-05-19 Yamshita TAKAO <jargon@lares.dti.ne.jp>
3841 * bgp_aspath.c: HAVE_CONFIG_H typo :-)
3842 * bgpd.h: Modify for compile on Solaris.
3843 * bgp_aspath.h: likewize
3844 * bgp_community.h: likewize
3845 * bgp_routemap.c: likewize
3847 1998-05-18 Yamshita TAKAO <jargon@lares.dti.ne.jp>
3849 * bgpd.h: Modify for compile on Solaris.
3850 * bgp_aspath.h: likewize
3852 1998-05-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3854 * routemap.[ch]: move to ../lib directory.
3856 1998-05-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3858 * routemap.c (route_map_apply): add function.
3860 1998-05-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3862 * routemap.h: add file.
3864 * bgp_peer.h (enum ): change PEER_{IBGP,EBGP} to BGP_PEER_{IBGP,EBGP}
3866 1998-05-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3868 * Makefile.am: sysconfdir_DATA added.
3870 1998-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3872 * bgp_dump.c: add `debug bgp fsm'
3873 add `no debug bgp fsm'
3874 add `show debug bgp'
3875 * bgp_open.c: File added.
3877 1998-05-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3879 * .cvsignore: File added.
3881 1998-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3883 * bgp_community.[ch]: File added.
3885 1998-03-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3887 * bgpd now use lib/thread.[ch].
3889 1998-01-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3891 * bgpd.c (show_ip_bgp_neighbors): add 'show ip bgp neighbors' command.
3893 * bgpd.h (BGP_DEFAULT_START_TIMER): change from 1 to 30.
3895 1997-12-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3897 * bgp_vty.c: bgp_vty.c deleted.
3899 * bgpd.c (config_write_neighbor): add ebgp-multihop command.
3901 1997-12-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3903 * bgp_fsm.c: [-p bgp_port] and [-P vty_port] works
3905 1997-12-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3907 * bgp_vty.c: new file.
3909 * bgp_attr.c: add new logging system.
3911 1997-11-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3913 * Change all inet_addr call into inet_aton.
3915 1997-11-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3917 * bgp_radix.c: change radix_peer_delete
3919 1997-10-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3921 * bgp_aspath.c: move AS_TOKEN_??? definition from header to c source.
3923 1997-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3925 * bgp_dump.c (bgp_log_route): add dump_attr function
3927 1997-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3929 * bgp_aspath.c (aspath_test): change AS_SET brace from '[' to '{'
3930 * bgp_dump.c (bgp_log_route): change logfile format.
3932 1997-08-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3934 * bgp_open.c (bgp_open): move bgp_open function from bgpd.c
3935 * bgp_attr.c (community_str2com): add community value generation
3936 * bgp_attr.h: add SAFI definition for BGP-4+
3938 1997-08-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3940 * bgpd.h: add BGP_OPEN_OPT_CAP for Capabilities Optional Parameter
3941 * Makefile.in: add bgp_open.o, delete bgp_loop.o
3942 * bgp_open.c: newfile which manages BGP Open message
3943 * bgp_loop.c: this file is merged with bgp_fsm.c
3944 * bgp_radix.c (radix_add): radix_add() now return route_t instead
3946 (bgp_sim): now we can read update & withdraw from file
3947 * bgp_route.c: add route_free() call into route_parse etc.
3949 1997-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3951 * bgp_radix.c: Radix code is completely rewritten. It has better
3952 memory treatment than old one.
3954 1997-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3956 * bgp_route.c: route_alloc for route struct allocation statistics.
3957 * bgpd.c (bgp_make_update): now we cann announce MED attribute.
3958 * bgp_aspath.c (aspath_print_all): change aspath_print_all output
3961 1997-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3963 * bgp_term.c (term_parse): add command : show asstat, show ashash
3964 * bgp_aspath.c: aspath_cmp bug fix
3965 (aspath_print_all): add aspath_print_all ();
3966 * bgp_peer.h: delete rlist element from struct peer.
3968 1997-08-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3970 * bgp_aspath.c: completely rewritten.
3971 * bgp_aspath.h: completely rewritten.
3972 add AsPath, AsSegment structure
3973 add AS_SET treatment
3976 1997-08-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3978 * bgp_attr.h: add Attribute flags defines
3979 * bgp_route.c: delete rlist related functions
3980 * bgp_aspath.c (as_origin): add as_origin function
3981 (aspath_print): move from bgp_dump.c and add support of AS_SET
3982 change Hash related function names.
3984 1997-08-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3986 * bgp_aspath.h: add next entry, delete rlist entry from struct aspath
3988 1997-08-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3990 * bgp_aspath.c (as_sort): add function as_sort
3991 * bgp_aspath.h: add IBGP, EBGP