lib: assert if someone adds to nexthop list to nhg

If someone tries to add a nexthop with a list of nexthops
already attached to it, let's just assert. This standardizes
the API to say we assume this is an individual nexthop
you are appending to a group.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>

diff --git a/lib/nexthop_group.c b/lib/nexthop_group.c
index 0051cba62572f6bc9d6e45afb985b6339ae6ce94..d7aceb55b9781935fa6c7df2d78ccb78d86a5016 100644 (file)
--- a/lib/nexthop_group.c
+++ b/lib/nexthop_group.c
@@ -250,8 +250,7 @@ static void _nexthop_add_sorted(struct nexthop **head,
 {
        struct nexthop *position, *prev;
 
-       /* Ensure this gets set */
-       nexthop->next = NULL;
+       assert(!nexthop->next);
 
        for (position = *head, prev = NULL; position;
             prev = position, position = position->next) {
@@ -281,6 +280,8 @@ void nexthop_group_add_sorted(struct nexthop_group *nhg,
 {
        struct nexthop *tail;
 
+       assert(!nexthop->next);
+
        /* Try to just append to the end first;
         * trust the list is already sorted
         */