ospfd: fix clang-SA warning

Need to clear refresh_list before dropping the reference.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

diff --git a/ospfd/ospf_lsa.c b/ospfd/ospf_lsa.c
index e38193cffc8e19d1b148847c572945dd0a96b273..bf46d22031762a375253d6a84a368d8860faee89 100644 (file)
--- a/ospfd/ospf_lsa.c
+++ b/ospfd/ospf_lsa.c
@@ -3646,8 +3646,8 @@ void ospf_refresher_unregister_lsa(struct ospf *ospf, struct ospf_lsa *lsa)
                        list_delete(&refresh_list);
                        ospf->lsa_refresh_queue.qs[lsa->refresh_list] = NULL;
                }
-               ospf_lsa_unlock(&lsa); /* lsa_refresh_queue */
                lsa->refresh_list = -1;
+               ospf_lsa_unlock(&lsa); /* lsa_refresh_queue */
        }
 }