zebra: fix possible null dereference

Don't attempt to dereference `ifp` directly if it might be null: there
is a check right before this usage: `ifp ? ifp->info : NULL`.

In this context it should be safe to assume `ifp` is not NULL because
the only caller of this function checks that for this `ifindex`. For
consistency we'll check for null anyway in case this ever changes (and
with this the coverity scan warning gets silenced).

Found by Coverity Scan (CID 1519776)

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

diff --git a/zebra/interface.c b/zebra/interface.c
index 87bb49042a30ab0df66f682475dc4037240f3a6e..59563834ef9c64d2ec2035f9ad56c0d0febbfe62 100644 (file)
--- a/zebra/interface.c
+++ b/zebra/interface.c
@@ -1436,7 +1436,8 @@ static void zebra_if_netconf_update_ctx(struct zebra_dplane_ctx *ctx,
                        if (IS_ZEBRA_DEBUG_KERNEL)
                                zlog_debug(
                                        "%s: if %s(%u) zebra info pointer is NULL",
-                                       __func__, ifp->name, ifp->ifindex);
+                                       __func__, ifp ? ifp->name : "(null)",
+                                       ifp ? ifp->ifindex : ifindex);
                        return;
                }
                if (afi == AFI_IP) {