Add comments with warnings obtained on NetBSD/i386. Both are due to

size_t being used for streams.  Perhaps cast to unsigned long before
printf?  Surely that's big enough even if size_t could be larger in
theory.

(no changelog, since only comment changes)

diff --git a/bgpd/bgp_attr.c b/bgpd/bgp_attr.c
index 44c858506048ff428d0801d888b9e1675712d0f3..8ffcfdd08cc502636068c95993b1e63b3866ad5b 100644 (file)
--- a/bgpd/bgp_attr.c
+++ b/bgpd/bgp_attr.c
@@ -1166,6 +1166,7 @@ bgp_attr_parse (struct peer *peer, struct attr *attr, bgp_size_t size,
       /* Check remaining length check.*/
       if (endp - BGP_INPUT_PNT (peer) < BGP_ATTR_MIN_LEN)
        {
+         /* XXX warning: long int format, int arg (arg 5) */
          zlog (peer->log, LOG_WARNING, 
                "%s error BGP attribute length %ld is smaller than min len",
                peer->host, endp - STREAM_PNT (BGP_INPUT (peer)));

diff --git a/bgpd/bgpd.c b/bgpd/bgpd.c
index 26c4455355dc539fd15c06268f0584b6ff9bf93e..bd2f998fca0b1949698710ac84e30ff30c3195e0 100644 (file)
--- a/bgpd/bgpd.c
+++ b/bgpd/bgpd.c
@@ -4122,6 +4122,7 @@ peer_uptime (time_t uptime2, char *buf, size_t len)
   /* Check buffer length. */
   if (len < BGP_UPTIME_LEN)
     {
+      /* XXX: warning: long int format, size_t arg (arg 2) */
       zlog_warn ("peer_uptime (): buffer shortage %ld", len);
       /* XXX: should return status instead of buf... */
       snprintf (buf, len, "<error> ");