]> git.proxmox.com Git - mirror_frr.git/commitdiff
pbrd: nexthop_group delete cb don't free pbr->nhg
authorStephen Worley <sworley@cumulusnetworks.com>
Fri, 4 Oct 2019 17:54:39 +0000 (13:54 -0400)
committerStephen Worley <sworley@cumulusnetworks.com>
Fri, 25 Oct 2019 15:13:43 +0000 (11:13 -0400)
The pbr->nhg callback is used exclusively for individual nexthops
set through `set nexthop`. If an actuall "tracked" nexthop_group is
used, only the `pbrms->nhgrp_name` is set. Thus this delete does
nothing.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
pbrd/pbr_nht.c

index 67a1fe2ffe86d386572e5c4686578c5f3eaf0d86..062cfd0158b6b4b9abf502e1474c2b8d7d966c83 100644 (file)
@@ -639,7 +639,6 @@ void pbr_nht_delete_group(const char *name)
                        if (pbrms->nhgrp_name
                            && strmatch(pbrms->nhgrp_name, name)) {
                                pbrms->reason |= PBR_MAP_INVALID_NO_NEXTHOPS;
-                               nexthop_group_delete(&pbrms->nhg);
                                pbrms->nhg = NULL;
                                pbrms->internal_nhg_name = NULL;
                                pbrm->valid = false;