]> git.proxmox.com Git - mirror_ifupdown2.git/commitdiff
addons: bridge: get default mcsnoop value when bridge_vxlan is not set
authorJulien Fortin <julien@cumulusnetworks.com>
Wed, 13 Mar 2019 07:23:54 +0000 (15:23 +0800)
committerJulien Fortin <julien@cumulusnetworks.com>
Mon, 22 Apr 2019 02:55:09 +0000 (10:55 +0800)
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
ifupdown2/addons/bridge.py

index 9677b3bc1d2d08561bbec3206561daf0bb8ffa7b..ad6b7634224f94a41f101f4876972a36ec70bbc7 100644 (file)
@@ -1230,9 +1230,15 @@ class bridge(moduleBase):
 
     def get_bridge_mcsnoop_value(self, ifaceobj):
         mcsnoop = ifaceobj.get_attr_value_first('bridge-mcsnoop')
-        if not mcsnoop and ifaceobj.link_privflags & ifaceLinkPrivFlags.BRIDGE_VXLAN:
-            return self._vxlan_bridge_default_igmp_snooping
-        return mcsnoop
+
+        if mcsnoop:
+            return mcsnoop
+
+        if ifaceobj.link_privflags & ifaceLinkPrivFlags.BRIDGE_VXLAN:
+            if self._vxlan_bridge_default_igmp_snooping is not None:
+                return self._vxlan_bridge_default_igmp_snooping
+
+        return self.get_attr_default_value("bridge-mcsnoop")
 
     def fill_ifla_info_data_with_ifla_br_attribute(self,
                                                    ifla_info_data,