]> git.proxmox.com Git - mirror_iproute2.git/commitdiff
bridge: fix string length warning
authorStephen Hemminger <stephen@networkplumber.org>
Sun, 29 Nov 2020 17:32:50 +0000 (09:32 -0800)
committerStephen Hemminger <stephen@networkplumber.org>
Mon, 30 Nov 2020 00:20:16 +0000 (16:20 -0800)
Gcc-10 complains about possible string length overflow.
This can't happen Ethernet address format is always limited to
18 characters or less. Just resize the temp buffer.

Fixes: 70dfb0b8836d ("iplink: bridge: export bridge_id and designated_root")
Cc: nikolay@cumulusnetworks.com
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
ip/iplink_bridge.c

index 3e81aa059cb39b8701c2dba7e9f5a8f9c3b4a94f..d12fd0558f7db00eac40a455bd5e736b13158c75 100644 (file)
@@ -74,7 +74,7 @@ static void explain(void)
 
 void br_dump_bridge_id(const struct ifla_bridge_id *id, char *buf, size_t len)
 {
-       char eaddr[32];
+       char eaddr[18];
 
        ether_ntoa_r((const struct ether_addr *)id->addr, eaddr);
        snprintf(buf, len, "%.2x%.2x.%s", id->prio[0], id->prio[1], eaddr);