]> git.proxmox.com Git - mirror_iproute2.git/commitdiff
tc: fix xtables incorrect usage of LDFLAGS
authorSyrone Wong <wong.syrone@gmail.com>
Wed, 12 Dec 2018 11:35:08 +0000 (19:35 +0800)
committerStephen Hemminger <stephen@networkplumber.org>
Thu, 13 Dec 2018 19:38:43 +0000 (11:38 -0800)
The incorrect setting of LDFLAGS causes error below:

> em_ipt.o: In function `em_ipt_print_epot':
> em_ipt.c:(.text.em_ipt_print_epot+0x2e): undefined reference to
> `xtables_init_all'

em_ipt.c gets involved when TC_CONFIG_XT=y, which requires xtables,
while tc/Makefile doesn't pass flags correctly. It adds '-lxtables'
to LDFLAGS instead of LDLIBS.

Fixes: dd296215 ("tc: add em_ipt ematch for calling xtables matches from tc matching context")
Signed-off-by: Syrone Wong <wong.syrone@gmail.com>
Acked-by: Eyal Birger <eyal.birger@gmail.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
tc/Makefile

index f8010d3c0ba1e864538152c3236b4557b3a4b347..2edaf2c8836475c78e713e789a05203e1c598327 100644 (file)
@@ -171,7 +171,7 @@ em_ipset.o: CFLAGS += $$($(PKG_CONFIG) xtables --cflags)
 em_ipt.o: CFLAGS += $$($(PKG_CONFIG) xtables --cflags)
 
 ifeq ($(TC_CONFIG_XT),y)
-  LDFLAGS += $$($(PKG_CONFIG) xtables --libs)
+  LDLIBS += $$($(PKG_CONFIG) xtables --libs)
 endif
 
 %.yacc.c: %.y