]> git.proxmox.com Git - mirror_iproute2.git/commitdiff
devlink: fix warning from unchecked write
authorStephen Hemminger <stephen@networkplumber.org>
Sun, 2 Feb 2020 12:20:58 +0000 (04:20 -0800)
committerStephen Hemminger <stephen@networkplumber.org>
Sun, 2 Feb 2020 12:20:58 +0000 (04:20 -0800)
Warning seen on Ubuntu

devlink.c: In function ‘cmd_dev_flash’:
devlink.c:3071:3: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result]
 3071 |   write(pipe_w, &err, sizeof(err));
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 9b13cddfe268 ("devlink: implement flash status monitoring")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
devlink/devlink.c

index 73ce98654fd8cd42452e7969dae7d24866069de9..f9e58c1d73947c117052c937df6f0a0d790d0197 100644 (file)
@@ -3066,11 +3066,13 @@ static int cmd_dev_flash(struct dl *dl)
                /* In child, just execute the flash and pass returned
                 * value through pipe once it is done.
                 */
+               int cc;
+
                close(pipe_r);
                err = _mnlg_socket_send(dl->nlg, nlh);
-               write(pipe_w, &err, sizeof(err));
+               cc = write(pipe_w, &err, sizeof(err));
                close(pipe_w);
-               exit(0);
+               exit(cc != sizeof(err));
        }
        close(pipe_w);