]> git.proxmox.com Git - mirror_iproute2.git/commitdiff
devlink: Show external port attribute
authorParav Pandit <parav@nvidia.com>
Fri, 18 Sep 2020 10:16:48 +0000 (13:16 +0300)
committerDavid Ahern <dsahern@gmail.com>
Wed, 23 Sep 2020 02:13:04 +0000 (20:13 -0600)
If a port is for an external controller, port's external attribute is
set. Show such external attribute.

An example of an external controller port for PCI VF:

$ devlink port show pci/0000:06:00.0/2
pci/0000:06:00.0/2: type eth netdev ens2f0c1pf0vf1 flavour pcivf pfnum 0 vfnum 1 external true splittable false
  function:
    hw_addr 00:00:00:00:00:00

$ devlink port show pci/0000:06:00.0/2 -jp
{
    "port": {
        "pci/0000:06:00.0/2": {
            "type": "eth",
            "netdev": "ens2f0c1pf0vf1",
            "flavour": "pcivf",
            "pfnum": 0,
            "vfnum": 1,
            "external": true,
            "splittable": false,
            "function": {
                "hw_addr": "00:00:00:00:00:00"
            }
        }
    }
}

Signed-off-by: Parav Pandit <parav@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: David Ahern <dsahern@gmail.com>
devlink/devlink.c

index 007677a5c5648c6fc98fcfd2d616e1732318ba51..9f99c0319605c6b95a1e89d89f681a3495b4547e 100644 (file)
@@ -3351,6 +3351,12 @@ static void pr_out_port_pfvf_num(struct dl *dl, struct nlattr **tb)
                fn_num = mnl_attr_get_u16(tb[DEVLINK_ATTR_PORT_PCI_VF_NUMBER]);
                print_uint(PRINT_ANY, "vfnum", " vfnum %u", fn_num);
        }
+       if (tb[DEVLINK_ATTR_PORT_EXTERNAL]) {
+               uint8_t external;
+
+               external = mnl_attr_get_u8(tb[DEVLINK_ATTR_PORT_EXTERNAL]);
+               print_bool(PRINT_ANY, "external", " external %s", external);
+       }
 }
 
 static void pr_out_port_function(struct dl *dl, struct nlattr **tb_port)