Process pull requets directly from mbox

Rather than letting b4 fetch a second time use the same one
that was already downloaded.

Signed-off-by: Mario Limonciello <superm1@gmail.com>

diff --git a/contrib/process_linux_firmware.py b/contrib/process_linux_firmware.py
index 7d867a8d8fe3e7aef57cd31398d5b880aa8e6f63..b1d9822216501d0b4b02f7c2369554e89c4915c6 100755 (executable)
--- a/contrib/process_linux_firmware.py
+++ b/contrib/process_linux_firmware.py
@@ -142,14 +142,15 @@ def delete_branch(branch):
     quiet_cmd(["git", "branch", "-D", branch])
 
 
-def process_pr(url, num, remote):
+def process_pr(mbox, num, remote):
     branch = "robot/pr-{}-{}".format(num, int(time.time()))
-    cmd = ["b4", "pr", "-b", branch, url]
-    try:
-        quiet_cmd(cmd)
-    except subprocess.CalledProcessError:
-        logging.warning("Failed to apply PR")
-        return None
+
+    cmd = ["b4", "--debug", "pr", "-b", branch, "-"]
+    logging.debug("Running {}".format(cmd))
+    p = subprocess.Popen(
+        cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE
+    )
+    stdout, stderr = p.communicate(mbox.encode("utf-8"))
 
     # determine if it worked (we can't tell unfortunately by return code)
     cmd = ["git", "branch", "--list", branch]
@@ -244,7 +245,6 @@ def process_database(conn, remote):
 
     # loop over all unprocessed urls
     for row in rows:
-
         branch = None
         msg = "Processing ({}%)".format(round(num / len(rows) * 100))
         print(msg, end="\r", flush=True)
@@ -260,7 +260,7 @@ def process_database(conn, remote):
 
         if classification == ContentType.PULL_REQUEST:
             logging.debug("Processing PR ({})".format(row[0]))
-            branch = process_pr(row[0], num, remote)
+            branch = process_pr(mbox, num, remote)
 
         if classification == ContentType.SPAM:
             logging.debug("Marking spam ({})".format(row[0]))