]> git.proxmox.com Git - mirror_lxc.git/commitdiff
conf: do lxc.mount.entry mounts right after lxc.mount.fstab
authorFelix Abecassis <fabecassis@nvidia.com>
Tue, 16 Apr 2019 21:40:03 +0000 (14:40 -0700)
committerFelix Abecassis <fabecassis@nvidia.com>
Tue, 16 Apr 2019 21:40:34 +0000 (14:40 -0700)
These configuration options use the same syntax and therefore it seems
more intuitive to have the same behavior for both of them, which is
not the case today since mount hooks and autodev mounts are called
between the two.

See: https://github.com/lxc/lxc/issues/2932

Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
src/lxc/conf.c

index 5d381b7137469fd11d1f4d40c554a4c592f54a75..986cb89b024bf6bbeedc84a75a36460eda497e98 100644 (file)
@@ -3546,6 +3546,15 @@ int lxc_setup(struct lxc_handler *handler)
                return -1;
        }
 
+       if (!lxc_list_empty(&lxc_conf->mount_list)) {
+               ret = setup_mount_entries(lxc_conf, &lxc_conf->rootfs,
+                                         &lxc_conf->mount_list, name, lxcpath);
+               if (ret < 0) {
+                       ERROR("Failed to setup mount entries");
+                       return -1;
+               }
+       }
+
        if (lxc_conf->is_execute) {
                if (execveat_supported()) {
                        int fd;
@@ -3604,15 +3613,6 @@ int lxc_setup(struct lxc_handler *handler)
                }
        }
 
-       if (!lxc_list_empty(&lxc_conf->mount_list)) {
-               ret = setup_mount_entries(lxc_conf, &lxc_conf->rootfs,
-                                         &lxc_conf->mount_list, name, lxcpath);
-               if (ret < 0) {
-                       ERROR("Failed to setup mount entries");
-                       return -1;
-               }
-       }
-
        /* Make sure any start hooks are in the container */
        if (!verify_start_hooks(lxc_conf)) {
                ERROR("Failed to verify start hooks");