datapath-windows: Fix possible NULL dereference in IpFragment

If we can't allocate the NBL just go to the cleanup sequence.

Found using WDK 10 static code analysis.

Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
Acked-by: Shashank Ram <shashank08@gmail.com>

diff --git a/datapath-windows/ovsext/IpFragment.c b/datapath-windows/ovsext/IpFragment.c
index ad48834a6674dc417049019b091dc97c6889b95a..3d5277ac45b796516e8d8bc1c98d27a5b5e3c433 100644 (file)
--- a/datapath-windows/ovsext/IpFragment.c
+++ b/datapath-windows/ovsext/IpFragment.c
@@ -206,6 +206,7 @@ OvsIpv4Reassemble(POVS_SWITCH_CONTEXT switchContext,
     if (*newNbl == NULL) {
         OVS_LOG_ERROR("Insufficient resources, failed to allocate newNbl");
         status = NDIS_STATUS_RESOURCES;
+        goto cleanup;
     }
 
     /* Complete the fragment NBL */