]> git.proxmox.com Git - mirror_qemu.git/commit
pc-dimm: factor out MemoryDevice interface
authorDavid Hildenbrand <david@redhat.com>
Mon, 23 Apr 2018 16:51:16 +0000 (18:51 +0200)
committerEduardo Habkost <ehabkost@redhat.com>
Mon, 7 May 2018 13:00:02 +0000 (10:00 -0300)
commit2cc0e2e8140f43ccc6aced6e47c9c2db15ce2330
tree8212dcea68c4b32da42fd918e93e4a084106f49b
parentc8b7e627b4269a3bc3ae41d9f420547a47e6d9b9
pc-dimm: factor out MemoryDevice interface

On the qmp level, we already have the concept of memory devices:
    "query-memory-devices"
Right now, we only support NVDIMM and PCDIMM.

We want to map other devices later into the address space of the guest.
Such device could e.g. be virtio devices. These devices will have a
guest memory range assigned but won't be exposed via e.g. ACPI. We want
to make them look like memory device, but not glued to pc-dimm.

Especially, it will not always be possible to have TYPE_PC_DIMM as a parent
class (e.g. virtio devices). Let's use an interface instead. As a first
part, convert handling of
- qmp_pc_dimm_device_list
- get_plugged_memory_size
to our new model. plug/unplug stuff etc. will follow later.

A memory device will have to provide the following functions:
- get_addr(): Necessary, as the property "addr" can e.g. not be used for
              virtio devices (already defined).
- get_plugged_size(): The amount this device offers to the guest as of
                      now.
- get_region_size(): Because this can later on be bigger than the
                     plugged size.
- fill_device_info(): Fill MemoryDeviceInfo, e.g. for qmp.

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20180423165126.15441-2-david@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
13 files changed:
hw/i386/acpi-build.c
hw/mem/Makefile.objs
hw/mem/memory-device.c [new file with mode: 0644]
hw/mem/pc-dimm.c
hw/ppc/spapr.c
hw/ppc/spapr_hcall.c
include/hw/mem/memory-device.h [new file with mode: 0644]
include/hw/mem/pc-dimm.h
numa.c
qmp.c
stubs/Makefile.objs
stubs/qmp_memory_device.c [new file with mode: 0644]
stubs/qmp_pc_dimm.c [deleted file]