]> git.proxmox.com Git - mirror_qemu.git/commitdiff
qdev: Fix device_add DRIVER,help to print to monitor
authorMarkus Armbruster <armbru@redhat.com>
Tue, 14 Jul 2020 16:01:58 +0000 (18:01 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Tue, 21 Jul 2020 15:22:44 +0000 (17:22 +0200)
Help on device properties gets printed to stdout instead of the
monitor.  If you have the monitor anywhere else, no help for you.
Broken when commit e1043d674d "qdev: use object_property_help()"
accidentally switched from qemu_printf() to printf().  Switch right
back.

Fixes: e1043d674d792ff64aebae1a3eafc08b38a8a085
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200714160202.3121879-2-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
qdev-monitor.c

index 71ebce19df12b44cf98112eec9576f8ae46e57ef..e9b7228480ddba2b9d4c393b7a9d02ff86687be3 100644 (file)
@@ -300,7 +300,7 @@ int qdev_device_help(QemuOpts *opts)
     }
     g_ptr_array_sort(array, (GCompareFunc)qemu_pstrcmp0);
     for (i = 0; i < array->len; i++) {
-        printf("%s\n", (char *)array->pdata[i]);
+        qemu_printf("%s\n", (char *)array->pdata[i]);
     }
     g_ptr_array_set_free_func(array, g_free);
     g_ptr_array_free(array, true);