]> git.proxmox.com Git - mirror_qemu.git/commitdiff
qemu-char, io: fix ordering of arguments for UDP socket creation
authorPaolo Bonzini <pbonzini@redhat.com>
Tue, 9 Feb 2016 10:59:15 +0000 (11:59 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 9 Feb 2016 16:09:15 +0000 (17:09 +0100)
Two wrongs make a right, but they should be fixed anyway.

Cc: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <1455015557-15106-1-git-send-email-pbonzini@redhat.com>

io/channel-socket.c
qemu-char.c

index 22d2fd67d4cf0c4180d8005d426fd7e5cc676262..bf66a78235e78c5b95d4b104196fd28222f2cafd 100644 (file)
@@ -258,7 +258,7 @@ int qio_channel_socket_dgram_sync(QIOChannelSocket *ioc,
     int fd;
 
     trace_qio_channel_socket_dgram_sync(ioc, localAddr, remoteAddr);
-    fd = socket_dgram(localAddr, remoteAddr, errp);
+    fd = socket_dgram(remoteAddr, localAddr, errp);
     if (fd < 0) {
         trace_qio_channel_socket_dgram_fail(ioc);
         return -1;
index 84eb8a1fb454a6d38ab6d8bae683c8f16cffa4c3..2b2c56b87f6ff2ce2fc7653c7d3ffde72fe42897 100644 (file)
@@ -4386,7 +4386,7 @@ static CharDriverState *qmp_chardev_open_udp(const char *id,
     QIOChannelSocket *sioc = qio_channel_socket_new();
 
     if (qio_channel_socket_dgram_sync(sioc,
-                                      udp->remote, udp->local,
+                                      udp->local, udp->remote,
                                       errp) < 0) {
         object_unref(OBJECT(sioc));
         return NULL;