]> git.proxmox.com Git - mirror_qemu.git/commitdiff
tests/docker/Makefile.include: handle empty TARGET_LIST
authorAlex Bennée <alex.bennee@linaro.org>
Mon, 21 May 2018 10:35:04 +0000 (11:35 +0100)
committerFam Zheng <famz@redhat.com>
Mon, 4 Jun 2018 06:39:18 +0000 (14:39 +0800)
If the user doesn't specify a TARGET_LIST they get the current
configuration but with spaces and hilarity ensues. This adds some make
magic to turn the TARGET_LIST back into a comma separated list.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20180521103504.26432-1-alex.bennee@linaro.org>
Signed-off-by: Fam Zheng <famz@redhat.com>
rules.mak
tests/docker/Makefile.include

index 04c7f74d0786f5df332f8b2c38bc04d49ce6c2bd..bbb2667928eff107fba7fb96216311fd8ff49498 100644 (file)
--- a/rules.mak
+++ b/rules.mak
@@ -1,4 +1,7 @@
 
+# These are used when we want to do substitutions without confusing Make
+NULL  :=
+SPACE := $(NULL) #
 COMMA := ,
 
 # Don't use implicit rules or variables
index 31f21a43f5def4c76757920c104deb3139cdf9df..9d5749887a90f8e37d9077e88388307409e0b8f5 100644 (file)
@@ -140,7 +140,7 @@ docker-run: docker-qemu-src
                        $(if $V,,--rm)                                  \
                        $(if $(DEBUG),-ti,)                             \
                        $(if $(NETWORK),$(if $(subst $(NETWORK),,1),--net=$(NETWORK)),--net=none) \
-                       -e TARGET_LIST=$(TARGET_LIST)                   \
+                       -e TARGET_LIST=$(subst $(SPACE),$(COMMA),$(TARGET_LIST))        \
                        -e EXTRA_CONFIGURE_OPTS="$(EXTRA_CONFIGURE_OPTS)" \
                        -e V=$V -e J=$J -e DEBUG=$(DEBUG)               \
                        -e SHOW_ENV=$(SHOW_ENV)                         \