]> git.proxmox.com Git - mirror_qemu.git/commitdiff
checkpatch: Add xendevicemodel_handle to the list of types
authorIan Jackson <ian.jackson@eu.citrix.com>
Thu, 8 Mar 2018 18:07:26 +0000 (18:07 +0000)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Thu, 26 Apr 2018 15:29:50 +0000 (16:29 +0100)
This avoids checkpatch misparsing (as statements) long function
definitions or declarations, which sometimes start with constructs
like this:

  static inline int xendevicemodel_relocate_memory(
      xendevicemodel_handle *dmod, domid_t domid, ...

The type xendevicemodel_handle does not conform to Qemu CODING_STYLE,
which would suggest CamelCase.  However, it is a type defined by the
Xen Project in xen.git.  It would be possible to introduce a typedef
to allow the qemu code to refer to it by a differently-spelled name,
but that would obfuscate more than it would clarify.

CC: Eric Blake <eblake@redhat.com>
CC: Paolo Bonzini <pbonzini@redhat.com>
CC: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
scripts/checkpatch.pl

index d52207a3cc9d813925712cd066422482a8236e68..5b8735defb4d93fda3f7d7eaf873fcc4f02544c0 100755 (executable)
@@ -266,6 +266,7 @@ our @typeList = (
        qr{target_(?:u)?long},
        qr{hwaddr},
        qr{xml${Ident}},
+       qr{xendevicemodel_handle},
 );
 
 # This can be modified by sub possible.  Since it can be empty, be careful