]> git.proxmox.com Git - mirror_qemu.git/commitdiff
accel/kvm: ensure ret always set
authorAlex Bennée <alex.bennee@linaro.org>
Wed, 2 Oct 2019 10:22:12 +0000 (11:22 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 3 Oct 2019 10:48:42 +0000 (12:48 +0200)
Some of the cross compilers rightly complain there are cases where ret
may not be set. 0 seems to be the reasonable default unless particular
slot explicitly returns -1.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
accel/kvm/kvm-all.c

index aabe097c410fdfb76d94218c6099935b800c7c5a..d2d96d73e850cf389cdf1ae2bef3e441c29d8f05 100644 (file)
@@ -712,11 +712,11 @@ static int kvm_physical_log_clear(KVMMemoryListener *kml,
     KVMState *s = kvm_state;
     uint64_t start, size, offset, count;
     KVMSlot *mem;
-    int ret, i;
+    int ret = 0, i;
 
     if (!s->manual_dirty_log_protect) {
         /* No need to do explicit clear */
-        return 0;
+        return ret;
     }
 
     start = section->offset_within_address_space;
@@ -724,7 +724,7 @@ static int kvm_physical_log_clear(KVMMemoryListener *kml,
 
     if (!size) {
         /* Nothing more we can do... */
-        return 0;
+        return ret;
     }
 
     kvm_slots_lock(kml);