]> git.proxmox.com Git - mirror_qemu.git/commitdiff
Remove useless NULL checks for qemu_malloc return value
authorBlue Swirl <blauwirbel@gmail.com>
Thu, 19 Aug 2010 20:24:39 +0000 (20:24 +0000)
committerBlue Swirl <blauwirbel@gmail.com>
Thu, 19 Aug 2010 20:24:39 +0000 (20:24 +0000)
Found with this Coccinelle semantic patch:
@@
expression E;
identifier ptr;
identifier fn ~= "qemu_mallocz*";
@@

-ptr = fn(E);
-if (ptr == NULL) { ... }
-
+ptr = fn(E);

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
vl.c

diff --git a/vl.c b/vl.c
index b3e3676351f4a88af497f77f10d7bc189fc176c5..ccc8d573db6813403e0aea89d4305dc5a4c3e5c4 100644 (file)
--- a/vl.c
+++ b/vl.c
@@ -2316,12 +2316,6 @@ int main(int argc, char **argv, char **envp)
                 len += strlen(qemu_opt_get(opts, "security_model"));
                 arg_fsdev = qemu_malloc((len + 1) * sizeof(*arg_fsdev));
 
-                if (!arg_fsdev) {
-                    fprintf(stderr, "No memory to parse -fsdev for %s\n",
-                            optarg);
-                    exit(1);
-                }
-
                 sprintf(arg_fsdev, "%s,id=%s,path=%s,security_model=%s",
                                 qemu_opt_get(opts, "fstype"),
                                 qemu_opt_get(opts, "mount_tag"),
@@ -2332,12 +2326,6 @@ int main(int argc, char **argv, char **envp)
                 len += 2*strlen(qemu_opt_get(opts, "mount_tag"));
                 arg_9p = qemu_malloc((len + 1) * sizeof(*arg_9p));
 
-                if (!arg_9p) {
-                    fprintf(stderr, "No memory to parse -device for %s\n",
-                            optarg);
-                    exit(1);
-                }
-
                 sprintf(arg_9p, "virtio-9p-pci,fsdev=%s,mount_tag=%s",
                                 qemu_opt_get(opts, "mount_tag"),
                                 qemu_opt_get(opts, "mount_tag"));