]> git.proxmox.com Git - mirror_qemu.git/commitdiff
migration/multifd: not use multifd during postcopy
authorWei Yang <richardw.yang@linux.intel.com>
Fri, 25 Oct 2019 23:20:00 +0000 (07:20 +0800)
committerJuan Quintela <quintela@redhat.com>
Mon, 20 Jan 2020 08:10:23 +0000 (09:10 +0100)
We don't support multifd during postcopy, but user still could enable
both multifd and postcopy. This leads to migration failure.

Skip multifd during postcopy.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
migration/ram.c

index a05448c0c939bf0dce8b1a5f8b84f691461b2f8d..d4f33a4f2fd4a0bb4fdc98d97d9e4b75edccfc35 100644 (file)
@@ -2587,10 +2587,13 @@ static int ram_save_target_page(RAMState *rs, PageSearchStatus *pss,
     }
 
     /*
-     * do not use multifd for compression as the first page in the new
-     * block should be posted out before sending the compressed page
+     * Do not use multifd for:
+     * 1. Compression as the first page in the new block should be posted out
+     *    before sending the compressed page
+     * 2. In postcopy as one whole host page should be placed
      */
-    if (!save_page_use_compression(rs) && migrate_use_multifd()) {
+    if (!save_page_use_compression(rs) && migrate_use_multifd()
+        && !migration_in_postcopy()) {
         return ram_save_multifd_page(rs, block, offset);
     }