]> git.proxmox.com Git - mirror_qemu.git/commitdiff
osdep: Retry SETLK upon EINTR
authorFam Zheng <famz@redhat.com>
Tue, 26 Dec 2017 06:53:00 +0000 (14:53 +0800)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 29 Jan 2018 15:14:03 +0000 (09:14 -0600)
We could hit lock failure if there is a signal that makes fcntl return
-1 and errno set to EINTR. In this case we should retry.

Cc: qemu-stable@nongnu.org
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit f86428a1f4f91a460ed585682af70d3e8c31dc06)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
util/osdep.c

index 1231f9f8768cc817ef3bee406ef25b0f517ba23e..a73de0e1ba0d126481e980e0d3039d347dd24f86 100644 (file)
@@ -244,7 +244,9 @@ static int qemu_lock_fcntl(int fd, int64_t start, int64_t len, int fl_type)
         .l_type   = fl_type,
     };
     qemu_probe_lock_ops();
-    ret = fcntl(fd, fcntl_op_setlk, &fl);
+    do {
+        ret = fcntl(fd, fcntl_op_setlk, &fl);
+    } while (ret == -1 && errno == EINTR);
     return ret == -1 ? -errno : 0;
 }