]> git.proxmox.com Git - mirror_qemu.git/commitdiff
s390-ccw: Fix alignment for CCW1
authorFarhan Ali <alifm@linux.vnet.ibm.com>
Fri, 25 Aug 2017 13:24:46 +0000 (09:24 -0400)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Thu, 31 Aug 2017 17:01:54 +0000 (12:01 -0500)
The commit 198c0d1f9df8c4 s390x/css: check ccw address validity
exposes an alignment issue in ccw bios.

According to PoP the CCW must be doubleword aligned. Let's fix
this in the bios.

Cc: qemu-stable@nongnu.org
Signed-off-by: Farhan Ali <alifm@linux.vnet.ibm.com>
Reviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com>
Reviewed-by: Eric Farman <farman@linux.vnet.ibm.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Message-Id: <3ed8b810b6592daee6a775037ce21f850e40647d.1503667215.git.alifm@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
(cherry picked from commit 3a1e4561ad63b303b092387ae006bd41468ece63)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
pc-bios/s390-ccw/cio.h

index f5b4549ea3d86f16a7f2e0b850cba25d452f4693..55eaeee4b6a0625a6f3f4a4bdc9bc03f4a7c863a 100644 (file)
@@ -133,7 +133,7 @@ struct ccw1 {
     __u8 flags;
     __u16 count;
     __u32 cda;
-} __attribute__ ((packed));
+} __attribute__ ((packed, aligned(8)));
 
 #define CCW_FLAG_DC              0x80
 #define CCW_FLAG_CC              0x40