]> git.proxmox.com Git - mirror_qemu.git/commitdiff
qapi: better document NVMe blockdev @device parameter
authorDaniel P. Berrangé <berrange@redhat.com>
Fri, 6 Dec 2019 14:38:11 +0000 (14:38 +0000)
committerKevin Wolf <kwolf@redhat.com>
Wed, 18 Dec 2019 10:20:57 +0000 (11:20 +0100)
Mention that this is a PCI device address & give the format it is
expected in. Also mention that it must be first unbound from any
host kernel driver.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
qapi/block-core.json

index 0cf68fea1450e6cb739863d2367ce03ee95d58a5..fcb52ec24f3fc69afdd7005061db9bec2bfed550 100644 (file)
 #
 # Driver specific block device options for the NVMe backend.
 #
-# @device:    controller address of the NVMe device.
+# @device:    PCI controller address of the NVMe device in
+#             format hhhh:bb:ss.f (host:bus:slot.function)
 # @namespace: namespace number of the device, starting from 1.
 #
+# Note that the PCI @device must have been unbound from any host
+# kernel driver before instructing QEMU to add the blockdev.
+#
 # Since: 2.12
 ##
 { 'struct': 'BlockdevOptionsNVMe',