]> git.proxmox.com Git - mirror_spl-debian.git/blobdiff - module/spl/spl-kstat.c
New upstream version 0.7.8
[mirror_spl-debian.git] / module / spl / spl-kstat.c
index e306915a67772e9c49ef6ecb0f16547302312a56..6970fcc8a84b5c77a010b0a984dbb9c57ef23bfa 100644 (file)
@@ -20,7 +20,7 @@
  *
  *  You should have received a copy of the GNU General Public License along
  *  with the SPL.  If not, see <http://www.gnu.org/licenses/>.
- *****************************************************************************
+ *
  *  Solaris Porting Layer (SPL) Kstat Implementation.
 \*****************************************************************************/
 
@@ -30,7 +30,7 @@
 #include <sys/cmn_err.h>
 
 #ifndef HAVE_PDE_DATA
-#define PDE_DATA(x) (PDE(x)->data)
+#define        PDE_DATA(x) (PDE(x)->data)
 #endif
 
 static kmutex_t kstat_module_lock;
@@ -41,13 +41,13 @@ static int
 kstat_resize_raw(kstat_t *ksp)
 {
        if (ksp->ks_raw_bufsize == KSTAT_RAW_MAX)
-               return ENOMEM;
+               return (ENOMEM);
 
        vmem_free(ksp->ks_raw_buf, ksp->ks_raw_bufsize);
        ksp->ks_raw_bufsize = MIN(ksp->ks_raw_bufsize * 2, KSTAT_RAW_MAX);
        ksp->ks_raw_buf = vmem_alloc(ksp->ks_raw_bufsize, KM_SLEEP);
 
-       return 0;
+       return (0);
 }
 
 void
@@ -119,213 +119,215 @@ EXPORT_SYMBOL(kstat_runq_exit);
 static int
 kstat_seq_show_headers(struct seq_file *f)
 {
-        kstat_t *ksp = (kstat_t *)f->private;
+       kstat_t *ksp = (kstat_t *)f->private;
        int rc = 0;
 
-        ASSERT(ksp->ks_magic == KS_MAGIC);
+       ASSERT(ksp->ks_magic == KS_MAGIC);
 
-        seq_printf(f, "%d %d 0x%02x %d %d %lld %lld\n",
-                  ksp->ks_kid, ksp->ks_type, ksp->ks_flags,
-                  ksp->ks_ndata, (int)ksp->ks_data_size,
-                  ksp->ks_crtime, ksp->ks_snaptime);
+       seq_printf(f, "%d %d 0x%02x %d %d %lld %lld\n",
+           ksp->ks_kid, ksp->ks_type, ksp->ks_flags,
+           ksp->ks_ndata, (int)ksp->ks_data_size,
+           ksp->ks_crtime, ksp->ks_snaptime);
 
        switch (ksp->ks_type) {
-                case KSTAT_TYPE_RAW:
+               case KSTAT_TYPE_RAW:
 restart:
-                        if (ksp->ks_raw_ops.headers) {
-                                rc = ksp->ks_raw_ops.headers(
-                                    ksp->ks_raw_buf, ksp->ks_raw_bufsize);
+                       if (ksp->ks_raw_ops.headers) {
+                               rc = ksp->ks_raw_ops.headers(
+                                   ksp->ks_raw_buf, ksp->ks_raw_bufsize);
                                if (rc == ENOMEM && !kstat_resize_raw(ksp))
                                        goto restart;
                                if (!rc)
-                                       seq_puts(f, ksp->ks_raw_buf);
-                        } else {
-                                seq_printf(f, "raw data\n");
-                        }
-                        break;
-                case KSTAT_TYPE_NAMED:
-                        seq_printf(f, "%-31s %-4s %s\n",
-                                   "name", "type", "data");
-                        break;
-                case KSTAT_TYPE_INTR:
-                        seq_printf(f, "%-8s %-8s %-8s %-8s %-8s\n",
-                                   "hard", "soft", "watchdog",
-                                   "spurious", "multsvc");
-                        break;
-                case KSTAT_TYPE_IO:
-                        seq_printf(f,
-                                   "%-8s %-8s %-8s %-8s %-8s %-8s "
-                                   "%-8s %-8s %-8s %-8s %-8s %-8s\n",
-                                   "nread", "nwritten", "reads", "writes",
-                                   "wtime", "wlentime", "wupdate",
-                                   "rtime", "rlentime", "rupdate",
-                                   "wcnt", "rcnt");
-                        break;
-                case KSTAT_TYPE_TIMER:
-                        seq_printf(f,
-                                   "%-31s %-8s "
-                                   "%-8s %-8s %-8s %-8s %-8s\n",
-                                   "name", "events", "elapsed",
-                                   "min", "max", "start", "stop");
-                        break;
-                default:
-                        PANIC("Undefined kstat type %d\n", ksp->ks_type);
-        }
-
-       return -rc;
+                                       seq_puts(f, ksp->ks_raw_buf);
+                       } else {
+                               seq_printf(f, "raw data\n");
+                       }
+                       break;
+               case KSTAT_TYPE_NAMED:
+                       seq_printf(f, "%-31s %-4s %s\n",
+                           "name", "type", "data");
+                       break;
+               case KSTAT_TYPE_INTR:
+                       seq_printf(f, "%-8s %-8s %-8s %-8s %-8s\n",
+                           "hard", "soft", "watchdog",
+                           "spurious", "multsvc");
+                       break;
+               case KSTAT_TYPE_IO:
+                       seq_printf(f,
+                           "%-8s %-8s %-8s %-8s %-8s %-8s "
+                           "%-8s %-8s %-8s %-8s %-8s %-8s\n",
+                           "nread", "nwritten", "reads", "writes",
+                           "wtime", "wlentime", "wupdate",
+                           "rtime", "rlentime", "rupdate",
+                           "wcnt", "rcnt");
+                       break;
+               case KSTAT_TYPE_TIMER:
+                       seq_printf(f,
+                           "%-31s %-8s "
+                           "%-8s %-8s %-8s %-8s %-8s\n",
+                           "name", "events", "elapsed",
+                           "min", "max", "start", "stop");
+                       break;
+               default:
+                       PANIC("Undefined kstat type %d\n", ksp->ks_type);
+       }
+
+       return (-rc);
 }
 
 static int
 kstat_seq_show_raw(struct seq_file *f, unsigned char *p, int l)
 {
-        int i, j;
+       int i, j;
 
-        for (i = 0; ; i++) {
-                seq_printf(f, "%03x:", i);
+       for (i = 0; ; i++) {
+               seq_printf(f, "%03x:", i);
 
-                for (j = 0; j < 16; j++) {
-                        if (i * 16 + j >= l) {
-                                seq_printf(f, "\n");
-                                goto out;
-                        }
+               for (j = 0; j < 16; j++) {
+                       if (i * 16 + j >= l) {
+                               seq_printf(f, "\n");
+                               goto out;
+                       }
 
-                        seq_printf(f, " %02x", (unsigned char)p[i * 16 + j]);
-                }
-                seq_printf(f, "\n");
-        }
+                       seq_printf(f, " %02x", (unsigned char)p[i * 16 + j]);
+               }
+               seq_printf(f, "\n");
+       }
 out:
-        return 0;
+       return (0);
 }
 
 static int
 kstat_seq_show_named(struct seq_file *f, kstat_named_t *knp)
 {
-        seq_printf(f, "%-31s %-4d ", knp->name, knp->data_type);
-
-        switch (knp->data_type) {
-                case KSTAT_DATA_CHAR:
-                        knp->value.c[15] = '\0'; /* NULL terminate */
-                        seq_printf(f, "%-16s", knp->value.c);
-                        break;
-                /* XXX - We need to be more careful able what tokens are
-                 * used for each arch, for now this is correct for x86_64.
-                 */
-                case KSTAT_DATA_INT32:
-                        seq_printf(f, "%d", knp->value.i32);
-                        break;
-                case KSTAT_DATA_UINT32:
-                        seq_printf(f, "%u", knp->value.ui32);
-                        break;
-                case KSTAT_DATA_INT64:
-                        seq_printf(f, "%lld", (signed long long)knp->value.i64);
-                        break;
-                case KSTAT_DATA_UINT64:
-                        seq_printf(f, "%llu", (unsigned long long)knp->value.ui64);
-                        break;
-                case KSTAT_DATA_LONG:
-                        seq_printf(f, "%ld", knp->value.l);
-                        break;
-                case KSTAT_DATA_ULONG:
-                        seq_printf(f, "%lu", knp->value.ul);
-                        break;
-                case KSTAT_DATA_STRING:
-                        KSTAT_NAMED_STR_PTR(knp)
-                                [KSTAT_NAMED_STR_BUFLEN(knp)-1] = '\0';
-                        seq_printf(f, "%s", KSTAT_NAMED_STR_PTR(knp));
-                        break;
-                default:
-                        PANIC("Undefined kstat data type %d\n", knp->data_type);
-        }
-
-        seq_printf(f, "\n");
-
-        return 0;
+       seq_printf(f, "%-31s %-4d ", knp->name, knp->data_type);
+
+       switch (knp->data_type) {
+               case KSTAT_DATA_CHAR:
+                       knp->value.c[15] = '\0'; /* NULL terminate */
+                       seq_printf(f, "%-16s", knp->value.c);
+                       break;
+               /*
+                * NOTE - We need to be more careful able what tokens are
+                * used for each arch, for now this is correct for x86_64.
+                */
+               case KSTAT_DATA_INT32:
+                       seq_printf(f, "%d", knp->value.i32);
+                       break;
+               case KSTAT_DATA_UINT32:
+                       seq_printf(f, "%u", knp->value.ui32);
+                       break;
+               case KSTAT_DATA_INT64:
+                       seq_printf(f, "%lld", (signed long long)knp->value.i64);
+                       break;
+               case KSTAT_DATA_UINT64:
+                       seq_printf(f, "%llu",
+                           (unsigned long long)knp->value.ui64);
+                       break;
+               case KSTAT_DATA_LONG:
+                       seq_printf(f, "%ld", knp->value.l);
+                       break;
+               case KSTAT_DATA_ULONG:
+                       seq_printf(f, "%lu", knp->value.ul);
+                       break;
+               case KSTAT_DATA_STRING:
+                       KSTAT_NAMED_STR_PTR(knp)
+                               [KSTAT_NAMED_STR_BUFLEN(knp)-1] = '\0';
+                       seq_printf(f, "%s", KSTAT_NAMED_STR_PTR(knp));
+                       break;
+               default:
+                       PANIC("Undefined kstat data type %d\n", knp->data_type);
+       }
+
+       seq_printf(f, "\n");
+
+       return (0);
 }
 
 static int
 kstat_seq_show_intr(struct seq_file *f, kstat_intr_t *kip)
 {
-        seq_printf(f, "%-8u %-8u %-8u %-8u %-8u\n",
-                   kip->intrs[KSTAT_INTR_HARD],
-                   kip->intrs[KSTAT_INTR_SOFT],
-                   kip->intrs[KSTAT_INTR_WATCHDOG],
-                   kip->intrs[KSTAT_INTR_SPURIOUS],
-                   kip->intrs[KSTAT_INTR_MULTSVC]);
-
-        return 0;
+       seq_printf(f, "%-8u %-8u %-8u %-8u %-8u\n",
+           kip->intrs[KSTAT_INTR_HARD],
+           kip->intrs[KSTAT_INTR_SOFT],
+           kip->intrs[KSTAT_INTR_WATCHDOG],
+           kip->intrs[KSTAT_INTR_SPURIOUS],
+           kip->intrs[KSTAT_INTR_MULTSVC]);
+
+       return (0);
 }
 
 static int
 kstat_seq_show_io(struct seq_file *f, kstat_io_t *kip)
 {
-        seq_printf(f,
-                   "%-8llu %-8llu %-8u %-8u %-8lld %-8lld "
-                   "%-8lld %-8lld %-8lld %-8lld %-8u %-8u\n",
-                   kip->nread, kip->nwritten,
-                   kip->reads, kip->writes,
-                   kip->wtime, kip->wlentime, kip->wlastupdate,
-                   kip->rtime, kip->rlentime, kip->rlastupdate,
-                   kip->wcnt,  kip->rcnt);
-
-        return 0;
+       seq_printf(f,
+           "%-8llu %-8llu %-8u %-8u %-8lld %-8lld "
+           "%-8lld %-8lld %-8lld %-8lld %-8u %-8u\n",
+           kip->nread, kip->nwritten,
+           kip->reads, kip->writes,
+           kip->wtime, kip->wlentime, kip->wlastupdate,
+           kip->rtime, kip->rlentime, kip->rlastupdate,
+           kip->wcnt,  kip->rcnt);
+
+       return (0);
 }
 
 static int
 kstat_seq_show_timer(struct seq_file *f, kstat_timer_t *ktp)
 {
-        seq_printf(f,
-                   "%-31s %-8llu %-8lld %-8lld %-8lld %-8lld %-8lld\n",
-                   ktp->name, ktp->num_events, ktp->elapsed_time,
-                   ktp->min_time, ktp->max_time,
-                   ktp->start_time, ktp->stop_time);
+       seq_printf(f,
+           "%-31s %-8llu %-8lld %-8lld %-8lld %-8lld %-8lld\n",
+           ktp->name, ktp->num_events, ktp->elapsed_time,
+           ktp->min_time, ktp->max_time,
+           ktp->start_time, ktp->stop_time);
 
-        return 0;
+       return (0);
 }
 
 static int
 kstat_seq_show(struct seq_file *f, void *p)
 {
-        kstat_t *ksp = (kstat_t *)f->private;
-        int rc = 0;
+       kstat_t *ksp = (kstat_t *)f->private;
+       int rc = 0;
 
-        ASSERT(ksp->ks_magic == KS_MAGIC);
+       ASSERT(ksp->ks_magic == KS_MAGIC);
 
        switch (ksp->ks_type) {
-                case KSTAT_TYPE_RAW:
+               case KSTAT_TYPE_RAW:
 restart:
-                        if (ksp->ks_raw_ops.data) {
-                                rc = ksp->ks_raw_ops.data(
+                       if (ksp->ks_raw_ops.data) {
+                               rc = ksp->ks_raw_ops.data(
                                    ksp->ks_raw_buf, ksp->ks_raw_bufsize, p);
                                if (rc == ENOMEM && !kstat_resize_raw(ksp))
                                        goto restart;
                                if (!rc)
-                                       seq_puts(f, ksp->ks_raw_buf);
-                        } else {
-                                ASSERT(ksp->ks_ndata == 1);
-                                rc = kstat_seq_show_raw(f, ksp->ks_data,
-                                                        ksp->ks_data_size);
-                        }
-                        break;
-                case KSTAT_TYPE_NAMED:
-                        rc = kstat_seq_show_named(f, (kstat_named_t *)p);
-                        break;
-                case KSTAT_TYPE_INTR:
-                        rc = kstat_seq_show_intr(f, (kstat_intr_t *)p);
-                        break;
-                case KSTAT_TYPE_IO:
-                        rc = kstat_seq_show_io(f, (kstat_io_t *)p);
-                        break;
-                case KSTAT_TYPE_TIMER:
-                        rc = kstat_seq_show_timer(f, (kstat_timer_t *)p);
-                        break;
-                default:
-                        PANIC("Undefined kstat type %d\n", ksp->ks_type);
-        }
-
-        return -rc;
+                                       seq_puts(f, ksp->ks_raw_buf);
+                       } else {
+                               ASSERT(ksp->ks_ndata == 1);
+                               rc = kstat_seq_show_raw(f, ksp->ks_data,
+                                   ksp->ks_data_size);
+                       }
+                       break;
+               case KSTAT_TYPE_NAMED:
+                       rc = kstat_seq_show_named(f, (kstat_named_t *)p);
+                       break;
+               case KSTAT_TYPE_INTR:
+                       rc = kstat_seq_show_intr(f, (kstat_intr_t *)p);
+                       break;
+               case KSTAT_TYPE_IO:
+                       rc = kstat_seq_show_io(f, (kstat_io_t *)p);
+                       break;
+               case KSTAT_TYPE_TIMER:
+                       rc = kstat_seq_show_timer(f, (kstat_timer_t *)p);
+                       break;
+               default:
+                       PANIC("Undefined kstat type %d\n", ksp->ks_type);
+       }
+
+       return (-rc);
 }
 
-int
+static int
 kstat_default_update(kstat_t *ksp, int rw)
 {
        ASSERT(ksp != NULL);
@@ -333,79 +335,79 @@ kstat_default_update(kstat_t *ksp, int rw)
        if (rw == KSTAT_WRITE)
                return (EACCES);
 
-       return 0;
+       return (0);
 }
 
 static void *
 kstat_seq_data_addr(kstat_t *ksp, loff_t n)
 {
-        void *rc = NULL;
+       void *rc = NULL;
 
        switch (ksp->ks_type) {
-                case KSTAT_TYPE_RAW:
-                        if (ksp->ks_raw_ops.addr)
-                                rc = ksp->ks_raw_ops.addr(ksp, n);
-                        else
-                                rc = ksp->ks_data;
-                        break;
-                case KSTAT_TYPE_NAMED:
-                        rc = ksp->ks_data + n * sizeof(kstat_named_t);
-                        break;
-                case KSTAT_TYPE_INTR:
-                        rc = ksp->ks_data + n * sizeof(kstat_intr_t);
-                        break;
-                case KSTAT_TYPE_IO:
-                        rc = ksp->ks_data + n * sizeof(kstat_io_t);
-                        break;
-                case KSTAT_TYPE_TIMER:
-                        rc = ksp->ks_data + n * sizeof(kstat_timer_t);
-                        break;
-                default:
-                        PANIC("Undefined kstat type %d\n", ksp->ks_type);
-        }
-
-        return (rc);
+               case KSTAT_TYPE_RAW:
+                       if (ksp->ks_raw_ops.addr)
+                               rc = ksp->ks_raw_ops.addr(ksp, n);
+                       else
+                               rc = ksp->ks_data;
+                       break;
+               case KSTAT_TYPE_NAMED:
+                       rc = ksp->ks_data + n * sizeof (kstat_named_t);
+                       break;
+               case KSTAT_TYPE_INTR:
+                       rc = ksp->ks_data + n * sizeof (kstat_intr_t);
+                       break;
+               case KSTAT_TYPE_IO:
+                       rc = ksp->ks_data + n * sizeof (kstat_io_t);
+                       break;
+               case KSTAT_TYPE_TIMER:
+                       rc = ksp->ks_data + n * sizeof (kstat_timer_t);
+                       break;
+               default:
+                       PANIC("Undefined kstat type %d\n", ksp->ks_type);
+       }
+
+       return (rc);
 }
 
 static void *
 kstat_seq_start(struct seq_file *f, loff_t *pos)
 {
-        loff_t n = *pos;
-        kstat_t *ksp = (kstat_t *)f->private;
-        ASSERT(ksp->ks_magic == KS_MAGIC);
+       loff_t n = *pos;
+       kstat_t *ksp = (kstat_t *)f->private;
+       ASSERT(ksp->ks_magic == KS_MAGIC);
 
        mutex_enter(ksp->ks_lock);
 
-        if (ksp->ks_type == KSTAT_TYPE_RAW) {
-                ksp->ks_raw_bufsize = PAGE_SIZE;
-                ksp->ks_raw_buf = vmem_alloc(ksp->ks_raw_bufsize, KM_SLEEP);
-        }
+       if (ksp->ks_type == KSTAT_TYPE_RAW) {
+               ksp->ks_raw_bufsize = PAGE_SIZE;
+               ksp->ks_raw_buf = vmem_alloc(ksp->ks_raw_bufsize, KM_SLEEP);
+       }
 
-        /* Dynamically update kstat, on error existing kstats are used */
-        (void) ksp->ks_update(ksp, KSTAT_READ);
+       /* Dynamically update kstat, on error existing kstats are used */
+       (void) ksp->ks_update(ksp, KSTAT_READ);
 
        ksp->ks_snaptime = gethrtime();
 
-        if (!n && kstat_seq_show_headers(f))
+       if (!n && kstat_seq_show_headers(f))
                return (NULL);
 
-        if (n >= ksp->ks_ndata)
-                return (NULL);
+       if (n >= ksp->ks_ndata)
+               return (NULL);
 
-        return (kstat_seq_data_addr(ksp, n));
+       return (kstat_seq_data_addr(ksp, n));
 }
 
 static void *
 kstat_seq_next(struct seq_file *f, void *p, loff_t *pos)
 {
-        kstat_t *ksp = (kstat_t *)f->private;
-        ASSERT(ksp->ks_magic == KS_MAGIC);
+       kstat_t *ksp = (kstat_t *)f->private;
+       ASSERT(ksp->ks_magic == KS_MAGIC);
 
-        ++*pos;
-        if (*pos >= ksp->ks_ndata)
-                return (NULL);
+       ++*pos;
+       if (*pos >= ksp->ks_ndata)
+               return (NULL);
 
-        return (kstat_seq_data_addr(ksp, *pos));
+       return (kstat_seq_data_addr(ksp, *pos));
 }
 
 static void
@@ -421,10 +423,10 @@ kstat_seq_stop(struct seq_file *f, void *v)
 }
 
 static struct seq_operations kstat_seq_ops = {
-        .show  = kstat_seq_show,
-        .start = kstat_seq_start,
-        .next  = kstat_seq_next,
-        .stop  = kstat_seq_stop,
+       .show  = kstat_seq_show,
+       .start = kstat_seq_start,
+       .next  = kstat_seq_next,
+       .stop  = kstat_seq_stop,
 };
 
 static kstat_module_t *
@@ -432,9 +434,10 @@ kstat_find_module(char *name)
 {
        kstat_module_t *module;
 
-       list_for_each_entry(module, &kstat_module_list, ksm_module_list)
+       list_for_each_entry(module, &kstat_module_list, ksm_module_list) {
                if (strncmp(name, module->ksm_name, KSTAT_STRLEN) == 0)
                        return (module);
+       }
 
        return (NULL);
 }
@@ -465,28 +468,28 @@ kstat_delete_module(kstat_module_t *module)
        ASSERT(list_empty(&module->ksm_kstat_list));
        remove_proc_entry(module->ksm_name, proc_spl_kstat);
        list_del(&module->ksm_module_list);
-       kmem_free(module, sizeof(kstat_module_t));
+       kmem_free(module, sizeof (kstat_module_t));
 }
 
 static int
 proc_kstat_open(struct inode *inode, struct file *filp)
 {
-        struct seq_file *f;
-        int rc;
+       struct seq_file *f;
+       int rc;
 
-        rc = seq_open(filp, &kstat_seq_ops);
-        if (rc)
-                return rc;
+       rc = seq_open(filp, &kstat_seq_ops);
+       if (rc)
+               return (rc);
 
-        f = filp->private_data;
-        f->private = PDE_DATA(inode);
+       f = filp->private_data;
+       f->private = PDE_DATA(inode);
 
-        return rc;
+       return (rc);
 }
 
 static ssize_t
-proc_kstat_write(struct file *filp, const char __user *buf,
-                size_t len, loff_t *ppos)
+proc_kstat_write(struct file *filp, const char __user *buf, size_t len,
+    loff_t *ppos)
 {
        struct seq_file *f = filp->private_data;
        kstat_t *ksp = f->private;
@@ -515,9 +518,9 @@ static struct file_operations proc_kstat_operations = {
 
 void
 __kstat_set_raw_ops(kstat_t *ksp,
-                   int (*headers)(char *buf, size_t size),
-                   int (*data)(char *buf, size_t size, void *data),
-                   void *(*addr)(kstat_t *ksp, loff_t index))
+    int (*headers)(char *buf, size_t size),
+    int (*data)(char *buf, size_t size, void *data),
+    void *(*addr)(kstat_t *ksp, loff_t index))
 {
        ksp->ks_raw_ops.headers = headers;
        ksp->ks_raw_ops.data    = data;
@@ -527,8 +530,8 @@ EXPORT_SYMBOL(__kstat_set_raw_ops);
 
 kstat_t *
 __kstat_create(const char *ks_module, int ks_instance, const char *ks_name,
-             const char *ks_class, uchar_t ks_type, uint_t ks_ndata,
-             uchar_t ks_flags)
+    const char *ks_class, uchar_t ks_type, uint_t ks_ndata,
+    uchar_t ks_flags)
 {
        kstat_t *ksp;
 
@@ -538,24 +541,24 @@ __kstat_create(const char *ks_module, int ks_instance, const char *ks_name,
        ASSERT(!(ks_flags & KSTAT_FLAG_UNSUPPORTED));
 
        if ((ks_type == KSTAT_TYPE_INTR) || (ks_type == KSTAT_TYPE_IO))
-                ASSERT(ks_ndata == 1);
+               ASSERT(ks_ndata == 1);
 
-       ksp = kmem_zalloc(sizeof(*ksp), KM_SLEEP);
+       ksp = kmem_zalloc(sizeof (*ksp), KM_SLEEP);
        if (ksp == NULL)
-               return ksp;
+               return (ksp);
 
        mutex_enter(&kstat_module_lock);
        ksp->ks_kid = kstat_id;
-        kstat_id++;
+       kstat_id++;
        mutex_exit(&kstat_module_lock);
 
-        ksp->ks_magic = KS_MAGIC;
+       ksp->ks_magic = KS_MAGIC;
        mutex_init(&ksp->ks_private_lock, NULL, MUTEX_DEFAULT, NULL);
        ksp->ks_lock = &ksp->ks_private_lock;
        INIT_LIST_HEAD(&ksp->ks_list);
 
        ksp->ks_crtime = gethrtime();
-        ksp->ks_snaptime = ksp->ks_crtime;
+       ksp->ks_snaptime = ksp->ks_crtime;
        strncpy(ksp->ks_module, ks_module, KSTAT_STRLEN);
        ksp->ks_instance = ks_instance;
        strncpy(ksp->ks_name, ks_name, KSTAT_STRLEN);
@@ -571,41 +574,41 @@ __kstat_create(const char *ks_module, int ks_instance, const char *ks_name,
        ksp->ks_raw_bufsize = 0;
 
        switch (ksp->ks_type) {
-                case KSTAT_TYPE_RAW:
-                       ksp->ks_ndata = 1;
-                        ksp->ks_data_size = ks_ndata;
-                        break;
-                case KSTAT_TYPE_NAMED:
-                       ksp->ks_ndata = ks_ndata;
-                        ksp->ks_data_size = ks_ndata * sizeof(kstat_named_t);
-                        break;
-                case KSTAT_TYPE_INTR:
-                       ksp->ks_ndata = ks_ndata;
-                        ksp->ks_data_size = ks_ndata * sizeof(kstat_intr_t);
-                        break;
-                case KSTAT_TYPE_IO:
-                       ksp->ks_ndata = ks_ndata;
-                        ksp->ks_data_size = ks_ndata * sizeof(kstat_io_t);
-                        break;
-                case KSTAT_TYPE_TIMER:
-                       ksp->ks_ndata = ks_ndata;
-                        ksp->ks_data_size = ks_ndata * sizeof(kstat_timer_t);
-                        break;
-                default:
-                        PANIC("Undefined kstat type %d\n", ksp->ks_type);
-        }
+               case KSTAT_TYPE_RAW:
+                       ksp->ks_ndata = 1;
+                       ksp->ks_data_size = ks_ndata;
+                       break;
+               case KSTAT_TYPE_NAMED:
+                       ksp->ks_ndata = ks_ndata;
+                       ksp->ks_data_size = ks_ndata * sizeof (kstat_named_t);
+                       break;
+               case KSTAT_TYPE_INTR:
+                       ksp->ks_ndata = ks_ndata;
+                       ksp->ks_data_size = ks_ndata * sizeof (kstat_intr_t);
+                       break;
+               case KSTAT_TYPE_IO:
+                       ksp->ks_ndata = ks_ndata;
+                       ksp->ks_data_size = ks_ndata * sizeof (kstat_io_t);
+                       break;
+               case KSTAT_TYPE_TIMER:
+                       ksp->ks_ndata = ks_ndata;
+                       ksp->ks_data_size = ks_ndata * sizeof (kstat_timer_t);
+                       break;
+               default:
+                       PANIC("Undefined kstat type %d\n", ksp->ks_type);
+       }
 
        if (ksp->ks_flags & KSTAT_FLAG_VIRTUAL) {
-                ksp->ks_data = NULL;
-        } else {
-                ksp->ks_data = kmem_zalloc(ksp->ks_data_size, KM_SLEEP);
-                if (ksp->ks_data == NULL) {
-                        kmem_free(ksp, sizeof(*ksp));
-                        ksp = NULL;
-                }
-        }
-
-       return ksp;
+               ksp->ks_data = NULL;
+       } else {
+               ksp->ks_data = kmem_zalloc(ksp->ks_data_size, KM_SLEEP);
+               if (ksp->ks_data == NULL) {
+                       kmem_free(ksp, sizeof (*ksp));
+                       ksp = NULL;
+               }
+       }
+
+       return (ksp);
 }
 EXPORT_SYMBOL(__kstat_create);
 
@@ -614,21 +617,27 @@ kstat_detect_collision(kstat_t *ksp)
 {
        kstat_module_t *module;
        kstat_t *tmp;
-       char parent[KSTAT_STRLEN+1];
+       char *parent;
        char *cp;
 
-       (void) strlcpy(parent, ksp->ks_module, sizeof(parent));
+       parent = kmem_asprintf("%s", ksp->ks_module);
 
-       if ((cp = strrchr(parent, '/')) == NULL)
+       if ((cp = strrchr(parent, '/')) == NULL) {
+               strfree(parent);
                return (0);
+       }
 
        cp[0] = '\0';
        if ((module = kstat_find_module(parent)) != NULL) {
-               list_for_each_entry(tmp, &module->ksm_kstat_list, ks_list)
-                       if (strncmp(tmp->ks_name, cp+1, KSTAT_STRLEN) == 0)
+               list_for_each_entry(tmp, &module->ksm_kstat_list, ks_list) {
+                       if (strncmp(tmp->ks_name, cp+1, KSTAT_STRLEN) == 0) {
+                               strfree(parent);
                                return (EEXIST);
+                       }
+               }
        }
 
+       strfree(parent);
        return (0);
 }
 
@@ -658,9 +667,10 @@ __kstat_install(kstat_t *ksp)
         * Only one entry by this name per-module, on failure the module
         * shouldn't be deleted because we know it has at least one entry.
         */
-       list_for_each_entry(tmp, &module->ksm_kstat_list, ks_list)
+       list_for_each_entry(tmp, &module->ksm_kstat_list, ks_list) {
                if (strncmp(tmp->ks_name, ksp->ks_name, KSTAT_STRLEN) == 0)
                        goto out;
+       }
 
        list_add_tail(&ksp->ks_list, &module->ksm_kstat_list);
 
@@ -701,9 +711,7 @@ __kstat_delete(kstat_t *ksp)
 
        ksp->ks_lock = NULL;
        mutex_destroy(&ksp->ks_private_lock);
-       kmem_free(ksp, sizeof(*ksp));
-
-       return;
+       kmem_free(ksp, sizeof (*ksp));
 }
 EXPORT_SYMBOL(__kstat_delete);
 
@@ -712,7 +720,7 @@ spl_kstat_init(void)
 {
        mutex_init(&kstat_module_lock, NULL, MUTEX_DEFAULT, NULL);
        INIT_LIST_HEAD(&kstat_module_list);
-        kstat_id = 0;
+       kstat_id = 0;
        return (0);
 }
 
@@ -722,4 +730,3 @@ spl_kstat_fini(void)
        ASSERT(list_empty(&kstat_module_list));
        mutex_destroy(&kstat_module_lock);
 }
-