]> git.proxmox.com Git - mirror_spl-debian.git/commitdiff
Remove deadcode caused by removal of format1 arg
authorBrian Behlendorf <behlendorf1@llnl.gov>
Wed, 21 Jul 2010 23:31:42 +0000 (16:31 -0700)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Wed, 21 Jul 2010 23:31:42 +0000 (16:31 -0700)
Commit 55abb0929e4fbe326a9737650a167a1a988ad86b removed the never
used format1 argument of spl_debug_msg().  That in turn resulted
in some deadcode which should be removed since it's now useless.

module/spl/spl-debug.c

index f6ec86ac471dd88e3718934e98b854796aa248ae..008115e4e7f34d688579bd01f619799d0f3fb2a5 100644 (file)
@@ -669,7 +669,6 @@ spl_debug_msg(void *arg, int subsys, int mask, const char *file,
         int                      max_nob;
         va_list                  ap;
         int                      i;
-        int                      remain;
 
        if (subsys == 0)
                subsys = SS_DEBUG_SUBSYS;
@@ -726,13 +725,8 @@ spl_debug_msg(void *arg, int subsys, int mask, const char *file,
 
                 needed = 0;
                 if (format) {
-                        remain = max_nob - needed;
-                        if (remain < 0)
-                                remain = 0;
-
                         va_start(ap, format);
-                        needed += vsnprintf(string_buf+needed, remain,
-                           format, ap);
+                        needed += vsnprintf(string_buf, max_nob, format, ap);
                         va_end(ap);
                 }
 
@@ -807,13 +801,10 @@ console:
 
                 needed = 0;
                 if (format != NULL) {
-                        remain = TRACE_CONSOLE_BUFFER_SIZE - needed;
-                        if (remain > 0) {
-                                va_start(ap, format);
-                                needed += vsnprintf(string_buf+needed, remain,
-                                   format, ap);
-                                va_end(ap);
-                        }
+                        va_start(ap, format);
+                        needed += vsnprintf(string_buf,
+                            TRACE_CONSOLE_BUFFER_SIZE, format, ap);
+                        va_end(ap);
                 }
                 trace_print_to_console(&header, mask,
                                  string_buf, needed, file, fn);