]> git.proxmox.com Git - mirror_spl.git/blobdiff - module/spl/spl-vnode.c
Fix more cstyle warnings
[mirror_spl.git] / module / spl / spl-vnode.c
index 63e5a39ef06739338b739ec1b08a7c6b7403cd7e..a371fb9662325437ccb7ac7610951247c15a23dd 100644 (file)
@@ -1,4 +1,4 @@
-/*****************************************************************************\
+/*
  *  Copyright (C) 2007-2010 Lawrence Livermore National Security, LLC.
  *  Copyright (C) 2007 The Regents of the University of California.
  *  Produced at Lawrence Livermore National Laboratory (cf, DISCLAIMER).
  *
  *  You should have received a copy of the GNU General Public License along
  *  with the SPL.  If not, see <http://www.gnu.org/licenses/>.
- *****************************************************************************
+ *
  *  Solaris Porting Layer (SPL) Vnode Implementation.
-\*****************************************************************************/
+ */
 
 #include <sys/cred.h>
 #include <sys/vnode.h>
+#include <sys/kmem_cache.h>
 #include <linux/falloc.h>
-#include <spl-debug.h>
-
-#ifdef SS_DEBUG_SUBSYS
-#undef SS_DEBUG_SUBSYS
-#endif
-
-#define SS_DEBUG_SUBSYS SS_VNODE
+#include <linux/file_compat.h>
 
 vnode_t *rootdir = (vnode_t *)0xabcd1234;
 EXPORT_SYMBOL(rootdir);
@@ -48,30 +43,27 @@ vtype_t
 vn_mode_to_vtype(mode_t mode)
 {
        if (S_ISREG(mode))
-               return VREG;
+               return (VREG);
 
        if (S_ISDIR(mode))
-               return VDIR;
+               return (VDIR);
 
        if (S_ISCHR(mode))
-               return VCHR;
+               return (VCHR);
 
        if (S_ISBLK(mode))
-               return VBLK;
+               return (VBLK);
 
        if (S_ISFIFO(mode))
-               return VFIFO;
+               return (VFIFO);
 
        if (S_ISLNK(mode))
-               return VLNK;
+               return (VLNK);
 
        if (S_ISSOCK(mode))
-               return VSOCK;
-
-       if (S_ISCHR(mode))
-               return VCHR;
+               return (VSOCK);
 
-       return VNON;
+       return (VNON);
 } /* vn_mode_to_vtype() */
 EXPORT_SYMBOL(vn_mode_to_vtype);
 
@@ -79,27 +71,27 @@ mode_t
 vn_vtype_to_mode(vtype_t vtype)
 {
        if (vtype == VREG)
-               return S_IFREG;
+               return (S_IFREG);
 
        if (vtype == VDIR)
-               return S_IFDIR;
+               return (S_IFDIR);
 
        if (vtype == VCHR)
-               return S_IFCHR;
+               return (S_IFCHR);
 
        if (vtype == VBLK)
-               return S_IFBLK;
+               return (S_IFBLK);
 
        if (vtype == VFIFO)
-               return S_IFIFO;
+               return (S_IFIFO);
 
        if (vtype == VLNK)
-               return S_IFLNK;
+               return (S_IFLNK);
 
        if (vtype == VSOCK)
-               return S_IFSOCK;
+               return (S_IFSOCK);
 
-       return VNON;
+       return (VNON);
 } /* vn_vtype_to_mode() */
 EXPORT_SYMBOL(vn_vtype_to_mode);
 
@@ -107,7 +99,6 @@ vnode_t *
 vn_alloc(int flag)
 {
        vnode_t *vp;
-       SENTRY;
 
        vp = kmem_cache_alloc(vn_cache, flag);
        if (vp != NULL) {
@@ -115,29 +106,26 @@ vn_alloc(int flag)
                vp->v_type = 0;
        }
 
-       SRETURN(vp);
+       return (vp);
 } /* vn_alloc() */
 EXPORT_SYMBOL(vn_alloc);
 
 void
 vn_free(vnode_t *vp)
 {
-       SENTRY;
        kmem_cache_free(vn_cache, vp);
-       SEXIT;
 } /* vn_free() */
 EXPORT_SYMBOL(vn_free);
 
 int
-vn_open(const char *path, uio_seg_t seg, int flags, int mode,
-       vnode_t **vpp, int x1, void *x2)
+vn_open(const char *path, uio_seg_t seg, int flags, int mode, vnode_t **vpp,
+    int x1, void *x2)
 {
        struct file *fp;
        struct kstat stat;
        int rc, saved_umask = 0;
        gfp_t saved_gfp;
        vnode_t *vp;
-       SENTRY;
 
        ASSERT(flags & (FWRITE | FREAD));
        ASSERT(seg == UIO_SYSSPACE);
@@ -147,7 +135,8 @@ vn_open(const char *path, uio_seg_t seg, int flags, int mode,
        if (!(flags & FCREAT) && (flags & FWRITE))
                flags |= FEXCL;
 
-       /* Note for filp_open() the two low bits must be remapped to mean:
+       /*
+        * Note for filp_open() the two low bits must be remapped to mean:
         * 01 - read-only  -> 00 read-only
         * 10 - write-only -> 01 write-only
         * 11 - read-write -> 10 read-write
@@ -160,25 +149,27 @@ vn_open(const char *path, uio_seg_t seg, int flags, int mode,
        fp = filp_open(path, flags, mode);
 
        if (flags & FCREAT)
-               (void)xchg(&current->fs->umask, saved_umask);
+               (void) xchg(&current->fs->umask, saved_umask);
 
        if (IS_ERR(fp))
-               SRETURN(-PTR_ERR(fp));
+               return (-PTR_ERR(fp));
 
-#ifdef HAVE_2ARGS_VFS_GETATTR
+#if defined(HAVE_4ARGS_VFS_GETATTR)
+       rc = vfs_getattr(&fp->f_path, &stat, STATX_TYPE, AT_STATX_SYNC_AS_STAT);
+#elif defined(HAVE_2ARGS_VFS_GETATTR)
        rc = vfs_getattr(&fp->f_path, &stat);
 #else
        rc = vfs_getattr(fp->f_path.mnt, fp->f_dentry, &stat);
 #endif
        if (rc) {
                filp_close(fp, 0);
-               SRETURN(-rc);
+               return (-rc);
        }
 
        vp = vn_alloc(KM_SLEEP);
        if (!vp) {
                filp_close(fp, 0);
-               SRETURN(ENOMEM);
+               return (ENOMEM);
        }
 
        saved_gfp = mapping_gfp_mask(fp->f_mapping);
@@ -191,81 +182,65 @@ vn_open(const char *path, uio_seg_t seg, int flags, int mode,
        *vpp = vp;
        mutex_exit(&vp->v_lock);
 
-       SRETURN(0);
+       return (0);
 } /* vn_open() */
 EXPORT_SYMBOL(vn_open);
 
 int
 vn_openat(const char *path, uio_seg_t seg, int flags, int mode,
-         vnode_t **vpp, int x1, void *x2, vnode_t *vp, int fd)
+    vnode_t **vpp, int x1, void *x2, vnode_t *vp, int fd)
 {
        char *realpath;
        int len, rc;
-       SENTRY;
 
        ASSERT(vp == rootdir);
 
        len = strlen(path) + 2;
-       realpath = kmalloc(len, GFP_KERNEL);
+       realpath = kmalloc(len, kmem_flags_convert(KM_SLEEP));
        if (!realpath)
-               SRETURN(ENOMEM);
+               return (ENOMEM);
 
-       (void)snprintf(realpath, len, "/%s", path);
+       (void) snprintf(realpath, len, "/%s", path);
        rc = vn_open(realpath, seg, flags, mode, vpp, x1, x2);
        kfree(realpath);
 
-       SRETURN(rc);
+       return (rc);
 } /* vn_openat() */
 EXPORT_SYMBOL(vn_openat);
 
 int
 vn_rdwr(uio_rw_t uio, vnode_t *vp, void *addr, ssize_t len, offset_t off,
-       uio_seg_t seg, int ioflag, rlim64_t x2, void *x3, ssize_t *residp)
+    uio_seg_t seg, int ioflag, rlim64_t x2, void *x3, ssize_t *residp)
 {
-       loff_t offset;
-       mm_segment_t saved_fs;
-       struct file *fp;
+       struct file *fp = vp->v_file;
+       loff_t offset = off;
        int rc;
-       SENTRY;
 
        ASSERT(uio == UIO_WRITE || uio == UIO_READ);
-       ASSERT(vp);
-       ASSERT(vp->v_file);
        ASSERT(seg == UIO_SYSSPACE);
        ASSERT((ioflag & ~FAPPEND) == 0);
-       ASSERT(x2 == RLIM64_INFINITY);
-
-       fp = vp->v_file;
 
-       offset = off;
        if (ioflag & FAPPEND)
                offset = fp->f_pos;
 
-       /* Writable user data segment must be briefly increased for this
-        * process so we can use the user space read call paths to write
-        * in to memory allocated by the kernel. */
-       saved_fs = get_fs();
-        set_fs(get_ds());
-
        if (uio & UIO_WRITE)
-               rc = vfs_write(fp, addr, len, &offset);
+               rc = spl_kernel_write(fp, addr, len, &offset);
        else
-               rc = vfs_read(fp, addr, len, &offset);
+               rc = spl_kernel_read(fp, addr, len, &offset);
 
-       set_fs(saved_fs);
        fp->f_pos = offset;
 
        if (rc < 0)
-               SRETURN(-rc);
+               return (-rc);
 
        if (residp) {
                *residp = len - rc;
        } else {
                if (rc != len)
-                       SRETURN(EIO);
+                       return (EIO);
        }
 
-       SRETURN(0);
+       return (0);
 } /* vn_rdwr() */
 EXPORT_SYMBOL(vn_rdwr);
 
@@ -273,7 +248,6 @@ int
 vn_close(vnode_t *vp, int flags, int x1, int x2, void *x3, void *x4)
 {
        int rc;
-       SENTRY;
 
        ASSERT(vp);
        ASSERT(vp->v_file);
@@ -282,13 +256,15 @@ vn_close(vnode_t *vp, int flags, int x1, int x2, void *x3, void *x4)
        rc = filp_close(vp->v_file, 0);
        vn_free(vp);
 
-       SRETURN(-rc);
+       return (-rc);
 } /* vn_close() */
 EXPORT_SYMBOL(vn_close);
 
-/* vn_seek() does not actually seek it only performs bounds checking on the
+/*
+ * vn_seek() does not actually seek it only performs bounds checking on the
  * proposed seek.  We perform minimal checking and allow vn_rdwr() to catch
- * anything more serious. */
+ * anything more serious.
+ */
 int
 vn_seek(vnode_t *vp, offset_t ooff, offset_t *noffp, void *ct)
 {
@@ -296,239 +272,12 @@ vn_seek(vnode_t *vp, offset_t ooff, offset_t *noffp, void *ct)
 }
 EXPORT_SYMBOL(vn_seek);
 
-/*
- * kern_path() was introduced in Linux 2.6.28. We duplicate it as a
- * compatibility shim for earlier kernels.
- */
-#ifndef HAVE_KERN_PATH
-int
-kern_path(const char *name, unsigned int flags, struct path *path)
-{
-       struct nameidata nd;
-       int rc = path_lookup(name, flags, &nd);
-       if (!rc)
-               *path = nd.path;
-       return rc;
-}
-#endif /* HAVE_KERN_PATH */
-
-/*
- * spl_basename() takes a NULL-terminated string s as input containing a path.
- * It returns a char pointer to a string and a length that describe the
- * basename of the path. If the basename is not "." or "/", it will be an index
- * into the string. While the string should be NULL terminated, the section
- * referring to the basename is not. spl_basename is dual-licensed GPLv2+ and
- * CC0. Anyone wishing to reuse it in another codebase may pick either license.
- */
-static void
-spl_basename(const char *s, const char **str, int *len)
-{
-       size_t i, end;
-
-       ASSERT(str);
-       ASSERT(len);
-
-       if (!s || !*s) {
-               *str = ".";
-               *len = 1;
-               return;
-       }
-
-       i = strlen(s) - 1;
-
-       while (i && s[i--] == '/');
-
-       if (i == 0) {
-               *str = "/";
-               *len = 1;
-               return;
-       }
-
-       end = i;
-
-       for (end = i; i; i--) {
-               if (s[i] == '/') {
-                       *str = &s[i+1];
-                       *len = end - i + 1;
-                       return;
-               }
-       }
-
-       *str = s;
-       *len = end + 1;
-}
-
-static struct dentry *
-spl_kern_path_locked(const char *name, struct path *path)
-{
-       struct path parent;
-       struct dentry *dentry;
-       const char *basename;
-       int len;
-       int rc;
-
-       ASSERT(name);
-       ASSERT(path);
-
-       spl_basename(name, &basename, &len);
-
-       /* We do not accept "." or ".." */
-       if (len <= 2 && basename[0] == '.')
-               if (len == 1 || basename[1] == '.')
-                       return (ERR_PTR(-EACCES));
-
-       rc = kern_path(name, LOOKUP_PARENT, &parent);
-       if (rc)
-               return (ERR_PTR(rc));
-
-       spl_inode_lock(parent.dentry->d_inode);
-
-       dentry = lookup_one_len(basename, parent.dentry, len);
-       if (IS_ERR(dentry)) {
-               spl_inode_unlock(parent.dentry->d_inode);
-               path_put(&parent);
-       } else {
-               *path = parent;
-       }
-
-       return (dentry);
-}
-
-/* Based on do_unlinkat() from linux/fs/namei.c */
-int
-vn_remove(const char *path, uio_seg_t seg, int flags)
-{
-       struct dentry *dentry;
-       struct path parent;
-       struct inode *inode = NULL;
-       int rc = 0;
-       SENTRY;
-
-       ASSERT(seg == UIO_SYSSPACE);
-       ASSERT(flags == RMFILE);
-
-       dentry = spl_kern_path_locked(path, &parent);
-       rc = PTR_ERR(dentry);
-       if (!IS_ERR(dentry)) {
-               if (parent.dentry->d_name.name[parent.dentry->d_name.len])
-                       SGOTO(slashes, rc = 0);
-
-               inode = dentry->d_inode;
-               if (inode)
-                       atomic_inc(&inode->i_count);
-               else
-                       SGOTO(slashes, rc = 0);
-
-#ifdef HAVE_2ARGS_VFS_UNLINK
-               rc = vfs_unlink(parent.dentry->d_inode, dentry);
-#else
-               rc = vfs_unlink(parent.dentry->d_inode, dentry, NULL);
-#endif /* HAVE_2ARGS_VFS_UNLINK */
-exit1:
-               dput(dentry);
-       } else {
-               return (-rc);
-       }
-
-       spl_inode_unlock(parent.dentry->d_inode);
-       if (inode)
-               iput(inode);    /* truncate the inode here */
-
-       path_put(&parent);
-       SRETURN(-rc);
-
-slashes:
-       rc = !dentry->d_inode ? -ENOENT :
-           S_ISDIR(dentry->d_inode->i_mode) ? -EISDIR : -ENOTDIR;
-       SGOTO(exit1, rc);
-} /* vn_remove() */
-EXPORT_SYMBOL(vn_remove);
-
-/* Based on do_rename() from linux/fs/namei.c */
-int
-vn_rename(const char *oldname, const char *newname, int x1)
-{
-       struct dentry *old_dir, *new_dir;
-       struct dentry *old_dentry, *new_dentry;
-       struct dentry *trap;
-       struct path old_parent, new_parent;
-       int rc = 0;
-       SENTRY;
-
-       old_dentry = spl_kern_path_locked(oldname, &old_parent);
-       if (IS_ERR(old_dentry))
-               SGOTO(exit, rc = PTR_ERR(old_dentry));
-
-       spl_inode_unlock(old_parent.dentry->d_inode);
-
-       new_dentry = spl_kern_path_locked(newname, &new_parent);
-       if (IS_ERR(new_dentry))
-               SGOTO(exit2, rc = PTR_ERR(new_dentry));
-
-       spl_inode_unlock(new_parent.dentry->d_inode);
-
-       rc = -EXDEV;
-       if (old_parent.mnt != new_parent.mnt)
-               SGOTO(exit3, rc);
-
-       old_dir = old_parent.dentry;
-       new_dir = new_parent.dentry;
-       trap = lock_rename(new_dir, old_dir);
-
-       /* source should not be ancestor of target */
-       rc = -EINVAL;
-       if (old_dentry == trap)
-               SGOTO(exit4, rc);
-
-       /* target should not be an ancestor of source */
-       rc = -ENOTEMPTY;
-       if (new_dentry == trap)
-               SGOTO(exit4, rc);
-
-       /* source must exist */
-       rc = -ENOENT;
-       if (!old_dentry->d_inode)
-               SGOTO(exit4, rc);
-
-       /* unless the source is a directory trailing slashes give -ENOTDIR */
-       if (!S_ISDIR(old_dentry->d_inode->i_mode)) {
-               rc = -ENOTDIR;
-               if (old_dentry->d_name.name[old_dentry->d_name.len])
-                       SGOTO(exit4, rc);
-               if (new_dentry->d_name.name[new_dentry->d_name.len])
-                       SGOTO(exit4, rc);
-       }
-
-#if defined(HAVE_4ARGS_VFS_RENAME)
-       rc = vfs_rename(old_dir->d_inode, old_dentry,
-           new_dir->d_inode, new_dentry);
-#elif defined(HAVE_5ARGS_VFS_RENAME)
-       rc = vfs_rename(old_dir->d_inode, old_dentry,
-           new_dir->d_inode, new_dentry, NULL);
-#else
-       rc = vfs_rename(old_dir->d_inode, old_dentry,
-           new_dir->d_inode, new_dentry, NULL, 0);
-#endif
-exit4:
-       unlock_rename(new_dir, old_dir);
-exit3:
-       dput(new_dentry);
-       path_put(&new_parent);
-exit2:
-       dput(old_dentry);
-       path_put(&old_parent);
-exit:
-       SRETURN(-rc);
-}
-EXPORT_SYMBOL(vn_rename);
-
 int
 vn_getattr(vnode_t *vp, vattr_t *vap, int flags, void *x3, void *x4)
 {
        struct file *fp;
        struct kstat stat;
        int rc;
-       SENTRY;
 
        ASSERT(vp);
        ASSERT(vp->v_file);
@@ -536,37 +285,42 @@ vn_getattr(vnode_t *vp, vattr_t *vap, int flags, void *x3, void *x4)
 
        fp = vp->v_file;
 
-#ifdef HAVE_2ARGS_VFS_GETATTR
+#if defined(HAVE_4ARGS_VFS_GETATTR)
+       rc = vfs_getattr(&fp->f_path, &stat, STATX_BASIC_STATS,
+           AT_STATX_SYNC_AS_STAT);
+#elif defined(HAVE_2ARGS_VFS_GETATTR)
        rc = vfs_getattr(&fp->f_path, &stat);
 #else
        rc = vfs_getattr(fp->f_path.mnt, fp->f_dentry, &stat);
 #endif
        if (rc)
-               SRETURN(-rc);
-
-       vap->va_type          = vn_mode_to_vtype(stat.mode);
-       vap->va_mode          = stat.mode;
-       vap->va_uid           = KUID_TO_SUID(stat.uid);
-       vap->va_gid           = KGID_TO_SGID(stat.gid);
-       vap->va_fsid          = 0;
-       vap->va_nodeid        = stat.ino;
-       vap->va_nlink         = stat.nlink;
-        vap->va_size          = stat.size;
-       vap->va_blksize       = stat.blksize;
-       vap->va_atime         = stat.atime;
-       vap->va_mtime         = stat.mtime;
-       vap->va_ctime         = stat.ctime;
-       vap->va_rdev          = stat.rdev;
-       vap->va_nblocks       = stat.blocks;
-
-       SRETURN(0);
+               return (-rc);
+
+       vap->va_type    = vn_mode_to_vtype(stat.mode);
+       vap->va_mode    = stat.mode;
+       vap->va_uid     = KUID_TO_SUID(stat.uid);
+       vap->va_gid     = KGID_TO_SGID(stat.gid);
+       vap->va_fsid    = 0;
+       vap->va_nodeid  = stat.ino;
+       vap->va_nlink   = stat.nlink;
+       vap->va_size    = stat.size;
+       vap->va_blksize = stat.blksize;
+       vap->va_atime   = stat.atime;
+       vap->va_mtime   = stat.mtime;
+       vap->va_ctime   = stat.ctime;
+       vap->va_rdev    = stat.rdev;
+       vap->va_nblocks = stat.blocks;
+
+       return (0);
 }
 EXPORT_SYMBOL(vn_getattr);
 
-int vn_fsync(vnode_t *vp, int flags, void *x3, void *x4)
+int
+vn_fsync(vnode_t *vp, int flags, void *x3, void *x4)
 {
        int datasync = 0;
-       SENTRY;
+       int error;
+       int fstrans;
 
        ASSERT(vp);
        ASSERT(vp->v_file);
@@ -574,7 +328,19 @@ int vn_fsync(vnode_t *vp, int flags, void *x3, void *x4)
        if (flags & FDSYNC)
                datasync = 1;
 
-       SRETURN(-spl_filp_fsync(vp->v_file, datasync));
+       /*
+        * May enter XFS which generates a warning when PF_FSTRANS is set.
+        * To avoid this the flag is cleared over vfs_sync() and then reset.
+        */
+       fstrans = __spl_pf_fstrans_check();
+       if (fstrans)
+               current->flags &= ~(__SPL_PF_FSTRANS);
+
+       error = -spl_filp_fsync(vp->v_file, datasync);
+       if (fstrans)
+               current->flags |= __SPL_PF_FSTRANS;
+
+       return (error);
 } /* vn_fsync() */
 EXPORT_SYMBOL(vn_fsync);
 
@@ -582,16 +348,26 @@ int vn_space(vnode_t *vp, int cmd, struct flock *bfp, int flag,
     offset_t offset, void *x6, void *x7)
 {
        int error = EOPNOTSUPP;
-       SENTRY;
+#ifdef FALLOC_FL_PUNCH_HOLE
+       int fstrans;
+#endif
 
        if (cmd != F_FREESP || bfp->l_whence != 0)
-               SRETURN(EOPNOTSUPP);
+               return (EOPNOTSUPP);
 
        ASSERT(vp);
        ASSERT(vp->v_file);
        ASSERT(bfp->l_start >= 0 && bfp->l_len > 0);
 
 #ifdef FALLOC_FL_PUNCH_HOLE
+       /*
+        * May enter XFS which generates a warning when PF_FSTRANS is set.
+        * To avoid this the flag is cleared over vfs_sync() and then reset.
+        */
+       fstrans = __spl_pf_fstrans_check();
+       if (fstrans)
+               current->flags &= ~(__SPL_PF_FSTRANS);
+
        /*
         * When supported by the underlying file system preferentially
         * use the fallocate() callback to preallocate the space.
@@ -599,8 +375,12 @@ int vn_space(vnode_t *vp, int cmd, struct flock *bfp, int flag,
        error = -spl_filp_fallocate(vp->v_file,
            FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE,
            bfp->l_start, bfp->l_len);
+
+       if (fstrans)
+               current->flags |= __SPL_PF_FSTRANS;
+
        if (error == 0)
-               SRETURN(0);
+               return (0);
 #endif
 
 #ifdef HAVE_INODE_TRUNCATE_RANGE
@@ -616,58 +396,70 @@ int vn_space(vnode_t *vp, int cmd, struct flock *bfp, int flag,
                if (end % PAGE_SIZE != 0) {
                        end &= ~(off_t)(PAGE_SIZE - 1);
                        if (end <= bfp->l_start)
-                               SRETURN(0);
+                               return (0);
                }
                --end;
 
                vp->v_file->f_dentry->d_inode->i_op->truncate_range(
-                       vp->v_file->f_dentry->d_inode,
-                       bfp->l_start, end
-               );
-               SRETURN(0);
+                   vp->v_file->f_dentry->d_inode, bfp->l_start, end);
+
+               return (0);
        }
 #endif
 
-       SRETURN(error);
+       return (error);
 }
 EXPORT_SYMBOL(vn_space);
 
 /* Function must be called while holding the vn_file_lock */
 static file_t *
-file_find(int fd)
+file_find(int fd, struct task_struct *task)
 {
-        file_t *fp;
-
-       ASSERT(spin_is_locked(&vn_file_lock));
+       file_t *fp;
 
-        list_for_each_entry(fp, &vn_file_list,  f_list) {
-               if (fd == fp->f_fd && fp->f_task == current) {
+       list_for_each_entry(fp, &vn_file_list,  f_list) {
+               if (fd == fp->f_fd && fp->f_task == task) {
                        ASSERT(atomic_read(&fp->f_ref) != 0);
-                        return fp;
+                       return (fp);
                }
        }
 
-        return NULL;
+       return (NULL);
 } /* file_find() */
 
 file_t *
 vn_getf(int fd)
 {
-        struct kstat stat;
+       struct kstat stat;
        struct file *lfp;
        file_t *fp;
        vnode_t *vp;
        int rc = 0;
-       SENTRY;
+
+       if (fd < 0)
+               return (NULL);
 
        /* Already open just take an extra reference */
        spin_lock(&vn_file_lock);
 
-       fp = file_find(fd);
+       fp = file_find(fd, current);
        if (fp) {
+               lfp = fget(fd);
+               fput(fp->f_file);
+               /*
+                * areleasef() can cause us to see a stale reference when
+                * userspace has reused a file descriptor before areleasef()
+                * has run. fput() the stale reference and replace it. We
+                * retain the original reference count such that the concurrent
+                * areleasef() will decrement its reference and terminate.
+                */
+               if (lfp != fp->f_file) {
+                       fp->f_file = lfp;
+                       fp->f_vnode->v_file = lfp;
+               }
                atomic_inc(&fp->f_ref);
                spin_unlock(&vn_file_lock);
-               SRETURN(fp);
+               return (fp);
        }
 
        spin_unlock(&vn_file_lock);
@@ -675,7 +467,7 @@ vn_getf(int fd)
        /* File was not yet opened create the object and setup */
        fp = kmem_cache_alloc(vn_file_cache, KM_SLEEP);
        if (fp == NULL)
-               SGOTO(out, rc);
+               goto out;
 
        mutex_enter(&fp->f_lock);
 
@@ -686,19 +478,22 @@ vn_getf(int fd)
 
        lfp = fget(fd);
        if (lfp == NULL)
-               SGOTO(out_mutex, rc);
+               goto out_mutex;
 
        vp = vn_alloc(KM_SLEEP);
        if (vp == NULL)
-               SGOTO(out_fget, rc);
+               goto out_fget;
 
-#ifdef HAVE_2ARGS_VFS_GETATTR
+#if defined(HAVE_4ARGS_VFS_GETATTR)
+       rc = vfs_getattr(&lfp->f_path, &stat, STATX_TYPE,
+           AT_STATX_SYNC_AS_STAT);
+#elif defined(HAVE_2ARGS_VFS_GETATTR)
        rc = vfs_getattr(&lfp->f_path, &stat);
 #else
        rc = vfs_getattr(lfp->f_path.mnt, lfp->f_dentry, &stat);
 #endif
-        if (rc)
-               SGOTO(out_vnode, rc);
+       if (rc)
+               goto out_vnode;
 
        mutex_enter(&vp->v_lock);
        vp->v_type = vn_mode_to_vtype(stat.mode);
@@ -714,7 +509,7 @@ vn_getf(int fd)
        spin_unlock(&vn_file_lock);
 
        mutex_exit(&fp->f_lock);
-       SRETURN(fp);
+       return (fp);
 
 out_vnode:
        vn_free(vp);
@@ -724,7 +519,7 @@ out_mutex:
        mutex_exit(&fp->f_lock);
        kmem_cache_free(vn_file_cache, fp);
 out:
-        SRETURN(NULL);
+       return (NULL);
 } /* getf() */
 EXPORT_SYMBOL(getf);
 
@@ -742,29 +537,36 @@ static void releasef_locked(file_t *fp)
 
 void
 vn_releasef(int fd)
+{
+       areleasef(fd, P_FINFO(current));
+}
+EXPORT_SYMBOL(releasef);
+
+void
+vn_areleasef(int fd, uf_info_t *fip)
 {
        file_t *fp;
-       SENTRY;
+       struct task_struct *task = (struct task_struct *)fip;
+
+       if (fd < 0)
+               return;
 
        spin_lock(&vn_file_lock);
-       fp = file_find(fd);
+       fp = file_find(fd, task);
        if (fp) {
                atomic_dec(&fp->f_ref);
                if (atomic_read(&fp->f_ref) > 0) {
                        spin_unlock(&vn_file_lock);
-                       SEXIT;
                        return;
                }
 
-               list_del(&fp->f_list);
+               list_del(&fp->f_list);
                releasef_locked(fp);
        }
        spin_unlock(&vn_file_lock);
-
-       SEXIT;
-       return;
 } /* releasef() */
-EXPORT_SYMBOL(releasef);
+EXPORT_SYMBOL(areleasef);
+
 
 static void
 #ifdef HAVE_SET_FS_PWD_WITH_CONST
@@ -796,35 +598,34 @@ vn_set_fs_pwd(struct fs_struct *fs, struct path *path)
 int
 vn_set_pwd(const char *filename)
 {
-        struct path path;
-        mm_segment_t saved_fs;
-        int rc;
-        SENTRY;
+       struct path path;
+       mm_segment_t saved_fs;
+       int rc;
 
-        /*
-         * user_path_dir() and __user_walk() both expect 'filename' to be
-         * a user space address so we must briefly increase the data segment
-         * size to ensure strncpy_from_user() does not fail with -EFAULT.
-         */
-        saved_fs = get_fs();
-        set_fs(get_ds());
+       /*
+        * user_path_dir() and __user_walk() both expect 'filename' to be
+        * a user space address so we must briefly increase the data segment
+        * size to ensure strncpy_from_user() does not fail with -EFAULT.
+        */
+       saved_fs = get_fs();
+       set_fs(get_ds());
 
-        rc = user_path_dir(filename, &path);
-        if (rc)
-                SGOTO(out, rc);
+       rc = user_path_dir(filename, &path);
+       if (rc)
+               goto out;
 
-        rc = inode_permission(path.dentry->d_inode, MAY_EXEC | MAY_ACCESS);
-        if (rc)
-                SGOTO(dput_and_out, rc);
+       rc = inode_permission(path.dentry->d_inode, MAY_EXEC | MAY_ACCESS);
+       if (rc)
+               goto dput_and_out;
 
-        vn_set_fs_pwd(current->fs, &path);
+       vn_set_fs_pwd(current->fs, &path);
 
 dput_and_out:
-        path_put(&path);
+       path_put(&path);
 out:
        set_fs(saved_fs);
 
-        SRETURN(-rc);
+       return (-rc);
 } /* vn_set_pwd() */
 EXPORT_SYMBOL(vn_set_pwd);
 
@@ -852,11 +653,11 @@ vn_file_cache_constructor(void *buf, void *cdrarg, int kmflags)
        file_t *fp = buf;
 
        atomic_set(&fp->f_ref, 0);
-        mutex_init(&fp->f_lock, NULL, MUTEX_DEFAULT, NULL);
+       mutex_init(&fp->f_lock, NULL, MUTEX_DEFAULT, NULL);
        INIT_LIST_HEAD(&fp->f_list);
 
-        return (0);
-} /* file_cache_constructor() */
+       return (0);
+} /* vn_file_cache_constructor() */
 
 static void
 vn_file_cache_destructor(void *buf, void *cdrarg)
@@ -869,32 +670,27 @@ vn_file_cache_destructor(void *buf, void *cdrarg)
 int
 spl_vn_init(void)
 {
-       SENTRY;
        vn_cache = kmem_cache_create("spl_vn_cache",
-                                    sizeof(struct vnode), 64,
-                                    vn_cache_constructor,
-                                    vn_cache_destructor,
-                                    NULL, NULL, NULL, KMC_KMEM);
+           sizeof (struct vnode), 64, vn_cache_constructor,
+           vn_cache_destructor, NULL, NULL, NULL, 0);
 
        vn_file_cache = kmem_cache_create("spl_vn_file_cache",
-                                         sizeof(file_t), 64,
-                                         vn_file_cache_constructor,
-                                         vn_file_cache_destructor,
-                                         NULL, NULL, NULL, KMC_KMEM);
-       SRETURN(0);
-} /* vn_init() */
+           sizeof (file_t), 64, vn_file_cache_constructor,
+           vn_file_cache_destructor, NULL, NULL, NULL, 0);
+
+       return (0);
+} /* spl_vn_init() */
 
 void
 spl_vn_fini(void)
 {
-        file_t *fp, *next_fp;
+       file_t *fp, *next_fp;
        int leaked = 0;
-       SENTRY;
 
        spin_lock(&vn_file_lock);
 
-        list_for_each_entry_safe(fp, next_fp, &vn_file_list,  f_list) {
-               list_del(&fp->f_list);
+       list_for_each_entry_safe(fp, next_fp, &vn_file_list,  f_list) {
+               list_del(&fp->f_list);
                releasef_locked(fp);
                leaked++;
        }
@@ -902,11 +698,8 @@ spl_vn_fini(void)
        spin_unlock(&vn_file_lock);
 
        if (leaked > 0)
-               SWARN("Warning %d files leaked\n", leaked);
+               printk(KERN_WARNING "WARNING: %d vnode files leaked\n", leaked);
 
        kmem_cache_destroy(vn_file_cache);
        kmem_cache_destroy(vn_cache);
-
-       SEXIT;
-       return;
-} /* vn_fini() */
+} /* spl_vn_fini() */