]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commitdiff
ACPI / power: constify attribute_group structures
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Fri, 30 Jun 2017 12:09:05 +0000 (17:39 +0530)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 4 Jul 2017 20:15:14 +0000 (22:15 +0200)
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.

File size before:
   text    data     bss     dec     hex filename
   4622     304       8    4934    1346 drivers/acpi/power.o

File size After adding 'const':
   text    data     bss     dec     hex filename
   4846      80       8    4934    1346 drivers/acpi/power.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/power.c

index 3a6c9b741b233cd81304961e43482d003347397d..1b475bc1ae169cb904f0c33cd32bd0600b520748 100644 (file)
@@ -352,7 +352,7 @@ static struct attribute *attrs[] = {
        NULL,
 };
 
-static struct attribute_group attr_groups[] = {
+static const struct attribute_group attr_groups[] = {
        [ACPI_STATE_D0] = {
                .name = "power_resources_D0",
                .attrs = attrs,
@@ -371,14 +371,14 @@ static struct attribute_group attr_groups[] = {
        },
 };
 
-static struct attribute_group wakeup_attr_group = {
+static const struct attribute_group wakeup_attr_group = {
        .name = "power_resources_wakeup",
        .attrs = attrs,
 };
 
 static void acpi_power_hide_list(struct acpi_device *adev,
                                 struct list_head *resources,
-                                struct attribute_group *attr_group)
+                                const struct attribute_group *attr_group)
 {
        struct acpi_power_resource_entry *entry;
 
@@ -397,7 +397,7 @@ static void acpi_power_hide_list(struct acpi_device *adev,
 
 static void acpi_power_expose_list(struct acpi_device *adev,
                                   struct list_head *resources,
-                                  struct attribute_group *attr_group)
+                                  const struct attribute_group *attr_group)
 {
        struct acpi_power_resource_entry *entry;
        int ret;
@@ -425,7 +425,7 @@ static void acpi_power_expose_list(struct acpi_device *adev,
 
 static void acpi_power_expose_hide(struct acpi_device *adev,
                                   struct list_head *resources,
-                                  struct attribute_group *attr_group,
+                                  const struct attribute_group *attr_group,
                                   bool expose)
 {
        if (expose)