]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commitdiff
HID: microsoft: no fallthrough in MS ergonomy 0xff05 usage
authorJiri Kosina <jkosina@suse.cz>
Sun, 15 Dec 2013 17:25:26 +0000 (18:25 +0100)
committerJiri Kosina <jkosina@suse.cz>
Sun, 15 Dec 2013 17:25:26 +0000 (18:25 +0100)
For 0xff05 usage in MS ergonomy keyboard quirk, we are falling through
and returning 0 instread of properly (because we've performed new mapping)
returning 1. Fix that.

Reported-by: Joe Perches <joe@perches.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-microsoft.c

index 551795b7da1d0cb93adbae8262803b779abe916d..c6ef6eed30915e272edf7249001d3005b9e1b667 100644 (file)
@@ -73,6 +73,7 @@ static int ms_ergonomy_kb_quirk(struct hid_input *hi, struct hid_usage *usage,
                set_bit(KEY_F16, input->keybit);
                set_bit(KEY_F17, input->keybit);
                set_bit(KEY_F18, input->keybit);
+               break;
        default:
                return 0;
        }