]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commitdiff
usb: dwc3: exynos: Handle return value of clk_prepare_enable
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Mon, 12 Jun 2017 10:53:31 +0000 (16:23 +0530)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Thu, 15 Jun 2017 08:10:27 +0000 (11:10 +0300)
clk_prepare_enable() can fail here and we must check its return value.

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/dwc3/dwc3-exynos.c

index 98f74ff66120936bad7bb166c8cd2c5fb040b460..e089df72f766eece45c73ef652c7dfe2aab6da5e 100644 (file)
@@ -125,12 +125,16 @@ static int dwc3_exynos_probe(struct platform_device *pdev)
                dev_err(dev, "couldn't get clock\n");
                return -EINVAL;
        }
-       clk_prepare_enable(exynos->clk);
+       ret = clk_prepare_enable(exynos->clk);
+       if (ret)
+               return ret;
 
        exynos->susp_clk = devm_clk_get(dev, "usbdrd30_susp_clk");
        if (IS_ERR(exynos->susp_clk))
                exynos->susp_clk = NULL;
-       clk_prepare_enable(exynos->susp_clk);
+       ret = clk_prepare_enable(exynos->susp_clk);
+       if (ret)
+               goto susp_clk_err;
 
        if (of_device_is_compatible(node, "samsung,exynos7-dwusb3")) {
                exynos->axius_clk = devm_clk_get(dev, "usbdrd30_axius_clk");
@@ -139,7 +143,9 @@ static int dwc3_exynos_probe(struct platform_device *pdev)
                        ret = -ENODEV;
                        goto axius_clk_err;
                }
-               clk_prepare_enable(exynos->axius_clk);
+               ret = clk_prepare_enable(exynos->axius_clk);
+               if (ret)
+                       goto axius_clk_err;
        } else {
                exynos->axius_clk = NULL;
        }
@@ -197,6 +203,7 @@ vdd33_err:
        clk_disable_unprepare(exynos->axius_clk);
 axius_clk_err:
        clk_disable_unprepare(exynos->susp_clk);
+susp_clk_err:
        clk_disable_unprepare(exynos->clk);
        return ret;
 }