]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
USB: legousbtower: fix use-after-free on release
authorJohan Hovold <johan@kernel.org>
Wed, 9 Oct 2019 15:38:47 +0000 (17:38 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 12 Nov 2019 18:04:35 +0000 (19:04 +0100)
commit54b1b2e9a0780bc5676af1becd93776905e6fde6
tree3be7cfd7ee16cdccae4ad30ddbbefa3239512652
parent7c89355287d774bd013ecaf48bf7f5c8af794c56
USB: legousbtower: fix use-after-free on release

BugLink: https://bugs.launchpad.net/bugs/1850541
commit 726b55d0e22ca72c69c947af87785c830289ddbc upstream.

The driver was accessing its struct usb_device in its release()
callback without holding a reference. This would lead to a
use-after-free whenever the device was disconnected while the character
device was still open.

Fixes: fef526cae700 ("USB: legousbtower: remove custom debug macro")
Cc: stable <stable@vger.kernel.org> # 3.12
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20191009153848.8664-5-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/usb/misc/legousbtower.c