]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ARM: 8806/1: kprobes: Fix false positive with FORTIFY_SOURCE
authorKees Cook <keescook@chromium.org>
Tue, 30 Oct 2018 21:12:56 +0000 (22:12 +0100)
committerSultan Alsawaf <sultan.alsawaf@canonical.com>
Wed, 24 Jul 2019 15:45:04 +0000 (09:45 -0600)
commitb694692264a1b53c118d131ceea3158aa849b75e
tree54317d07961138abe8f8073774c42a948e43a281
parent0a8d77b6c0ced4250f486e8845ff4454bd73dee0
ARM: 8806/1: kprobes: Fix false positive with FORTIFY_SOURCE

BugLink: https://bugs.launchpad.net/bugs/1837161
commit e46daee53bb50bde38805f1823a182979724c229 upstream.

The arm compiler internally interprets an inline assembly label
as an unsigned long value, not a pointer. As a result, under
CONFIG_FORTIFY_SOURCE, the address of a label has a size of 4 bytes,
which was tripping the runtime checks. Instead, we can just cast the label
(as done with the size calculations earlier).

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1639397

Reported-by: William Cohen <wcohen@redhat.com>
Fixes: 6974f0c4555e ("include/linux/string.h: add the option of fortified string.h functions")
Cc: stable@vger.kernel.org
Acked-by: Laura Abbott <labbott@redhat.com>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Tested-by: William Cohen <wcohen@redhat.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Connor Kuehl <connor.kuehl@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
arch/arm/probes/kprobes/opt-arm.c