]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
iio: adc: gyroadc: fix uninitialized return code
authorArnd Bergmann <arnd@arndb.de>
Thu, 18 Jul 2019 13:57:49 +0000 (15:57 +0200)
committerKhalid Elmously <khalid.elmously@canonical.com>
Thu, 26 Sep 2019 04:34:52 +0000 (00:34 -0400)
commitb8110114d32fb078c76f406188e0a830ab9a1e9e
tree271c6cebddf3a011c88456e0aa6d04c119c44e5a
parente32fadb565c171654ab5ad278082c532722ccae0
iio: adc: gyroadc: fix uninitialized return code

BugLink: https://bugs.launchpad.net/bugs/1844558
[ Upstream commit 90c6260c1905a68fb596844087f2223bd4657fee ]

gcc-9 complains about a blatant uninitialized variable use that
all earlier compiler versions missed:

drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]

Return -EINVAL instead here and a few lines above it where
we accidentally return 0 on failure.

Cc: stable@vger.kernel.org
Fixes: 059c53b32329 ("iio: adc: Add Renesas GyroADC driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/iio/adc/rcar-gyroadc.c