]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
UBUNTU: SAUCE: ALSA: hda/realtek - Dell headphone has noise on unmute for ALC236
authorKailang Yang <kailang@realtek.com>
Fri, 29 Nov 2019 01:16:00 +0000 (02:16 +0100)
committerMarcelo Henrique Cerri <marcelo.cerri@canonical.com>
Fri, 17 Jan 2020 17:21:59 +0000 (14:21 -0300)
BugLink: https://launchpad.net/bugs/1854401
headphone have noise even the volume is very small.
Let it fill up pcbeep hidden register to default value.
The issue was gone.

Fixes: 4344aec84bd8 ("ALSA: hda/realtek - New codec support for ALC256")
Fixes: 736f20a70608 ("ALSA: hda/realtek - Add support for ALC236/ALC3204")
Signed-off-by: Kailang Yang <kailang@realtek.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/9ae47f23a64d4e41a9c81e263cd8a250@realtek.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
(cherry picked from commit e1e8c1fdce8b00fce08784d9d738c60ebf598ebc
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Acked-by: Sultan Alsawaf <sultan.alsawaf@canonical.com>
Acked-by: Seth Forshee <seth.forshee@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
sound/pci/hda/patch_realtek.c

index e03e2d01235c1ff3711936a317cc8eb57a7daf02..adf17b7e4fd0c3cd91234b207f2122ce4cb4b2e9 100644 (file)
@@ -334,9 +334,7 @@ static void alc_fill_eapd_coef(struct hda_codec *codec)
        case 0x10ec0215:
        case 0x10ec0233:
        case 0x10ec0235:
-       case 0x10ec0236:
        case 0x10ec0255:
-       case 0x10ec0256:
        case 0x10ec0257:
        case 0x10ec0282:
        case 0x10ec0283:
@@ -348,6 +346,11 @@ static void alc_fill_eapd_coef(struct hda_codec *codec)
        case 0x10ec0300:
                alc_update_coef_idx(codec, 0x10, 1<<9, 0);
                break;
+       case 0x10ec0236:
+       case 0x10ec0256:
+               alc_write_coef_idx(codec, 0x36, 0x5757);
+               alc_update_coef_idx(codec, 0x10, 1<<9, 0);
+               break;
        case 0x10ec0275:
                alc_update_coef_idx(codec, 0xe, 0, 1<<0);
                break;