]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
usbip: tools: fix fd leakage in the function of read_attr_usbip_status
authorHewenliang <hewenliang4@huawei.com>
Fri, 25 Oct 2019 04:35:15 +0000 (00:35 -0400)
committerMarcelo Henrique Cerri <marcelo.cerri@canonical.com>
Fri, 17 Jan 2020 17:21:12 +0000 (14:21 -0300)
BugLink: https://bugs.launchpad.net/bugs/1854975
commit 26a4d4c00f85cb844dd11dd35e848b079c2f5e8f upstream.

We should close the fd before the return of read_attr_usbip_status.

Fixes: 3391ba0e2792 ("usbip: tools: Extract generic code to be shared with vudc backend")
Signed-off-by: Hewenliang <hewenliang4@huawei.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20191025043515.20053-1-hewenliang4@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
tools/usb/usbip/libsrc/usbip_host_common.c

index f5ad219a324e8a8b4591d98e26b5d804841814bd..4bb905925b0e4807f8202a569f1363d103be9625 100644 (file)
@@ -69,7 +69,7 @@ static int32_t read_attr_usbip_status(struct usbip_usb_device *udev)
        }
 
        value = atoi(status);
-
+       close(fd);
        return value;
 }