]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
rtl818x_pci: Disable pci device in error handling code
authorJia-Ju Bai <baijiaju1990@163.com>
Fri, 18 Mar 2016 02:24:51 +0000 (13:24 +1100)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 7 Apr 2016 16:37:45 +0000 (19:37 +0300)
When pci_request_regions in rtl8180_probe fails, pci_disable_device is not
called to disable the device which is enabled by pci_enbale_device.

This patch fixes the problem by adding a new lable in error handling code.

Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
Acked-by: Andrea Merello <andrea.merello@gmail.com>
Signed-off-by: Julian Calaby <julian.calaby@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c

index a43a16fde59dc88f175e4ade96b1aab48520d695..c76af5d8b8e0597255b4a268f7a65e7cc3751b02 100644 (file)
@@ -1736,7 +1736,7 @@ static int rtl8180_probe(struct pci_dev *pdev,
        if (err) {
                printk(KERN_ERR "%s (rtl8180): Cannot obtain PCI resources\n",
                       pci_name(pdev));
-               return err;
+               goto err_disable_dev;
        }
 
        io_addr = pci_resource_start(pdev, 0);
@@ -1938,6 +1938,8 @@ static int rtl8180_probe(struct pci_dev *pdev,
 
  err_free_reg:
        pci_release_regions(pdev);
+
+ err_disable_dev:
        pci_disable_device(pdev);
        return err;
 }