]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
xen/pvcalls-front: mark expected switch fall-through
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Thu, 2 Nov 2017 18:51:22 +0000 (13:51 -0500)
committerBoris Ostrovsky <boris.ostrovsky@oracle.com>
Fri, 3 Nov 2017 15:37:29 +0000 (11:37 -0400)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that in this particular case I placed the "fall through" comment
on its own line, which is what GCC is expecting to find.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
drivers/xen/pvcalls-front.c

index 0c1ec6894cc49d7062c201c5d240de58616673bb..ed94ea0b4b8e7db8ae8a8063f9886318eebbc2c6 100644 (file)
@@ -1250,7 +1250,8 @@ static void pvcalls_front_changed(struct xenbus_device *dev,
        case XenbusStateClosed:
                if (dev->state == XenbusStateClosed)
                        break;
-               /* Missed the backend's CLOSING state -- fallthrough */
+               /* Missed the backend's CLOSING state */
+               /* fall through */
        case XenbusStateClosing:
                xenbus_frontend_closed(dev);
                break;