]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
phylink: mark expected switch fall-throughs in phylink_mii_ioctl
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Fri, 5 Jan 2018 17:23:45 +0000 (11:23 -0600)
committerDavid S. Miller <davem@davemloft.net>
Mon, 8 Jan 2018 19:21:58 +0000 (14:21 -0500)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 1463447 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phylink.c

index 150cd95a6e1ed64555ee40687ce068b301004e29..249ce5cbea2201902563ceb6b9339809e8ccb99e 100644 (file)
@@ -1296,6 +1296,7 @@ int phylink_mii_ioctl(struct phylink *pl, struct ifreq *ifr, int cmd)
                switch (cmd) {
                case SIOCGMIIPHY:
                        mii->phy_id = pl->phydev->mdio.addr;
+                       /* fall through */
 
                case SIOCGMIIREG:
                        ret = phylink_phy_read(pl, mii->phy_id, mii->reg_num);
@@ -1318,6 +1319,7 @@ int phylink_mii_ioctl(struct phylink *pl, struct ifreq *ifr, int cmd)
                switch (cmd) {
                case SIOCGMIIPHY:
                        mii->phy_id = 0;
+                       /* fall through */
 
                case SIOCGMIIREG:
                        ret = phylink_mii_read(pl, mii->phy_id, mii->reg_num);