]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
block: reset bi_iter.bi_done after splitting bio
authorGreg Edwards <gedwards@ddn.com>
Thu, 26 Jul 2018 18:39:37 +0000 (14:39 -0400)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 1 Mar 2019 13:20:54 +0000 (14:20 +0100)
BugLink: http://bugs.launchpad.net/bugs/1815234
commit 5151842b9d8732d4cbfa8400b40bff894f501b2f upstream.

After the bio has been updated to represent the remaining sectors, reset
bi_done so bio_rewind_iter() does not rewind further than it should.

This resolves a bio_integrity_process() failure on reads where the
original request was split.

Fixes: 63573e359d05 ("bio-integrity: Restore original iterator on verify stage")
Signed-off-by: Greg Edwards <gedwards@ddn.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
block/bio.c

index 415c65b9c590dc403e5e79d19b1f992713a4f6e4..095da59a303cf5b13469a9b8c3386c9f42ffd985 100644 (file)
@@ -1893,6 +1893,7 @@ struct bio *bio_split(struct bio *bio, int sectors,
                bio_integrity_trim(split);
 
        bio_advance(bio, split->bi_iter.bi_size);
+       bio->bi_iter.bi_done = 0;
 
        if (bio_flagged(bio, BIO_TRACE_COMPLETION))
                bio_set_flag(split, BIO_TRACE_COMPLETION);