]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
ppp: mppe: Use vsnprintf extension %phN
authorJoe Perches <joe@perches.com>
Mon, 5 Jun 2017 12:22:50 +0000 (05:22 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 6 Jun 2017 19:16:33 +0000 (15:16 -0400)
Using this extension reduces the object size.

$ size drivers/net/ppp/ppp_mppe.o*
   text    data     bss     dec     hex filename
   5683     216       8    5907    1713 drivers/net/ppp/ppp_mppe.o.new
   5808     216       8    6032    1790 drivers/net/ppp/ppp_mppe.o.old

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ppp/ppp_mppe.c

index f60f7660b451754b37f7f62f53cf4d3bcbed2724..6c7fd98cb00a12afe89a04af55ae40cb16c825f0 100644 (file)
@@ -298,21 +298,14 @@ mppe_init(void *arg, unsigned char *options, int optlen, int unit, int debug,
        mppe_rekey(state, 1);
 
        if (debug) {
-               int i;
-               char mkey[sizeof(state->master_key) * 2 + 1];
-               char skey[sizeof(state->session_key) * 2 + 1];
-
                printk(KERN_DEBUG "%s[%d]: initialized with %d-bit %s mode\n",
                       debugstr, unit, (state->keylen == 16) ? 128 : 40,
                       (state->stateful) ? "stateful" : "stateless");
-
-               for (i = 0; i < sizeof(state->master_key); i++)
-                       sprintf(mkey + i * 2, "%02x", state->master_key[i]);
-               for (i = 0; i < sizeof(state->session_key); i++)
-                       sprintf(skey + i * 2, "%02x", state->session_key[i]);
                printk(KERN_DEBUG
-                      "%s[%d]: keys: master: %s initial session: %s\n",
-                      debugstr, unit, mkey, skey);
+                      "%s[%d]: keys: master: %*phN initial session: %*phN\n",
+                      debugstr, unit,
+                      (int)sizeof(state->master_key), state->master_key,
+                      (int)sizeof(state->session_key), state->session_key);
        }
 
        /*