]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
RDMA/hns: Replace __raw_write*(cpu_to_le*()) with LE write*()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 14 Feb 2018 18:11:17 +0000 (20:11 +0200)
committerKhalid Elmously <khalid.elmously@canonical.com>
Tue, 12 Jun 2018 06:28:55 +0000 (02:28 -0400)
BugLink: https://bugs.launchpad.net/bugs/1770974
There is no need to repeat the semantics of writel() and similar.
Moreover sparse complains about this:

drivers/infiniband/hw/hns/hns_roce_hw_v1.c:1690:22: expected unsigned long long val
drivers/infiniband/hw/hns/hns_roce_hw_v1.c:1690:22: got restricted __le64 <noident>

Fixing this by replacing __raw_write*(cpu_to_le*()) calls by plain
write*() ones.

Note, write*() accessors are little endian by definition.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
(cherry picked from commit 71591d1280e5ef02c2af2ffb9801d0c842973be9)
Signed-off-by: dann frazier <dann.frazier@canonical.com>
Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/infiniband/hw/hns/hns_roce_hw_v1.c
drivers/infiniband/hw/hns/hns_roce_hw_v2.c

index da13bd7c3ca99617ebf9d9f6d831660bde531bc5..47e1b6ac1e1acdd38e9f88cfec179a50471fee29 100644 (file)
@@ -1687,13 +1687,13 @@ static int hns_roce_v1_post_mbox(struct hns_roce_dev *hr_dev, u64 in_param,
        roce_set_field(val, ROCEE_MB6_ROCEE_MB_TOKEN_M,
                       ROCEE_MB6_ROCEE_MB_TOKEN_S, token);
 
-       __raw_writeq(cpu_to_le64(in_param), hcr + 0);
-       __raw_writeq(cpu_to_le64(out_param), hcr + 2);
-       __raw_writel(cpu_to_le32(in_modifier), hcr + 4);
+       writeq(in_param, hcr + 0);
+       writeq(out_param, hcr + 2);
+       writel(in_modifier, hcr + 4);
        /* Memory barrier */
        wmb();
 
-       __raw_writel(cpu_to_le32(val), hcr + 5);
+       writel(val, hcr + 5);
 
        mmiowb();
 
index 122ff7477407e1b89945edcdb655aa82d9aa2c68..58228d6e2da75911a8271b573a3d39dd26e27f51 100644 (file)
@@ -1218,14 +1218,14 @@ static int hns_roce_v2_post_mbox(struct hns_roce_dev *hr_dev, u64 in_param,
        roce_set_field(val1, HNS_ROCE_VF_MB5_TOKEN_MASK,
                       HNS_ROCE_VF_MB5_TOKEN_SHIFT, token);
 
-       __raw_writeq(cpu_to_le64(in_param), hcr + 0);
-       __raw_writeq(cpu_to_le64(out_param), hcr + 2);
+       writeq(in_param, hcr + 0);
+       writeq(out_param, hcr + 2);
 
        /* Memory barrier */
        wmb();
 
-       __raw_writel(cpu_to_le32(val0), hcr + 4);
-       __raw_writel(cpu_to_le32(val1), hcr + 5);
+       writel(val0, hcr + 4);
+       writel(val1, hcr + 5);
 
        mmiowb();