]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
drm/rockchip: dw-mipi-dsi: fix possible un-balanced runtime PM enable
authorMirza Krak <mirza.krak@endian.se>
Wed, 15 Nov 2017 08:24:46 +0000 (08:24 +0000)
committerSandy Huang <hjc@rock-chips.com>
Mon, 27 Nov 2017 01:30:53 +0000 (09:30 +0800)
In the case where the bind gets deferred we would end up with a
un-balanced runtime PM enable call.

Fix this by simply moving the pm_runtime_enable call to the end of
the bind function when all paths have succeeded.

Signed-off-by: Mirza Krak <mirza.krak@endian.se>
Signed-off-by: Sandy Huang <hjc@rock-chips.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1510734286-37434-1-git-send-email-mirza.krak@endian.se
drivers/gpu/drm/rockchip/dw-mipi-dsi.c

index 9a20b9dc27c834ab3d92a709dba64d0a4aec550e..f7fc652b00270302cffdf07740d5652e1f1ef3f4 100644 (file)
@@ -1275,8 +1275,6 @@ static int dw_mipi_dsi_bind(struct device *dev, struct device *master,
                goto err_pllref;
        }
 
-       pm_runtime_enable(dev);
-
        dsi->dsi_host.ops = &dw_mipi_dsi_host_ops;
        dsi->dsi_host.dev = dev;
        ret = mipi_dsi_host_register(&dsi->dsi_host);
@@ -1291,6 +1289,7 @@ static int dw_mipi_dsi_bind(struct device *dev, struct device *master,
        }
 
        dev_set_drvdata(dev, dsi);
+       pm_runtime_enable(dev);
        return 0;
 
 err_mipi_dsi_host: