crypto: user - fix memory leak in crypto_report

BugLink: https://bugs.launchpad.net/bugs/1857158
commit ffdde5932042600c6807d46c1550b28b0db6a3bc upstream.

In crypto_report, a new skb is created via nlmsg_new(). This skb should
be released if crypto_report_alg() fails.

Fixes: a38f7907b926 ("crypto: Add userspace configuration API")
Cc: <stable@vger.kernel.org>
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

diff --git a/crypto/crypto_user.c b/crypto/crypto_user.c
index 5e457a7dd1c923ab04b3384b9f9987bf496477b1..b6899be8065d3a05758aa3d89b45ed99855c8df9 100644 (file)
--- a/crypto/crypto_user.c
+++ b/crypto/crypto_user.c
@@ -288,8 +288,10 @@ static int crypto_report(struct sk_buff *in_skb, struct nlmsghdr *in_nlh,
 drop_alg:
        crypto_mod_put(alg);
 
-       if (err)
+       if (err) {
+               kfree_skb(skb);
                return err;
+       }
 
        return nlmsg_unicast(crypto_nlsk, skb, NETLINK_CB(in_skb).portid);
 }